From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2726 invoked by alias); 18 Oct 2014 21:07:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2711 invoked by uid 89); 18 Oct 2014 21:07:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f46.google.com Received: from mail-la0-f46.google.com (HELO mail-la0-f46.google.com) (209.85.215.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 18 Oct 2014 21:07:46 +0000 Received: by mail-la0-f46.google.com with SMTP id gi9so2240975lab.19 for ; Sat, 18 Oct 2014 14:07:42 -0700 (PDT) X-Received: by 10.112.166.1 with SMTP id zc1mr4324944lbb.90.1413666462921; Sat, 18 Oct 2014 14:07:42 -0700 (PDT) Received: from localhost.home ([95.91.210.188]) by mx.google.com with ESMTPSA id z5sm1631332lae.21.2014.10.18.14.07.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Oct 2014 14:07:42 -0700 (PDT) From: Krzesimir Nowak To: gcc-patches@gcc.gnu.org Cc: Krzesimir Nowak Subject: [PATCH] PR preprocessor/42014 Date: Sat, 18 Oct 2014 21:07:00 -0000 Message-Id: <1413666451-15144-1-git-send-email-qdlacz@gmail.com> X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg01825.txt.bz2 Hello. This is my first patch for GCC. I already started a paperwork for copyright assignment (sent an email to fsf-records at gnu org) - waiting for response. So, about this patch - it basically removes column printing from "In file included from ..." lines, as the column information always returned 0. Not sure if this is correct assumption - I tested only C and C++, so I don't know if other frontends (ada, go?) provide column information for include lines. Anyway, column information here is probably not useful. Or maybe it is, if GCC supports some language with include syntax like followish: #include , , Maybe in this case printing column number has sense? I need help with testcase - I don't know how to implement it correctly. The output of compilation is something like this: In file included from .../pr42014-2.h:2, from .../pr42014-1.h:3, from .../pr42014.c:4: .../pr42014-3.h:1:7: error: 'foo' was not declared in this scope How to check the "from" lines? Is there some dg-foo (dg-grep?) command for it? dg-excess-errors is likely not suited for this purpose. Also, do I need to run make -k check for both vanilla and changed GCC to compare the results? These tests take ages to complete, so maybe there is some subset of tests which is enough for regression checking in this case? Currently I am only running following command in gcc directory: make check-c++ RUNTESTFLAGS="-v dg.exp=cpp/pr42014.c" Krzesimir Nowak (1): Fix PR preprocessor/42014 gcc/ChangeLog | 6 ++++++ gcc/diagnostic.c | 27 +++++++++++++++------------ gcc/testsuite/ChangeLog | 8 ++++++++ gcc/testsuite/c-c++-common/cpp/pr42014-1.h | 3 +++ gcc/testsuite/c-c++-common/cpp/pr42014-2.h | 2 ++ gcc/testsuite/c-c++-common/cpp/pr42014-3.h | 1 + gcc/testsuite/c-c++-common/cpp/pr42014.c | 8 ++++++++ 7 files changed, 43 insertions(+), 12 deletions(-) create mode 100644 gcc/testsuite/c-c++-common/cpp/pr42014-1.h create mode 100644 gcc/testsuite/c-c++-common/cpp/pr42014-2.h create mode 100644 gcc/testsuite/c-c++-common/cpp/pr42014-3.h create mode 100644 gcc/testsuite/c-c++-common/cpp/pr42014.c -- 1.9.3