From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24372 invoked by alias); 12 Nov 2014 13:38:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24353 invoked by uid 89); 12 Nov 2014 13:38:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Nov 2014 13:38:07 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sACDc0Xa005472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Nov 2014 08:38:00 -0500 Received: from [10.3.236.104] (vpn-236-104.phx2.redhat.com [10.3.236.104]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sACDbvKk009186; Wed, 12 Nov 2014 08:37:57 -0500 Message-ID: <1415799214.2209.39.camel@surprise> Subject: Re: libgomp: "GNU OpenMP Runtime Library" (was: [PATCH 1/5] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin (repost)) From: David Malcolm To: Jakub Jelinek Cc: Thomas Schwinge , gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, Ilya Verbin , Julian Brown Date: Wed, 12 Nov 2014 13:40:00 -0000 In-Reply-To: <20141112113329.GX5026@tucnak.redhat.com> References: <20140923191931.2177e60f@octopus> <20141111135323.29e0f27b@octopus> <20141112100626.GP5026@tucnak.redhat.com> <87389opszu.fsf@schwinge.name> <20141112113329.GX5026@tucnak.redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg01209.txt.bz2 On Wed, 2014-11-12 at 12:33 +0100, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 12:18:13PM +0100, Thomas Schwinge wrote: > > On Wed, 12 Nov 2014 11:06:26 +0100, Jakub Jelinek wrote: > > > On Tue, Nov 11, 2014 at 01:53:23PM +0000, Julian Brown wrote: > > > > --- a/libgomp/configure.ac > > > > +++ b/libgomp/configure.ac > > > > @@ -2,6 +2,8 @@ > > > > # aclocal -I ../config && autoconf && autoheader && automake > > > > > > > > AC_PREREQ(2.64) > > > > +#TODO: Update for OpenACC? But then also have to update copyright notices in > > > > +#all source files... > > | > AC_INIT([GNU OpenMP Runtime Library], 1.0,,[libgomp]) > > > > > > Please drop this. > > > > (I agree to drop the TODO marker, obviously.) Note that I'm not trying > > to drive this into a "bikeshedding" discussion, and neither is my > > intention to discredit the lots of pioneering OpenMP work in GCC (which > > we're largely basing our OpenACC work on -- thanks!). > > > > The underlying question here is, with offloading generally as well as the > > OpenACC Runtime Library also to be living in libgomp, calling it "GNU > > OpenMP Runtime Library" is no longer accurate. (Also, I'm not proposing > > to change the libgomp library name -- that would probably be too much of > > a hassle?) Do we want a new "verbose" name for libgomp, "GNU Offloading, > > OpenACC, and OpenMP Runtime Library" (sorting alphabetically), or > > something else, or no change. I'm afraid that not changing it will be > > confusing to users who are looking for the GCC implementation of the > > OpenACC Runtime Library, for example? > > Yeah, it is something I wanted to mention in the review of the documentation > patch, calling it just GNU OpenMP Runtime Library is not right after > it handles OpenACC too, but GNU Offloading, OpenACC and OpenMP Runtime > Library sounds bad to me too, because offloading (both OpenMP offloading and > OpenACC offloading) is actually only a small part of what the library is > about, I still view the library primarily as being a runtime for > OpenMP parallelization, tasking etc.; that's how it started and even OpenMP > offloading is just a matter of the last year (and until today in upstream > not even any actual offloading), for OpenACC it is solely about > offloading and directives in the offloaded code, right? > > So, don't want to bikeshed, but I'd call it > GNU OpenMP and OpenACC Runtime Library simply from the things what it does > and how it evolved, I know it isn't alphabetically sorted that way, but > it will the library has more than 9 years of history now and tons of users > already. Apologies for bikeshedding, and I normally dislike "cute" names, but renaming it to "GNU Offloading and Multi Processing library" would allow a backronym of "libgomp", thus preserving the existing filenames/SONAME etc. Dave