From: Xi Ruoyao <xry111@xry111.site>
To: Yang Yujie <yangyujie@loongson.cn>
Cc: gcc-patches@gcc.gnu.org, chenglulu@loongson.cn, xuchenghua@loongson.cn
Subject: Re: [PATCH v3] LoongArch: Fix eh_return epilogue for normal returns
Date: Thu, 07 Dec 2023 16:13:51 +0800 [thread overview]
Message-ID: <14172450f123ec8a3dab8769de95358016d52904.camel@xry111.site> (raw)
In-Reply-To: <ym3ohjepscy5ovp4oh352h3klajoczlaanq4irrwp7eg7tlldc@q6cstnjjpycz>
On Thu, 2023-12-07 at 14:18 +0800, Yang Yujie wrote:
> On Thu, Dec 07, 2023 at 11:02:58AM +0800, Xi Ruoyao wrote:
> >
> > I don't like this pair of {} for the for statement. It's not necessary
> > and it changes the indent level, causing the diff hard to review.
> >
> > Otherwise LGTM. I'm not sure why I didn't notice the eh_return issue
> > when I learnt shrink wrapping from RISC-V...
> >
>
> Thanks for the review! This problem on LoongArch was first noticed in a
> failed libphobos test case, and the fix is partially borrowed from i386,
> which seemed to be the only architecture without this issue.
>
> So despite the extra braces (which I'd say I prefer to have because of the
> new block of comment inserted on top of the if statement :P), I am going to
> ask Lulu for pushing this.
I understand and I don't think adding {} is wrong. The problem is the
indent change causes a large chunk of diff and it makes reviewing more
difficult. Thus generally we should not mix real code change and format
change in a commit.
i. e. it would be better to separate it into two patches, the first adds
{} and changes the indent, and the second changes the logic. But now I
don't think it's needed to make a V4, just pushing this should be fine.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-12-07 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 1:40 [PATCH v3 0/1] " Yang Yujie
2023-12-07 1:40 ` [PATCH v3] " Yang Yujie
2023-12-07 3:02 ` Xi Ruoyao
2023-12-07 6:18 ` Yang Yujie
2023-12-07 8:13 ` Xi Ruoyao [this message]
2023-12-08 2:10 ` Yang Yujie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14172450f123ec8a3dab8769de95358016d52904.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=xuchenghua@loongson.cn \
--cc=yangyujie@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).