* Re: [SH][committed] Fix usage of __SHMEDIA__ in libgcc
[not found] <1417374502.3387.72.camel@yam-132-YW-E178-FTW>
@ 2014-12-09 22:52 ` Oleg Endo
0 siblings, 0 replies; only message in thread
From: Oleg Endo @ 2014-12-09 22:52 UTC (permalink / raw)
To: gcc-patches
On Sun, 2014-11-30 at 20:08 +0100, Oleg Endo wrote:
> Hi,
>
> In libgcc/lib1funcs.S the usage of the __SHMEDIA__ macro seems to
> mismatch the setup in sh/sh-c.c (sh_cpu_cpp_builtins). __SHMEDIA__ is
> always defined when building for SH5 / SH64, even when the subtarget is
> SHcompact. Thus, when building for SHcompact testing '#ifdef
> __SHMEDIA__' will result in the wrong answer and try to compile SHmedia
> code which doesn't work. Testing the value of __SHMEDIA__ seems to fix
> the issue.
> Tested with 'make all' for sh-elf and sh64-elf, which builds various
> multilib versions of libgcc. Committed as r218190.
>
> Cheers,
> Oleg
>
> libgcc/ChangeLog:
> * config/sh/lib1funcs.S: Check value of __SHMEDIA__ instead of checking
> whether it's defined.
Turns out there was already a PR 55351 for that.
Committed to 4.9 (r218544) and 4.8 (r218545).
Cheers,
Oleg
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-12-09 22:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1417374502.3387.72.camel@yam-132-YW-E178-FTW>
2014-12-09 22:52 ` [SH][committed] Fix usage of __SHMEDIA__ in libgcc Oleg Endo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).