From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20932 invoked by alias); 7 Jan 2015 15:38:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20842 invoked by uid 89); 7 Jan 2015 15:38:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 07 Jan 2015 15:38:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t07FclD1000830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Jan 2015 10:38:47 -0500 Received: from c64.redhat.com (vpn-227-171.phx2.redhat.com [10.3.227.171]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t07FckZB018919; Wed, 7 Jan 2015 10:38:46 -0500 From: David Malcolm To: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH, committed] jit.exp: Don't drop the extension from the testcase when naming executable Date: Wed, 07 Jan 2015 15:38:00 -0000 Message-Id: <1420645643-55506-1-git-send-email-dmalcolm@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00321.txt.bz2 Previously, "test-foo.c" would be built by jit.exp as "test-foo.exe". However, we have various test-foo.c vs test-foo.cc testcases. We don't want them to clobber each other's executables (especially if we're going to parallelize the jit testsuite). Hence retain the extension, so they are built to "test-foo.c.exe" and "test-foo.cc.exe". Doing so also ensures that the source name makes it into the pass/fail output, so that we can distinguish e.g. which test-foo is failing. jit.sum remains: # of expected passes 5008 (we don't yet actually run the .cc testcases due to another issue, but this patch ought to help with debugging that) Committed to trunk as r219312. gcc/jit/ChangeLog: * docs/internals/index.rst: Update to reflect that built testcases are now test-foo.c.exe, rather than test-foo.exe. * docs/_build/texinfo/libgccjit.texi: Regenerate. gcc/testsuite/ChangeLog: * jit.dg/jit.exp (jit-dg-test): Remove "rootname" call when generating name of built executable. --- gcc/jit/docs/internals/index.rst | 8 ++++---- gcc/testsuite/jit.dg/jit.exp | 14 +++++++++++++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/gcc/jit/docs/internals/index.rst b/gcc/jit/docs/internals/index.rst index 50c55b0..694f058 100644 --- a/gcc/jit/docs/internals/index.rst +++ b/gcc/jit/docs/internals/index.rst @@ -125,7 +125,7 @@ and once a test has been compiled, you can debug it directly: LD_LIBRARY_PATH=. \ LIBRARY_PATH=. \ gdb --args \ - testsuite/jit/test-factorial.exe + testsuite/jit/test-factorial.c.exe Running under valgrind ********************** @@ -161,11 +161,11 @@ For example, the following invocation verbosely runs the testcase $ less testsuite/jit/jit.sum (...other results...) - XFAIL: jit.dg/test-sum-of-squares.c: test-sum-of-squares.exe.valgrind.txt: definitely lost: 8 bytes in 1 blocks - XFAIL: jit.dg/test-sum-of-squares.c: test-sum-of-squares.exe.valgrind.txt: unsuppressed errors: 1 + XFAIL: jit.dg/test-sum-of-squares.c: test-sum-of-squares.c.exe.valgrind.txt: definitely lost: 8 bytes in 1 blocks + XFAIL: jit.dg/test-sum-of-squares.c: test-sum-of-squares.c.exe.valgrind.txt: unsuppressed errors: 1 (...other results...) - $ less testsuite/jit/test-sum-of-squares.exe.valgrind.txt + $ less testsuite/jit/test-sum-of-squares.c.exe.valgrind.txt (...shows full valgrind report for this test case...) When running under valgrind, it's best to have configured gcc with diff --git a/gcc/testsuite/jit.dg/jit.exp b/gcc/testsuite/jit.dg/jit.exp index 454e656..474d6f8 100644 --- a/gcc/testsuite/jit.dg/jit.exp +++ b/gcc/testsuite/jit.dg/jit.exp @@ -325,7 +325,19 @@ proc jit-dg-test { prog do_what extra_tool_flags } { } # Determine what to name the built executable. - set output_file "[file rootname [file tail $prog]].exe" + # + # We simply append .exe to the filename, e.g. + # "test-foo.c.exe" + # since some testcases exist in both + # "test-foo.c" and + # "test-foo.cc" + # variants, and we don't want them to clobber each other's + # executables. + # + # This also ensures that the source name makes it into the + # pass/fail output, so that we can distinguish e.g. which test-foo + # is failing. + set output_file "[file tail $prog].exe" verbose "output_file: $output_file" # Create the test executable: -- 1.8.5.3