* [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
@ 2012-07-07 14:48 Steven Bosscher
2012-07-07 15:07 ` H.J. Lu
0 siblings, 1 reply; 11+ messages in thread
From: Steven Bosscher @ 2012-07-07 14:48 UTC (permalink / raw)
To: GCC Patches; +Cc: Mike Stump, Jack Howarth
Hello,
PR26840 was fixed long ago so this work-around shouldn't be necessary anymore:
Index: ../libgcc/config/t-darwin
===================================================================
--- ../libgcc/config/t-darwin (revision 189348)
+++ ../libgcc/config/t-darwin (working copy)
@@ -1,7 +1,5 @@
-# Pass -fno-tree-dominator-opts to work around bug 26840.
crt3.o: $(srcdir)/config/darwin-crt3.c
- $(crt_compile) \
- -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
+ $(crt_compile) -fno-tree-dominator-opts
$(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
crttms.o: $(srcdir)/config/darwin-crt-tm.c
$(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -DSTART -c $<
Request for testing because I have no access to a Darwin machine.
Thanks,
Ciao!
Steven
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-07 14:48 [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin Steven Bosscher
@ 2012-07-07 15:07 ` H.J. Lu
2012-07-07 15:35 ` Steven Bosscher
0 siblings, 1 reply; 11+ messages in thread
From: H.J. Lu @ 2012-07-07 15:07 UTC (permalink / raw)
To: Steven Bosscher; +Cc: GCC Patches, Mike Stump, Jack Howarth
On Sat, Jul 7, 2012 at 7:48 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> Hello,
>
>
> PR26840 was fixed long ago so this work-around shouldn't be necessary anymore:
>
> Index: ../libgcc/config/t-darwin
> ===================================================================
> --- ../libgcc/config/t-darwin (revision 189348)
> +++ ../libgcc/config/t-darwin (working copy)
> @@ -1,7 +1,5 @@
> -# Pass -fno-tree-dominator-opts to work around bug 26840.
> crt3.o: $(srcdir)/config/darwin-crt3.c
> - $(crt_compile) \
> - -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
> + $(crt_compile) -fno-tree-dominator-opts
> $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
>
Are you sure this the right patch? -fno-tree-dominator-opts is still here.
--
H.J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-07 15:07 ` H.J. Lu
@ 2012-07-07 15:35 ` Steven Bosscher
2012-07-09 6:07 ` Paolo Bonzini
2012-07-09 8:11 ` Iain Sandoe
0 siblings, 2 replies; 11+ messages in thread
From: Steven Bosscher @ 2012-07-07 15:35 UTC (permalink / raw)
To: H.J. Lu; +Cc: GCC Patches, Mike Stump, Jack Howarth
On Sat, Jul 7, 2012 at 5:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> Are you sure this the right patch? -fno-tree-dominator-opts is still here.
I am sure it is not the right patch :-)
Thanks!
Index: libgcc/config/t-darwin
===================================================================
--- libgcc/config/t-darwin (revision 189348)
+++ libgcc/config/t-darwin (working copy)
@@ -1,7 +1,5 @@
-# Pass -fno-tree-dominator-opts to work around bug 26840.
crt3.o: $(srcdir)/config/darwin-crt3.c
- $(crt_compile) \
- -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
+ $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
crttms.o: $(srcdir)/config/darwin-crt-tm.c
$(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -DSTART -c $<
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-07 15:35 ` Steven Bosscher
@ 2012-07-09 6:07 ` Paolo Bonzini
2012-07-09 8:11 ` Iain Sandoe
1 sibling, 0 replies; 11+ messages in thread
From: Paolo Bonzini @ 2012-07-09 6:07 UTC (permalink / raw)
To: Steven Bosscher; +Cc: H.J. Lu, GCC Patches, Mike Stump, Jack Howarth
Il 07/07/2012 17:34, Steven Bosscher ha scritto:
> On Sat, Jul 7, 2012 at 5:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> Are you sure this the right patch? -fno-tree-dominator-opts is still here.
>
> I am sure it is not the right patch :-)
> Thanks!
>
> Index: libgcc/config/t-darwin
> ===================================================================
> --- libgcc/config/t-darwin (revision 189348)
> +++ libgcc/config/t-darwin (working copy)
> @@ -1,7 +1,5 @@
> -# Pass -fno-tree-dominator-opts to work around bug 26840.
> crt3.o: $(srcdir)/config/darwin-crt3.c
> - $(crt_compile) \
> - -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
> + $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
>
> crttms.o: $(srcdir)/config/darwin-crt-tm.c
> $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -DSTART -c $<
>
Ok if testing passes.
Paolo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-07 15:35 ` Steven Bosscher
2012-07-09 6:07 ` Paolo Bonzini
@ 2012-07-09 8:11 ` Iain Sandoe
2012-07-09 8:21 ` Iain Sandoe
1 sibling, 1 reply; 11+ messages in thread
From: Iain Sandoe @ 2012-07-09 8:11 UTC (permalink / raw)
To: Steven Bosscher
Cc: GCC Patches, Mike Stump, Jack Howarth, Dominique Dhumieres
Hi Steven,
On 7 Jul 2012, at 16:34, Steven Bosscher wrote:
> On Sat, Jul 7, 2012 at 5:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> Are you sure this the right patch? -fno-tree-dominator-opts is still here.
>
> I am sure it is not the right patch :-)
> Thanks!
>
> Index: libgcc/config/t-darwin
> ===================================================================
> --- libgcc/config/t-darwin (revision 189348)
> +++ libgcc/config/t-darwin (working copy)
> @@ -1,7 +1,5 @@
> -# Pass -fno-tree-dominator-opts to work around bug 26840.
> crt3.o: $(srcdir)/config/darwin-crt3.c
> - $(crt_compile) \
> - -fno-tree-dominator-opts $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
> + $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -c $<
>
> crttms.o: $(srcdir)/config/darwin-crt-tm.c
> $(crt_compile) $(DARWIN_EXTRA_CRT_BUILD_CFLAGS) -DSTART -c $<
regstrapped (all+ada+objc++) on i686-darwin9 with no regressions.
Iain
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-09 8:11 ` Iain Sandoe
@ 2012-07-09 8:21 ` Iain Sandoe
2012-07-10 23:02 ` Iain Sandoe
0 siblings, 1 reply; 11+ messages in thread
From: Iain Sandoe @ 2012-07-09 8:21 UTC (permalink / raw)
To: Steven Bosscher
Cc: GCC Patches, Mike Stump, Jack Howarth, Dominique Dhumieres
On 9 Jul 2012, at 09:11, Iain Sandoe wrote:
>> crt3.o: $(srcdir)/config/darwin-crt3.c
> regstrapped (all+ada+objc++) on i686-darwin9 with no regressions.
.. but, now I re-check, crt3 is only used on Darwin 8 and earlier;
That will take somewhat longer to check, machine availability is an issue - I'll see if I can run up a i686 or ppc darwin8 box.
Iain
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-09 8:21 ` Iain Sandoe
@ 2012-07-10 23:02 ` Iain Sandoe
2012-07-13 7:29 ` Iain Sandoe
0 siblings, 1 reply; 11+ messages in thread
From: Iain Sandoe @ 2012-07-10 23:02 UTC (permalink / raw)
To: Steven Bosscher
Cc: GCC Patches, Mike Stump, Jack Howarth, Dominique Dhumieres
Hi Steven,
On 9 Jul 2012, at 09:21, Iain Sandoe wrote:
> On 9 Jul 2012, at 09:11, Iain Sandoe wrote:
>>> crt3.o: $(srcdir)/config/darwin-crt3.c
>
>> regstrapped (all+ada+objc++) on i686-darwin9 with no regressions.
>
> .. but, now I re-check, crt3 is only used on Darwin 8 and earlier;
> That will take somewhat longer to check, machine availability is an issue - I'll see if I can run up a i686 or ppc darwin8 box.
Looking at the original PR it seems that the problem was fixed on the same day that the work-around (which your patch removes) was checked in.
I've only done c/c++, should be enough for this.
Anyway, although i686-Darwin 8 is sadly in need of some TLC, the proposed patch causes no regressions.
ppc-darwin 8 tests are still running, but it bootstrapped (500M G4, > 24hrs for c/c++ build & test).
Iain.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-10 23:02 ` Iain Sandoe
@ 2012-07-13 7:29 ` Iain Sandoe
2012-07-13 23:21 ` Mike Stump
0 siblings, 1 reply; 11+ messages in thread
From: Iain Sandoe @ 2012-07-13 7:29 UTC (permalink / raw)
To: Steven Bosscher
Cc: GCC Patches, Mike Stump, Jack Howarth, Dominique Dhumieres
On 11 Jul 2012, at 00:01, Iain Sandoe wrote:
> Anyway, although i686-Darwin 8 is sadly in need of some TLC, the proposed patch causes no regressions.
> ppc-darwin 8 tests are still running, but it bootstrapped (500M G4, > 24hrs for c/c++ build & test).
FAOD, from a testing perspective this is fine - but it needs Mike's OK,
cheers
Iain
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-13 7:29 ` Iain Sandoe
@ 2012-07-13 23:21 ` Mike Stump
2012-07-14 6:59 ` Iain Sandoe
0 siblings, 1 reply; 11+ messages in thread
From: Mike Stump @ 2012-07-13 23:21 UTC (permalink / raw)
To: Iain Sandoe
Cc: Steven Bosscher, GCC Patches, Jack Howarth, Dominique Dhumieres
On Jul 13, 2012, at 12:28 AM, Iain Sandoe wrote:
> On 11 Jul 2012, at 00:01, Iain Sandoe wrote:
>> Anyway, although i686-Darwin 8 is sadly in need of some TLC, the proposed patch causes no regressions.
>> ppc-darwin 8 tests are still running, but it bootstrapped (500M G4, > 24hrs for c/c++ build & test).
>
> FAOD, from a testing perspective this is fine - but it needs Mike's OK,
Hum, no, it doesn't, it has already been approved by Paolo, and I don't disagree with that approval.... :-)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
2012-07-13 23:21 ` Mike Stump
@ 2012-07-14 6:59 ` Iain Sandoe
0 siblings, 0 replies; 11+ messages in thread
From: Iain Sandoe @ 2012-07-14 6:59 UTC (permalink / raw)
To: Mike Stump
Cc: Steven Bosscher, GCC Patches, Jack Howarth, Dominique Dhumieres
On 14 Jul 2012, at 00:21, Mike Stump wrote:
> On Jul 13, 2012, at 12:28 AM, Iain Sandoe wrote:
>> On 11 Jul 2012, at 00:01, Iain Sandoe wrote:
>>> Anyway, although i686-Darwin 8 is sadly in need of some TLC, the proposed patch causes no regressions.
>>> ppc-darwin 8 tests are still running, but it bootstrapped (500M G4, > 24hrs for c/c++ build & test).
>>
>> FAOD, from a testing perspective this is fine - but it needs Mike's OK,
>
> Hum, no, it doesn't, it has already been approved by Paolo, and I don't disagree with that approval.... :-)
apologies, I missed a post.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin
@ 2012-07-08 11:08 Dominique Dhumieres
0 siblings, 0 replies; 11+ messages in thread
From: Dominique Dhumieres @ 2012-07-08 11:08 UTC (permalink / raw)
To: gcc-patches; +Cc: iain, stevenb.gcc
> Request for testing because I have no access to a Darwin machine.
I just finished a clean bootstrap with the (second!-) patch on
x86_64-apple-darwin10; regtesting scheduled for tonight.
Bootstrapping powerpc-apple-darwin9 is now at stage 2.
Dominique
PS AFAICT pr26840 is indeed fixed.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-07-14 6:59 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-07 14:48 [RFT] Remove -fno-tree-dominator-opts from libgcc/config/t-darwin Steven Bosscher
2012-07-07 15:07 ` H.J. Lu
2012-07-07 15:35 ` Steven Bosscher
2012-07-09 6:07 ` Paolo Bonzini
2012-07-09 8:11 ` Iain Sandoe
2012-07-09 8:21 ` Iain Sandoe
2012-07-10 23:02 ` Iain Sandoe
2012-07-13 7:29 ` Iain Sandoe
2012-07-13 23:21 ` Mike Stump
2012-07-14 6:59 ` Iain Sandoe
2012-07-08 11:08 Dominique Dhumieres
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).