From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30008 invoked by alias); 20 Mar 2015 22:42:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29998 invoked by uid 89); 20 Mar 2015 22:42:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e8.ny.us.ibm.com Received: from e8.ny.us.ibm.com (HELO e8.ny.us.ibm.com) (32.97.182.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 20 Mar 2015 22:42:05 +0000 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Mar 2015 18:42:03 -0400 Received: from d01dlp01.pok.ibm.com (9.56.250.166) by e8.ny.us.ibm.com (192.168.1.108) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 20 Mar 2015 18:42:02 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 9FAB738C8026 for ; Fri, 20 Mar 2015 18:42:01 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2KMg1gE21037080 for ; Fri, 20 Mar 2015 22:42:01 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2KMg1pl003607 for ; Fri, 20 Mar 2015 18:42:01 -0400 Received: from [9.65.226.85] (sig-9-65-226-85.ibm.com [9.65.226.85]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t2KMfxxt003569; Fri, 20 Mar 2015 18:42:00 -0400 Subject: Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state From: Peter Bergner To: Segher Boessenkool Cc: GCC Patches , David Edelsohn , Michael Meissner , Bill Schmidt In-Reply-To: <20150320205200.GA32613@gate.crashing.org> References: <1426879660.13627.71.camel@otta> <20150320205200.GA32613@gate.crashing.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 20 Mar 2015 22:42:00 -0000 Message-ID: <1426891319.13627.101.camel@otta> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15032022-0029-0000-0000-0000024647E6 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01124.txt.bz2 On Fri, 2015-03-20 at 15:52 -0500, Segher Boessenkool wrote: > Maybe it would be nicer if the builtin-expansion code handled the copy > from cc, instead of stacking on RTL expanders. That would allow getting rid of the expanders completely, which would be nice. I'd have to somehow add some type of RS6000_BTC_* flag onto the builtin though, so I can tell during builtin expansion whether I need to emit the cr copy code or not. I'll give that a try ...when I return from sunny Mexico in a week. :-) Thanks for the suggestion. > > (define_expand "tabortdc" [snip] > > + (match_operand 1 "u5bit_cint_operand" "n") [snip] > > Expanders have no constraints (you can leave out the field completely). > Doesn't gen* warn on non-empty constraints? Correct, and David mentioned this when I first submitted the original HTM patch, but I replied they were added to allow better error messages when people used out of range integers for builtin args: https://gcc.gnu.org/ml/gcc-patches/2013-07/msg00565.html > > --- gcc/testsuite/gcc.target/powerpc/htm-1.c (revision 0) > > +++ gcc/testsuite/gcc.target/powerpc/htm-1.c (working copy) > > @@ -0,0 +1,53 @@ > > +/* { dg-do run { target { powerpc*-*-* && htm_hw } } } */ > > +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ > > htm_hw already disallows Darwin? [ And {"*"} {""} is default. ] > > > + # For now, disable on Darwin > > + if { [istarget powerpc-*-eabi] || [istarget powerpc*-*-eabispe] || [istarget *-*-darwin*]} { > > + expr 0 > > If ever HTM is enabled on Darwin, the testcases should Just Work as far > as I see. Heh, just cut/pasted the dg-do-skip from another test case, but yes, we can remove it. Thanks. It's too bad we can't have a "dg-do run" and a "dg-do compile", one used when we're on HTM hardware and the other when we're not, so we can at least compile the test case. Peter