* [PATCH] fix building for alpha-dec-vms
@ 2015-03-27 10:24 tbsaunde+gcc
2015-04-08 13:57 ` Bernhard Reutner-Fischer
2015-04-08 14:03 ` Richard Biener
0 siblings, 2 replies; 4+ messages in thread
From: tbsaunde+gcc @ 2015-03-27 10:24 UTC (permalink / raw)
To: gcc-patches; +Cc: Trevor Saunders
From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
Hi,
Unfortunately when testing r217869 I didn't realize the modified code in
alpha.c was only used for some alpha targets. So testing alpha-linux wasn't
enough or even really useful :(
I tested cc1 for alpha-dec-vms now builds as discussed before make all-gcc is
still broken because the vms targets don't support c++ and don't say it
shouldn't be built in config.gcc. Is this ok?
Trev
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 37258ad..fac42d6 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2015-03-27 Trevor Saunders <tbsaunde@tbsaunde.org>
+
+ * config/alpha/alpha.c (alpha_use_linkage): Change type of slot to
+ alpha_links **.
+ (alpha_write_one_linkage): Correct typo.
+
2015-03-27 Marek Polacek <polacek@redhat.com>
PR sanitizer/65583
diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c
index 554ff09..67c15dc 100644
--- a/gcc/config/alpha/alpha.c
+++ b/gcc/config/alpha/alpha.c
@@ -9665,7 +9665,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag)
if (cfun->machine->links)
{
/* Is this name already defined? */
- alpha_links *slot = cfun->machine->links->get (name);
+ alpha_links **slot = cfun->machine->links->get (name);
if (slot)
al = *slot;
}
@@ -9711,7 +9711,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag)
}
static int
-alpha_write_one_linkage (const char *name, alpha_links *link, FILE *steam)
+alpha_write_one_linkage (const char *name, alpha_links *link, FILE *stream)
{
ASM_OUTPUT_INTERNAL_LABEL (stream, XSTR (link->linkage, 0));
if (link->rkind == KIND_CODEADDR)
--
2.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix building for alpha-dec-vms
2015-03-27 10:24 [PATCH] fix building for alpha-dec-vms tbsaunde+gcc
@ 2015-04-08 13:57 ` Bernhard Reutner-Fischer
2015-04-08 14:06 ` Jakub Jelinek
2015-04-08 14:03 ` Richard Biener
1 sibling, 1 reply; 4+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-08 13:57 UTC (permalink / raw)
To: tbsaunde+gcc; +Cc: GCC Patches, Richard Henderson, tgingold, douglas.b.rupp
[CC ing maintainers]
Ping.
On 27 March 2015 at 11:24, <tbsaunde+gcc@tbsaunde.org> wrote:
> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>
> Hi,
>
> Unfortunately when testing r217869 I didn't realize the modified code in
> alpha.c was only used for some alpha targets. So testing alpha-linux wasn't
> enough or even really useful :(
>
> I tested cc1 for alpha-dec-vms now builds as discussed before make all-gcc is
> still broken because the vms targets don't support c++ and don't say it
> shouldn't be built in config.gcc. Is this ok?
>
> Trev
>
>
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog
> index 37258ad..fac42d6 100644
> --- a/gcc/ChangeLog
> +++ b/gcc/ChangeLog
> @@ -1,3 +1,9 @@
> +2015-03-27 Trevor Saunders <tbsaunde@tbsaunde.org>
> +
> + * config/alpha/alpha.c (alpha_use_linkage): Change type of slot to
> + alpha_links **.
> + (alpha_write_one_linkage): Correct typo.
> +
> 2015-03-27 Marek Polacek <polacek@redhat.com>
>
> PR sanitizer/65583
> diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c
> index 554ff09..67c15dc 100644
> --- a/gcc/config/alpha/alpha.c
> +++ b/gcc/config/alpha/alpha.c
> @@ -9665,7 +9665,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag)
> if (cfun->machine->links)
> {
> /* Is this name already defined? */
> - alpha_links *slot = cfun->machine->links->get (name);
> + alpha_links **slot = cfun->machine->links->get (name);
> if (slot)
> al = *slot;
> }
> @@ -9711,7 +9711,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag)
> }
>
> static int
> -alpha_write_one_linkage (const char *name, alpha_links *link, FILE *steam)
> +alpha_write_one_linkage (const char *name, alpha_links *link, FILE *stream)
> {
> ASM_OUTPUT_INTERNAL_LABEL (stream, XSTR (link->linkage, 0));
> if (link->rkind == KIND_CODEADDR)
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix building for alpha-dec-vms
2015-04-08 13:57 ` Bernhard Reutner-Fischer
@ 2015-04-08 14:06 ` Jakub Jelinek
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Jelinek @ 2015-04-08 14:06 UTC (permalink / raw)
To: Bernhard Reutner-Fischer
Cc: tbsaunde+gcc, GCC Patches, Richard Henderson, tgingold, douglas.b.rupp
On Wed, Apr 08, 2015 at 03:57:09PM +0200, Bernhard Reutner-Fischer wrote:
> [CC ing maintainers]
>
> Ping.
This is ok.
> > --- a/gcc/ChangeLog
> > +++ b/gcc/ChangeLog
> > @@ -1,3 +1,9 @@
> > +2015-03-27 Trevor Saunders <tbsaunde@tbsaunde.org>
> > +
> > + * config/alpha/alpha.c (alpha_use_linkage): Change type of slot to
> > + alpha_links **.
> > + (alpha_write_one_linkage): Correct typo.
> > +
> > 2015-03-27 Marek Polacek <polacek@redhat.com>
> >
> > PR sanitizer/65583
> > diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c
> > index 554ff09..67c15dc 100644
> > --- a/gcc/config/alpha/alpha.c
> > +++ b/gcc/config/alpha/alpha.c
> > @@ -9665,7 +9665,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag)
> > if (cfun->machine->links)
> > {
> > /* Is this name already defined? */
> > - alpha_links *slot = cfun->machine->links->get (name);
> > + alpha_links **slot = cfun->machine->links->get (name);
> > if (slot)
> > al = *slot;
> > }
> > @@ -9711,7 +9711,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag)
> > }
> >
> > static int
> > -alpha_write_one_linkage (const char *name, alpha_links *link, FILE *steam)
> > +alpha_write_one_linkage (const char *name, alpha_links *link, FILE *stream)
> > {
> > ASM_OUTPUT_INTERNAL_LABEL (stream, XSTR (link->linkage, 0));
> > if (link->rkind == KIND_CODEADDR)
> > --
> > 2.1.4
> >
Jakub
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix building for alpha-dec-vms
2015-03-27 10:24 [PATCH] fix building for alpha-dec-vms tbsaunde+gcc
2015-04-08 13:57 ` Bernhard Reutner-Fischer
@ 2015-04-08 14:03 ` Richard Biener
1 sibling, 0 replies; 4+ messages in thread
From: Richard Biener @ 2015-04-08 14:03 UTC (permalink / raw)
To: tbsaunde+gcc; +Cc: GCC Patches
On Fri, Mar 27, 2015 at 11:24 AM, <tbsaunde+gcc@tbsaunde.org> wrote:
> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>
> Hi,
>
> Unfortunately when testing r217869 I didn't realize the modified code in
> alpha.c was only used for some alpha targets. So testing alpha-linux wasn't
> enough or even really useful :(
>
> I tested cc1 for alpha-dec-vms now builds as discussed before make all-gcc is
> still broken because the vms targets don't support c++ and don't say it
> shouldn't be built in config.gcc. Is this ok?
Ok.
Thanks,
Richard.
> Trev
>
>
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog
> index 37258ad..fac42d6 100644
> --- a/gcc/ChangeLog
> +++ b/gcc/ChangeLog
> @@ -1,3 +1,9 @@
> +2015-03-27 Trevor Saunders <tbsaunde@tbsaunde.org>
> +
> + * config/alpha/alpha.c (alpha_use_linkage): Change type of slot to
> + alpha_links **.
> + (alpha_write_one_linkage): Correct typo.
> +
> 2015-03-27 Marek Polacek <polacek@redhat.com>
>
> PR sanitizer/65583
> diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c
> index 554ff09..67c15dc 100644
> --- a/gcc/config/alpha/alpha.c
> +++ b/gcc/config/alpha/alpha.c
> @@ -9665,7 +9665,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag)
> if (cfun->machine->links)
> {
> /* Is this name already defined? */
> - alpha_links *slot = cfun->machine->links->get (name);
> + alpha_links **slot = cfun->machine->links->get (name);
> if (slot)
> al = *slot;
> }
> @@ -9711,7 +9711,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag)
> }
>
> static int
> -alpha_write_one_linkage (const char *name, alpha_links *link, FILE *steam)
> +alpha_write_one_linkage (const char *name, alpha_links *link, FILE *stream)
> {
> ASM_OUTPUT_INTERNAL_LABEL (stream, XSTR (link->linkage, 0));
> if (link->rkind == KIND_CODEADDR)
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-08 14:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-27 10:24 [PATCH] fix building for alpha-dec-vms tbsaunde+gcc
2015-04-08 13:57 ` Bernhard Reutner-Fischer
2015-04-08 14:06 ` Jakub Jelinek
2015-04-08 14:03 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).