* [PATCH 1/2] tree.h: Commentary typo fix
2015-04-08 18:32 [PATCH 0/2] Commentary typo fixes Bernhard Reutner-Fischer
2015-04-08 18:32 ` [PATCH 2/2] tree-tailcall: Commentary typo fix, remove fwd declaration Bernhard Reutner-Fischer
@ 2015-04-08 18:32 ` Bernhard Reutner-Fischer
2015-04-08 18:34 ` Gerald Pfeifer
1 sibling, 1 reply; 6+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-08 18:32 UTC (permalink / raw)
To: gcc-patches; +Cc: Bernhard Reutner-Fischer
gcc/ChangeLog:
2015-04-01 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
* tree.h (CONVERT_EXPR_P): Commentary typo fix.
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
---
gcc/tree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/tree.h b/gcc/tree.h
index 4fcc272..bedf103 100644
--- a/gcc/tree.h
+++ b/gcc/tree.h
@@ -428,7 +428,7 @@ extern void omp_clause_range_check_failed (const_tree, const char *, int,
#define CONVERT_EXPR_CODE_P(CODE) \
((CODE) == NOP_EXPR || (CODE) == CONVERT_EXPR)
-/* Similarly, but accept an expressions instead of a tree code. */
+/* Similarly, but accept an expression instead of a tree code. */
#define CONVERT_EXPR_P(EXP) CONVERT_EXPR_CODE_P (TREE_CODE (EXP))
/* Generate case for NOP_EXPR, CONVERT_EXPR. */
--
2.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] tree-tailcall: Commentary typo fix, remove fwd declaration
2015-04-08 18:32 [PATCH 0/2] Commentary typo fixes Bernhard Reutner-Fischer
@ 2015-04-08 18:32 ` Bernhard Reutner-Fischer
2015-04-22 8:21 ` Bernhard Reutner-Fischer
2015-04-08 18:32 ` [PATCH 1/2] tree.h: Commentary typo fix Bernhard Reutner-Fischer
1 sibling, 1 reply; 6+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-08 18:32 UTC (permalink / raw)
To: gcc-patches; +Cc: Bernhard Reutner-Fischer
gcc/ChangeLog:
2015-04-01 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
* tree-tailcall.c (suitable_for_tail_opt_p, find_tail_calls):
Remove unneeded forward declarations.
(suitable_for_tail_call_opt_p): Commentary typo fix.
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
---
gcc/tree-tailcall.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/gcc/tree-tailcall.c b/gcc/tree-tailcall.c
index 1d065fb..013972d 100644
--- a/gcc/tree-tailcall.c
+++ b/gcc/tree-tailcall.c
@@ -165,10 +165,8 @@ struct tailcall
accumulator. */
static tree m_acc, a_acc;
-static bool suitable_for_tail_opt_p (void);
static bool optimize_tail_call (struct tailcall *, bool);
static void eliminate_tail_call (struct tailcall *);
-static void find_tail_calls (basic_block, struct tailcall **);
/* Returns false when the function is not suitable for tail call optimization
from some reason (e.g. if it takes variable number of arguments). */
@@ -182,7 +180,7 @@ suitable_for_tail_opt_p (void)
return true;
}
/* Returns false when the function is not suitable for tail call optimization
- from some reason (e.g. if it takes variable number of arguments).
+ for some reason (e.g. if it takes variable number of arguments).
This test must pass in addition to suitable_for_tail_opt_p in order to make
tail call discovery happen. */
--
2.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] Commentary typo fixes
@ 2015-04-08 18:32 Bernhard Reutner-Fischer
2015-04-08 18:32 ` [PATCH 2/2] tree-tailcall: Commentary typo fix, remove fwd declaration Bernhard Reutner-Fischer
2015-04-08 18:32 ` [PATCH 1/2] tree.h: Commentary typo fix Bernhard Reutner-Fischer
0 siblings, 2 replies; 6+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-08 18:32 UTC (permalink / raw)
To: gcc-patches; +Cc: Bernhard Reutner-Fischer
Two typos and remove two unneeded forward declarations for static
functions in tree-tailcall.c.
These patches were applied when doing a config-list.mk build and showed
no negative effect. I'd usually consider them obvious but given current
stage..
Ok for trunk now?
Bernhard Reutner-Fischer (2):
tree.h: Commentary typo fix
tree-tailcall: Commentary typo fix, remove fwd declaration
gcc/tree-tailcall.c | 4 +---
gcc/tree.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
--
2.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] tree.h: Commentary typo fix
2015-04-08 18:32 ` [PATCH 1/2] tree.h: Commentary typo fix Bernhard Reutner-Fischer
@ 2015-04-08 18:34 ` Gerald Pfeifer
2015-04-08 18:43 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 6+ messages in thread
From: Gerald Pfeifer @ 2015-04-08 18:34 UTC (permalink / raw)
To: Bernhard Reutner-Fischer; +Cc: gcc-patches
On Wed, 8 Apr 2015, Bernhard Reutner-Fischer wrote:
> 2015-04-01 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>
> * tree.h (CONVERT_EXPR_P): Commentary typo fix.
Go ahead. Pure comment fixes still should be fine at this point
in time.
Gerald
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] tree.h: Commentary typo fix
2015-04-08 18:34 ` Gerald Pfeifer
@ 2015-04-08 18:43 ` Bernhard Reutner-Fischer
0 siblings, 0 replies; 6+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-08 18:43 UTC (permalink / raw)
To: Gerald Pfeifer; +Cc: GCC Patches
On 8 April 2015 at 20:34, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> On Wed, 8 Apr 2015, Bernhard Reutner-Fischer wrote:
>> 2015-04-01 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>>
>> * tree.h (CONVERT_EXPR_P): Commentary typo fix.
>
> Go ahead. Pure comment fixes still should be fine at this point
> in time.
Ok, thanks. r221930.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] tree-tailcall: Commentary typo fix, remove fwd declaration
2015-04-08 18:32 ` [PATCH 2/2] tree-tailcall: Commentary typo fix, remove fwd declaration Bernhard Reutner-Fischer
@ 2015-04-22 8:21 ` Bernhard Reutner-Fischer
0 siblings, 0 replies; 6+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-22 8:21 UTC (permalink / raw)
To: GCC Patches; +Cc: Bernhard Reutner-Fischer
On 8 April 2015 at 20:32, Bernhard Reutner-Fischer
<rep.dot.nop@gmail.com> wrote:
> gcc/ChangeLog:
OKed by Jeff and committed to trunk as r222312.
thanks,
>
> 2015-04-01 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>
> * tree-tailcall.c (suitable_for_tail_opt_p, find_tail_calls):
> Remove unneeded forward declarations.
> (suitable_for_tail_call_opt_p): Commentary typo fix.
>
> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
> ---
> gcc/tree-tailcall.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/gcc/tree-tailcall.c b/gcc/tree-tailcall.c
> index 1d065fb..013972d 100644
> --- a/gcc/tree-tailcall.c
> +++ b/gcc/tree-tailcall.c
> @@ -165,10 +165,8 @@ struct tailcall
> accumulator. */
> static tree m_acc, a_acc;
>
> -static bool suitable_for_tail_opt_p (void);
> static bool optimize_tail_call (struct tailcall *, bool);
> static void eliminate_tail_call (struct tailcall *);
> -static void find_tail_calls (basic_block, struct tailcall **);
>
> /* Returns false when the function is not suitable for tail call optimization
> from some reason (e.g. if it takes variable number of arguments). */
> @@ -182,7 +180,7 @@ suitable_for_tail_opt_p (void)
> return true;
> }
> /* Returns false when the function is not suitable for tail call optimization
> - from some reason (e.g. if it takes variable number of arguments).
> + for some reason (e.g. if it takes variable number of arguments).
> This test must pass in addition to suitable_for_tail_opt_p in order to make
> tail call discovery happen. */
>
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-22 8:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-08 18:32 [PATCH 0/2] Commentary typo fixes Bernhard Reutner-Fischer
2015-04-08 18:32 ` [PATCH 2/2] tree-tailcall: Commentary typo fix, remove fwd declaration Bernhard Reutner-Fischer
2015-04-22 8:21 ` Bernhard Reutner-Fischer
2015-04-08 18:32 ` [PATCH 1/2] tree.h: Commentary typo fix Bernhard Reutner-Fischer
2015-04-08 18:34 ` Gerald Pfeifer
2015-04-08 18:43 ` Bernhard Reutner-Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).