public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Trevor Saunders <tbsaunde@tbsaunde.org>
Cc: Jeff Law <law@redhat.com>,
	tbsaunde+gcc@tbsaunde.org,        gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 00/12] Reduce conditional compilation
Date: Wed, 22 Apr 2015 18:19:00 -0000	[thread overview]
Message-ID: <1429726381.32584.146.camel@surprise> (raw)
In-Reply-To: <20150421152914.GE9945@tsaunders-iceball.corp.tor1.mozilla.com>

On Tue, 2015-04-21 at 11:29 -0400, Trevor Saunders wrote:
> On Tue, Apr 21, 2015 at 07:57:19AM -0600, Jeff Law wrote:
> > On 04/21/2015 07:24 AM, tbsaunde+gcc@tbsaunde.org wrote:
> > >From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> > >
> > >Hi,
> > >
> > >This is a first round of patches to reduce the amount of code with in #if /
> > >#ifdef.  This makes it incrementally easier to not break configs other than the
> > >one being built, and moves things slightly closer to using target hooks for
> > >everything.
> > >
> > >each commit bootstrapped and regtested on x86_64-linux-gnu without regression,
> > >and whole patch set run through config-list.mk without issue, ok?
> > So I think after looking at this patchset, any changes of a similar nature
> > you want to make should be considered pre-approved.  Just post them for
> > archival purposes, but no need for you to wait for review as long as they
> > have the same purpose and overall structure as was seen in these patches.
> 
> thanks!  Its also always nice to have someone double check your logic
> :-)

Thanks for working on this!

Conditional compilation was a major PITA when doing the rtx->rtx_insn *
work last year, so I'm very pleased to see these cleanups go in.

Dave

  reply	other threads:[~2015-04-22 18:19 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 13:25 tbsaunde+gcc
2015-04-21 13:25 ` [PATCH 11/12] provide default for INSN_SETS_ARE_DELAYED tbsaunde+gcc
2015-04-21 13:31   ` Jeff Law
2015-04-21 13:25 ` [PATCH 04/12] always define HAVE_cc0 tbsaunde+gcc
2015-04-21 13:53   ` Jeff Law
2015-04-21 15:18     ` Trevor Saunders
2015-04-21 13:25 ` [PATCH 03/12] more removal of ifdef HAVE_cc0 tbsaunde+gcc
2015-04-21 13:51   ` Jeff Law
2015-04-21 15:24     ` Trevor Saunders
2015-04-21 13:25 ` [PATCH 01/12] add default definition of EH_RETURN_DATA_REGNO tbsaunde+gcc
2015-04-21 13:40   ` Jeff Law
2015-04-21 14:00     ` Jakub Jelinek
2015-04-21 14:04       ` Jeff Law
2015-04-21 13:25 ` [PATCH 06/12] provide default for RETURN_ADDR_OFFSET tbsaunde+gcc
2015-04-21 13:32   ` Jeff Law
2015-04-21 13:25 ` [PATCH 12/12] add default for INSN_REFERENCES_ARE_DELAYED tbsaunde+gcc
2015-04-21 13:30   ` Jeff Law
2015-04-21 13:25 ` [PATCH 07/12] provide default for MASK_RETURN_ADDR tbsaunde+gcc
2015-04-21 13:32   ` Jeff Law
2015-04-21 13:25 ` [PATCH 09/12] remove #if for PIC_OFFSET_TABLE_REGNUM tbsaunde+gcc
2015-04-21 13:34   ` Jeff Law
2015-04-21 13:25 ` [PATCH 02/12] remove some ifdef HAVE_cc0 tbsaunde+gcc
2015-04-21 13:48   ` Jeff Law
2015-04-21 14:14   ` Richard Biener
2015-04-21 15:24     ` Trevor Saunders
2015-04-23  3:28       ` James Greenhalgh
2015-04-23  4:55         ` Trevor Saunders
2015-04-23  8:35           ` Richard Biener
2015-04-23  8:41             ` Kyrill Tkachov
2015-04-23  9:08               ` Richard Earnshaw
2015-04-23  9:58                 ` Kyrill Tkachov
2015-04-23 10:30                   ` Richard Biener
2015-04-23 12:01                   ` Trevor Saunders
2015-04-21 13:25 ` [PATCH 08/12] reduce conditional compilation for HARD_FRAME_POINTER_IS_FRAME_POINTER tbsaunde+gcc
2015-04-21 13:37   ` Jeff Law
2015-04-21 13:25 ` [PATCH 10/12] remove more ifdefs for HAVE_cc0 tbsaunde+gcc
2015-04-21 13:55   ` Jeff Law
2015-04-21 13:25 ` [PATCH 05/12] make some HAVE_cc0 code always compiled tbsaunde+gcc
2015-04-21 13:54   ` Jeff Law
2015-04-21 13:43 ` [PATCH 00/12] Reduce conditional compilation Jeff Law
2015-04-21 13:57 ` Jeff Law
2015-04-21 15:29   ` Trevor Saunders
2015-04-22 18:19     ` David Malcolm [this message]
2015-04-22 18:37       ` Jeff Law
2015-04-22 20:46         ` Trevor Saunders
2015-04-22 20:47           ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429726381.32584.146.camel@surprise \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=tbsaunde+gcc@tbsaunde.org \
    --cc=tbsaunde@tbsaunde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).