From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6707 invoked by alias); 22 Apr 2015 18:19:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6694 invoked by uid 89); 22 Apr 2015 18:19:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 22 Apr 2015 18:19:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3MIJd6K023519 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Apr 2015 14:19:40 -0400 Received: from [10.3.224.165] (vpn-224-165.phx2.redhat.com [10.3.224.165]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3MIJcZb030634; Wed, 22 Apr 2015 14:19:38 -0400 Message-ID: <1429726381.32584.146.camel@surprise> Subject: Re: [PATCH 00/12] Reduce conditional compilation From: David Malcolm To: Trevor Saunders Cc: Jeff Law , tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Date: Wed, 22 Apr 2015 18:19:00 -0000 In-Reply-To: <20150421152914.GE9945@tsaunders-iceball.corp.tor1.mozilla.com> References: <1429622658-9034-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <5536573F.4090005@redhat.com> <20150421152914.GE9945@tsaunders-iceball.corp.tor1.mozilla.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01351.txt.bz2 On Tue, 2015-04-21 at 11:29 -0400, Trevor Saunders wrote: > On Tue, Apr 21, 2015 at 07:57:19AM -0600, Jeff Law wrote: > > On 04/21/2015 07:24 AM, tbsaunde+gcc@tbsaunde.org wrote: > > >From: Trevor Saunders > > > > > >Hi, > > > > > >This is a first round of patches to reduce the amount of code with in #if / > > >#ifdef. This makes it incrementally easier to not break configs other than the > > >one being built, and moves things slightly closer to using target hooks for > > >everything. > > > > > >each commit bootstrapped and regtested on x86_64-linux-gnu without regression, > > >and whole patch set run through config-list.mk without issue, ok? > > So I think after looking at this patchset, any changes of a similar nature > > you want to make should be considered pre-approved. Just post them for > > archival purposes, but no need for you to wait for review as long as they > > have the same purpose and overall structure as was seen in these patches. > > thanks! Its also always nice to have someone double check your logic > :-) Thanks for working on this! Conditional compilation was a major PITA when doing the rtx->rtx_insn * work last year, so I'm very pleased to see these cleanups go in. Dave