From: Peter Bergner <bergner@vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Michael Meissner <meissner@linux.vnet.ibm.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state
Date: Thu, 23 Apr 2015 03:17:00 -0000 [thread overview]
Message-ID: <1429759058.21947.62.camel@otta> (raw)
In-Reply-To: <20150423015534.GB29172@gate.crashing.org>
On Wed, 2015-04-22 at 20:55 -0500, Segher Boessenkool wrote:
> Using a hard reg in the RTL like this has a few problems:
> a) It might hinder register allocation. Maybe it doesn't, not sure;
> b) It does hinder scheduling;
> c) It can make things ICE, maybe with register asm.
Ahh, I see what you mean now. Yeah, I hadn't thought of that.
> The alternative is to write a separate define_insn for ttest, one
> without inputs; the generated assembler can still be the same of
> course.
In that case, I think you're right that this is the best course
if action. I'll do that ans retest. Thanks for catching this.
Peter
next prev parent reply other threads:[~2015-04-23 3:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 19:27 Peter Bergner
2015-03-20 20:52 ` Segher Boessenkool
2015-03-20 22:42 ` Peter Bergner
2015-04-21 20:56 ` Peter Bergner
2015-04-22 2:18 ` Segher Boessenkool
2015-04-22 13:43 ` Peter Bergner
2015-04-22 22:16 ` Segher Boessenkool
2015-04-22 23:08 ` Peter Bergner
2015-04-23 1:55 ` Segher Boessenkool
2015-04-23 3:17 ` Peter Bergner [this message]
2015-04-23 19:16 ` Peter Bergner
2015-04-24 15:34 ` Segher Boessenkool
2015-04-24 15:40 ` David Edelsohn
2015-04-27 15:21 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429759058.21947.62.camel@otta \
--to=bergner@vnet.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).