From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83174 invoked by alias); 9 Jun 2015 13:07:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83160 invoked by uid 89); 9 Jun 2015 13:07:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Jun 2015 13:07:48 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-20.uk.mimecast.lan; Tue, 09 Jun 2015 14:07:45 +0100 Received: from e106375-lin.cambridge.arm.com ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 9 Jun 2015 14:07:45 +0100 From: James Greenhalgh To: gcc-patches@gcc.gnu.org Subject: [Patch testsuite obvious] g++.dg/ext/pr57735.C should not run if the testsuite is explicitly passing -mfloat-abi=hard Date: Tue, 09 Jun 2015 13:11:00 -0000 Message-Id: <1433855261-6508-1-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 X-MC-Unique: jS9MA9M4R06Vepa0qNocAQ-1 Content-Type: multipart/mixed; boundary="------------2.2.0" X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00665.txt.bz2 This is a multi-part message in MIME format. --------------2.2.0 Content-Type: text/plain; charset=UTF-8; format=fixed Content-Transfer-Encoding: quoted-printable Content-length: 634 Hi, g++.dg/ext/pr57735.C is failing for test runs which explicitly pass -mfloat-abi=3Dhard. Looking at the test, it seems the best fix would be to check before adding -mfloat-abi=3Dsoft that we are not testing some other float-abi. We also fail to check that it is OK to add -march=3Darmv5te and -marm. Fixed using the same mechanisms we use elsewhere in the gcc.target/arm/ tests with the attached, applied as obvious as revision 224280. Thanks, James --- gcc/testsuite/ 2015-06-09 James Greenhalgh * g++.dg/ext/pr57735.C: Do not override -mfloat-abi directives passed by the testsuite driver. --------------2.2.0 Content-Type: text/x-patch; name=0001-Patch-testsuite-obvious-g-.dg-ext-pr57735.C-should-n.patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Patch-testsuite-obvious-g-.dg-ext-pr57735.C-should-n.patch" Content-length: 599 diff --git a/gcc/testsuite/g++.dg/ext/pr57735.C b/gcc/testsuite/g++.dg/ext/= pr57735.C index 0eb9500..a8f7d05 100644 --- a/gcc/testsuite/g++.dg/ext/pr57735.C +++ b/gcc/testsuite/g++.dg/ext/pr57735.C @@ -1,4 +1,7 @@ /* { dg-do compile { target arm*-*-* } } */ +/* { dg-require-effective-target arm_arch_v5te_ok } */ +/* { dg-require-effective-target arm_arm_ok } */ +/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=3D*= " } {"-mfloat-abi=3Dsoft" } } */ /* { dg-options "-march=3Darmv5te -marm -mtune=3Dxscale -mfloat-abi=3Dsof= t -O1" } */ =20 typedef unsigned int size_t; --------------2.2.0--