* [4.8, testsuite] Correct backported fix to gcc.dg/vect/vect-33.c
@ 2015-06-15 19:55 Bill Schmidt
2015-06-15 20:30 ` Bill Schmidt
0 siblings, 1 reply; 3+ messages in thread
From: Bill Schmidt @ 2015-06-15 19:55 UTC (permalink / raw)
To: gcc-patches; +Cc: mikestump
Hi,
When I backported support for unaligned vector load/store operations on
POWER8 to GCC 4.8, I fumbled the change for gcc.dg/vect/vect-33.c. One
of the original tests was:
/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" } } */
which I modified to
/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" { target { ! vect_hw_misalign } } } } */
This caused the test to be skipped for architectures other than PowerPC,
which was a mistake. The correct test should have been:
/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" { target { { ! powerpc*-*-* } || { ! vect_hw_misalign } } } } } */
which leaves things alone for other architectures.
Ok for 4.8?
Thanks,
Bill
2015-06-15 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
* gcc.dg/vect/vect-33.c: Don't exclude "Vectorizing an unaligned
access" test for non-PowerPC arches.
Index: gcc/testsuite/gcc.dg/vect/vect-33.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/vect-33.c (revision 224490)
+++ gcc/testsuite/gcc.dg/vect/vect-33.c (working copy)
@@ -38,7 +38,7 @@ int main (void)
/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */
-/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" { target { ! vect_hw_misalign } } } } */
+/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" { target { { ! powerpc*-*-* } || { ! vect_hw_misalign } } } } } */
/* { dg-final { scan-tree-dump "Alignment of access forced using peeling" "vect" { target vector_alignment_reachable } } } */
/* { dg-final { scan-tree-dump-times "Alignment of access forced using versioning" 1 "vect" { target { {! vector_alignment_reachable} && {! vect_hw_misalign} } } } } */
/* { dg-final { cleanup-tree-dump "vect" } } */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [4.8, testsuite] Correct backported fix to gcc.dg/vect/vect-33.c
2015-06-15 19:55 [4.8, testsuite] Correct backported fix to gcc.dg/vect/vect-33.c Bill Schmidt
@ 2015-06-15 20:30 ` Bill Schmidt
2015-06-16 6:09 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Bill Schmidt @ 2015-06-15 20:30 UTC (permalink / raw)
To: gcc-patches; +Cc: mikestump, rguenther
I just was reading the gcc mailing list and realized that changes to 4.8
now require release manager approval. Adding Richard to the CC list for
consideration. Thanks!
Bill
On Mon, 2015-06-15 at 14:54 -0500, Bill Schmidt wrote:
> Hi,
>
> When I backported support for unaligned vector load/store operations on
> POWER8 to GCC 4.8, I fumbled the change for gcc.dg/vect/vect-33.c. One
> of the original tests was:
>
> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" } } */
>
> which I modified to
>
> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" { target { ! vect_hw_misalign } } } } */
>
> This caused the test to be skipped for architectures other than PowerPC,
> which was a mistake. The correct test should have been:
>
> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" { target { { ! powerpc*-*-* } || { ! vect_hw_misalign } } } } } */
>
> which leaves things alone for other architectures.
>
> Ok for 4.8?
>
> Thanks,
> Bill
>
>
> 2015-06-15 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>
> * gcc.dg/vect/vect-33.c: Don't exclude "Vectorizing an unaligned
> access" test for non-PowerPC arches.
>
>
> Index: gcc/testsuite/gcc.dg/vect/vect-33.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/vect/vect-33.c (revision 224490)
> +++ gcc/testsuite/gcc.dg/vect/vect-33.c (working copy)
> @@ -38,7 +38,7 @@ int main (void)
>
>
> /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */
> -/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" { target { ! vect_hw_misalign } } } } */
> +/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 0 "vect" { target { { ! powerpc*-*-* } || { ! vect_hw_misalign } } } } } */
> /* { dg-final { scan-tree-dump "Alignment of access forced using peeling" "vect" { target vector_alignment_reachable } } } */
> /* { dg-final { scan-tree-dump-times "Alignment of access forced using versioning" 1 "vect" { target { {! vector_alignment_reachable} && {! vect_hw_misalign} } } } } */
> /* { dg-final { cleanup-tree-dump "vect" } } */
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [4.8, testsuite] Correct backported fix to gcc.dg/vect/vect-33.c
2015-06-15 20:30 ` Bill Schmidt
@ 2015-06-16 6:09 ` Richard Biener
0 siblings, 0 replies; 3+ messages in thread
From: Richard Biener @ 2015-06-16 6:09 UTC (permalink / raw)
To: Bill Schmidt, gcc-patches; +Cc: mikestump
On June 15, 2015 9:58:33 PM GMT+02:00, Bill Schmidt <wschmidt@linux.vnet.ibm.com> wrote:
>I just was reading the gcc mailing list and realized that changes to
>4.8
>now require release manager approval. Adding Richard to the CC list
>for
>consideration. Thanks!
OK.
Richard.
>Bill
>
>On Mon, 2015-06-15 at 14:54 -0500, Bill Schmidt wrote:
>> Hi,
>>
>> When I backported support for unaligned vector load/store operations
>on
>> POWER8 to GCC 4.8, I fumbled the change for gcc.dg/vect/vect-33.c.
>One
>> of the original tests was:
>>
>> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" } } */
>>
>> which I modified to
>>
>> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" { target { ! vect_hw_misalign } } } } */
>>
>> This caused the test to be skipped for architectures other than
>PowerPC,
>> which was a mistake. The correct test should have been:
>>
>> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" { target { { ! powerpc*-*-* } || { ! vect_hw_misalign
>} } } } } */
>>
>> which leaves things alone for other architectures.
>>
>> Ok for 4.8?
>>
>> Thanks,
>> Bill
>>
>>
>> 2015-06-15 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>>
>> * gcc.dg/vect/vect-33.c: Don't exclude "Vectorizing an unaligned
>> access" test for non-PowerPC arches.
>>
>>
>> Index: gcc/testsuite/gcc.dg/vect/vect-33.c
>> ===================================================================
>> --- gcc/testsuite/gcc.dg/vect/vect-33.c (revision 224490)
>> +++ gcc/testsuite/gcc.dg/vect/vect-33.c (working copy)
>> @@ -38,7 +38,7 @@ int main (void)
>>
>>
>> /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect"
>} } */
>> -/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" { target { ! vect_hw_misalign } } } } */
>> +/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" { target { { ! powerpc*-*-* } || { ! vect_hw_misalign
>} } } } } */
>> /* { dg-final { scan-tree-dump "Alignment of access forced using
>peeling" "vect" { target vector_alignment_reachable } } } */
>> /* { dg-final { scan-tree-dump-times "Alignment of access forced
>using versioning" 1 "vect" { target { {! vector_alignment_reachable} &&
>{! vect_hw_misalign} } } } } */
>> /* { dg-final { cleanup-tree-dump "vect" } } */
>>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-16 5:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-15 19:55 [4.8, testsuite] Correct backported fix to gcc.dg/vect/vect-33.c Bill Schmidt
2015-06-15 20:30 ` Bill Schmidt
2015-06-16 6:09 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).