From: Steve Ellcey <sellcey@imgtec.com>
To: Matthew Fortune <Matthew.Fortune@imgtec.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"clm@codesourcery.com" <clm@codesourcery.com>
Subject: RE: [Patch, MIPS] Modify sysroot layout for mips-mti-* and mips-img-*
Date: Mon, 15 Jun 2015 22:11:00 -0000 [thread overview]
Message-ID: <1434406145.20199.204.camel@ubuntu-sellcey> (raw)
In-Reply-To: <6D39441BF12EF246A7ABCE6654B0235321166D3B@LEMAIL01.le.imgtec.org>
> Apart from wanting to understand the need/lack of ! in various places, this is
> otherwise OK.
>
> Matthew
Ok, I split the long lines and added the missing '!' characters to all
the MULTILIB_OSDIRNAMES except for the default ones. Using the '!' on
the default MULTILIB_OSDIRNAMES like:
MULTILIB_OSDIRNAMES = .=mips-r6-hard/lib
in t-img-linux causes the '--print-multi-os-directory' option to include
the '!' character in the output when using the default options and that
causes all sorts of problems when building.
Without a '!' on the default case:
% inst*/bin/*-gcc --print-multi-os-directory
mips-r6-hard/lib
With a '!' on the default case:
% inst*/bin/*-gcc --print-multi-os-directory
!mips-r6-hard/lib
This is probably a bug in the scripts that parse the t-* files and
setting up the various multi-lib lists but I didn't dig into exactly
where or what the problem was, I just left the '!' off the default case.
The non-default cases should all have a '!' and I have added it to the
ones that were missing it.
I will check this patch in after I have done one more round of testing
to make sure that my latest changes didn't break anything.
Steve Ellcey
sellcey@imgtec.com
next prev parent reply other threads:[~2015-06-15 22:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 15:46 Steve Ellcey
2015-06-15 18:58 ` Matthew Fortune
2015-06-15 22:11 ` Steve Ellcey [this message]
2015-06-16 16:40 ` Steve Ellcey
2015-06-16 16:44 ` Matthew Fortune
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434406145.20199.204.camel@ubuntu-sellcey \
--to=sellcey@imgtec.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=clm@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).