From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19007 invoked by alias); 25 Jun 2015 18:02:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18990 invoked by uid 89); 25 Jun 2015 18:02:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Jun 2015 18:02:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id A249C19F969 for ; Thu, 25 Jun 2015 18:02:42 +0000 (UTC) Received: from [10.3.231.150] (vpn-231-150.phx2.redhat.com [10.3.231.150]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5PI2fY1024171; Thu, 25 Jun 2015 14:02:42 -0400 Message-ID: <1435254904.13727.38.camel@surprise> Subject: Re: [PATCH 03/17] Add test-cfg.c to gcc/unittests From: David Malcolm To: Jeff Law Cc: gcc-patches@gcc.gnu.org Date: Thu, 25 Jun 2015 18:13:00 -0000 In-Reply-To: <5589B0DA.1090605@redhat.com> References: <1433949898-22033-1-git-send-email-dmalcolm@redhat.com> <1433949898-22033-4-git-send-email-dmalcolm@redhat.com> <5589B0DA.1090605@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01852.txt.bz2 On Tue, 2015-06-23 at 13:17 -0600, Jeff Law wrote: > On 06/10/2015 09:24 AM, David Malcolm wrote: > > gcc/unittests/ChangeLog: > > * test-cfg.c: New file. > > --- > > gcc/unittests/test-cfg.c | 319 +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 319 insertions(+) > > create mode 100644 gcc/unittests/test-cfg.c > So this one would be a great place to check that the dominator code does > something sensible if there's unreachable nodes in the CFG or the > post-dominator code does something sensible with infinite loops, etc. > > I don't necessarily expect you to do this, just pointing it out. > > Just a nit, I noticed this included rtl.h, which seems a bit odd. Are > those #includes relatively minimal or are they in need to cleanup? Yes, they need to be cleaned up (I #included stuff until it compiled). My plan is to minimize what these files #include once the more controversial aspects of this patchkit are resolved - given that the header files are in a state of flux, any minimization I attempt now is likely to be out-of-date.