public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aditya Kumar <hiraditya@msn.com>
To: hiraditya@msn.com,	gcc-patches@gcc.gnu.org,	spop@gmail.com
Subject: [PATCH] Discard Scops for which entry==exit
Date: Mon, 29 Jun 2015 20:25:00 -0000	[thread overview]
Message-ID: <1435608255-10186-1-git-send-email-hiraditya@msn.com> (raw)

In this patch we discard the scops where entry and exit are the same BB.
This is an effort to remove graphite-scop-detection.c:limit_scops.
Removing the limit_scops function introduces correctness regressions.
We are making relevant changes in incremental steps to fix those bugs,
and finally we intend to remove limit_scops.

2015-06-29  Aditya Kumar  <aditya.k7@samsung.com>
	    Sebastian Pop <s.pop@samsung.com>

        * graphite-scop-detection.c (build_scops_1): Discard scops for which entry==exit


---
 gcc/graphite-scop-detection.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gcc/graphite-scop-detection.c b/gcc/graphite-scop-detection.c
index e8ddecd..f57cc4a 100644
--- a/gcc/graphite-scop-detection.c
+++ b/gcc/graphite-scop-detection.c
@@ -810,7 +810,14 @@ build_scops_1 (basic_block current, loop_p outermost_loop,
     {
       open_scop.exit = sinfo.exit;
       gcc_assert (open_scop.exit);
-      scops->safe_push (open_scop);
+      if (open_scop.entry != open_scop.exit)
+	scops->safe_push (open_scop);
+      else
+	{
+	  sinfo.difficult = true;
+	  sinfo.exits = false;
+	  sinfo.exit = NULL;
+	}
     }
 
   result.exit = sinfo.exit;
-- 
2.1.0.243.g30d45f7

             reply	other threads:[~2015-06-29 20:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 20:25 Aditya Kumar [this message]
2015-06-30  0:13 ` Sebastian Pop
2015-06-30  6:11   ` Tobias Grosser
2015-06-30  7:56     ` Richard Biener
2015-06-30 15:49     ` Aditya K
2015-07-02  7:53       ` Tobias Grosser
2015-07-02 15:37         ` Aditya K
2015-07-02 15:42           ` Tobias Grosser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435608255-10186-1-git-send-email-hiraditya@msn.com \
    --to=hiraditya@msn.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=spop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).