public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alex Velenko <alex.velenko@arm.com>
To: gcc-patches@gcc.gnu.org
Cc: marcus.shawcroft@arm.com
Subject: [PATCH] [PATCH][ARM] Fix pr63210.c testcase.
Date: Thu, 23 Jul 2015 11:17:00 -0000	[thread overview]
Message-ID: <1437650104-4568-1-git-send-email-alex.velenko@arm.com> (raw)

Hi,

This patch prevents testcase pr63210.c from running with -march=armv4t.
Object size check should be skipped with explicit -march=armv4t, because
expected size is only correct using pop pc instruction which is unsafe for
armv4t. For arm_arch_v5t_ok cases, an explicit -march=armv5t flag is set.

Is patch ok for trunk and fsf-5?

gcc/testsuite

2015-07-23  Alex Velenko  <Alex.Velenko@arm.com>

	* gcc.target/arm/pr63210.c (dg-skip-if): Skip armv4t.
	(dg-additional-options): Add -march=armv5t if arm_arch_v5t_ok.
---
 gcc/testsuite/gcc.target/arm/pr63210.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gcc/testsuite/gcc.target/arm/pr63210.c b/gcc/testsuite/gcc.target/arm/pr63210.c
index c3ae928..9b63a67 100644
--- a/gcc/testsuite/gcc.target/arm/pr63210.c
+++ b/gcc/testsuite/gcc.target/arm/pr63210.c
@@ -1,6 +1,8 @@
 /* { dg-do assemble } */
 /* { dg-options "-mthumb -Os " }  */
 /* { dg-require-effective-target arm_thumb1_ok } */
+/* { dg-skip-if "do not test on armv4t" { *-*-* } { "-march=armv4t" } } */
+/* { dg-additional-options "-march=armv5t" {target arm_arch_v5t_ok} } */
 
 int foo1 (int c);
 int foo2 (int c);
-- 
1.8.1.2

             reply	other threads:[~2015-07-23 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 11:17 Alex Velenko [this message]
2015-09-09 16:25 ` Ramana Radhakrishnan
2015-09-11  9:51   ` Alex Velenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437650104-4568-1-git-send-email-alex.velenko@arm.com \
    --to=alex.velenko@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=marcus.shawcroft@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).