public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mrs@mrs.kithrup.com>
To: Moritz Klammler <moritz@klammler.eu>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	Joseph Myers <joseph@codesourcery.com>
Subject: Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)
Date: Wed, 14 Sep 2016 21:49:00 -0000	[thread overview]
Message-ID: <1439BD15-89C7-4E62-B7D1-A6CC261B6C9F@mrs.kithrup.com> (raw)
In-Reply-To: <87h99iw7x3.fsf@klammler.eu>

On Sep 14, 2016, at 1:19 PM, Moritz Klammler <moritz@klammler.eu> wrote:
> 
> Joseph Myers <joseph@codesourcery.com> writes:
> 
>> On Wed, 14 Sep 2016, Moritz Klammler wrote:
>> 
>>> Ok, I didn't know about the workflow.  Do you think I should dike the
>>> `--strip-sums` option out again then?
>> 
>> I don't see any use for such an option.  Anyone changing the versions 
>> should always have a copy of the new tarball (obtained securely if 
>> possible) and should determine the sums from that.
> 
> Alright, below then without the option again.
> 
> Btw, how frequently am I supposed to post revisions of my patch to this
> list?

Feel free to address all reasonable concerns raised, and then post.

> Is it considered okay to do it immediately

Yes, as long as you address all the concerns you plan to address.  Before that point and it is usually premature.

> And should I also attach a "diff of the diffs" or will those interested be happy to
> produce it themselves?

No diffs of diffs please.  You should just regenerate the entire patch and include it in a email as you discuss each point raised and the outcome of those points.

  reply	other threads:[~2016-09-14 21:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 21:36 Moritz Klammler
2016-09-14 21:49 ` Mike Stump [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-10-25  0:16 Moritz Klammler
2016-10-25 15:18 ` Jeff Law
2016-10-07 13:10 Moritz Klammler
2016-10-24  8:44 ` Richard Biener
2016-10-24 16:06   ` Jeff Law
2016-09-14 17:38 Moritz Klammler
2016-09-14 18:12 ` Joseph Myers
2016-09-14 17:04 Moritz Klammler
2016-09-14 17:35 ` Joseph Myers
2016-09-13  8:37 Moritz Klammler
2016-09-13 16:07 ` Joseph Myers
2016-09-14  8:24   ` Richard Biener
2016-09-11 17:19 Moritz Klammler
2016-09-11 19:05 ` Mike Stump
2016-09-12 22:08 ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439BD15-89C7-4E62-B7D1-A6CC261B6C9F@mrs.kithrup.com \
    --to=mrs@mrs.kithrup.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=moritz@klammler.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).