From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123228 invoked by alias); 4 Jan 2018 17:32:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 123217 invoked by uid 89); 4 Jan 2018 17:32:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jan 2018 17:32:10 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4BE2FE89B; Thu, 4 Jan 2018 17:32:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-21.rdu2.redhat.com [10.10.112.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 864AF601B3; Thu, 4 Jan 2018 17:32:08 +0000 (UTC) Subject: Re: [PATCH] Fix gcc.dg/vect-opt-info-1.c testcase To: Jakub Jelinek , Richard Sandiford Cc: gcc-patches@gcc.gnu.org References: <871sltvm7r.fsf@linaro.org> <87bmkxkc7f.fsf@linaro.org> <20180103212326.GO1833@tucnak> From: Jeff Law Message-ID: <143afe92-0a65-e550-8db7-6a857390075f@redhat.com> Date: Thu, 04 Jan 2018 17:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180103212326.GO1833@tucnak> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00225.txt.bz2 On 01/03/2018 02:23 PM, Jakub Jelinek wrote: > On Mon, Oct 23, 2017 at 06:26:12PM +0100, Richard Sandiford wrote: >> 2017-10-23 Richard Sandiford >> Alan Hayward >> David Sherwood > ... > >> --- /dev/null 2017-10-21 08:51:42.385141415 +0100 >> +++ gcc/testsuite/gcc.dg/vect-opt-info-1.c 2017-10-23 17:22:26.571498977 +0100 >> @@ -0,0 +1,11 @@ >> +/* { dg-options "-std=c99 -fopt-info -O3" } */ >> + >> +void >> +vadd (int *dst, int *op1, int *op2, int count) >> +{ >> + for (int i = 0; i < count; ++i) >> + dst[i] = op1[i] + op2[i]; >> +} >> + >> +/* { dg-message "loop vectorized" "" { target *-*-* } 6 } */ >> +/* { dg-message "loop versioned for vectorization because of possible aliasing" "" { target *-*-* } 6 } */ > > This testcase fails e.g. on i686-linux. The problem is > 1) it really should be at least guarded with > /* { dg-do compile { target vect_int } } */ > because on targets that can't vectorize even simple int operations > this will obviously fail > 2) that won't help for i686 though, because we need -msse2 added > to options for it to work; that is normally added by > check_vect_support_and_set_flags > only when in vect.exp. If it was just that target, we could add > dg-additional-options, but I'm afraid many other targets add some options. > > The following works for me, calling it nodump-* ensures that > -fdump-tree-* isn't added, which I believe is essential for the testcase; > tested on x86_64-linux with > RUNTESTFLAGS='--target_board=unix\{-m32,-m32/-mno-sse,-m64\} vect.exp=nodump*' > ok for trunk? > > Sadly I don't have your broken development version of the patch, so can't > verify it fails with the broken patch. > > 2018-01-03 Jakub Jelinek > > * gcc.dg/vect-opt-info-1.c: Moved to ... > * gcc.dg/vect/nodump-vect-opt-info-1.c: ... here. Only run on > vect_int targets, use dg-additional-options instead of dg-options and > use relative line numbers instead of absolute. OK. jeff