From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32800 invoked by alias); 16 Sep 2015 15:29:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32782 invoked by uid 89); 16 Sep 2015 15:29:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e32.co.us.ibm.com Received: from e32.co.us.ibm.com (HELO e32.co.us.ibm.com) (32.97.110.150) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 16 Sep 2015 15:29:17 +0000 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 Sep 2015 09:29:15 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 16 Sep 2015 09:29:13 -0600 X-MailFrom: wschmidt@linux.vnet.ibm.com X-RcptTo: gcc-patches@gcc.gnu.org Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id D3E403E4003F for ; Wed, 16 Sep 2015 09:29:12 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t8GFS5SA52297840 for ; Wed, 16 Sep 2015 08:28:05 -0700 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t8GFTCO5004394 for ; Wed, 16 Sep 2015 09:29:12 -0600 Received: from [9.80.47.176] ([9.80.47.176]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t8GFTBEG004299; Wed, 16 Sep 2015 09:29:11 -0600 Message-ID: <1442417348.2896.47.camel@gnopaine> Subject: Re: [PATCH, rs6000] Add expansions for min/max vector reductions From: Bill Schmidt To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com Date: Wed, 16 Sep 2015 15:29:00 -0000 In-Reply-To: <20150916151455.GA13365@gate.crashing.org> References: <1442413689.2896.45.camel@gnopaine> <20150916151455.GA13365@gate.crashing.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091615-0005-0000-0000-00001811FBE4 X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg01195.txt.bz2 On Wed, 2015-09-16 at 10:14 -0500, Segher Boessenkool wrote: > On Wed, Sep 16, 2015 at 09:28:09AM -0500, Bill Schmidt wrote: > > I was able to use iterators for the sub-doubleword ...scal_ > > expansions, but that's all. I experimented with trying to use > > code_iterators to generate the {smax,smin,umax,umin} expansions, but > > couldn't find a way to make that work, as the substitution wasn't being > > done into the UNSPEC constants. If there is a way to do this, please > > let me know and I'll try to reduce the code size. > > Do you need the unspecs at all? They are only used in the pattern of > expanders, and all such expanders call DONE. You can instead write > those patterns as just USEs of their operands? Hi Segher, Yes, I had just independently come to the same conclusion -- since we are always calling DONE, I don't need the UNSPECs at all. I'm verifying to be sure, but this should solve my problem. Thanks! Bill > > > Segher >