From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104961 invoked by alias); 18 Sep 2015 18:29:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 104930 invoked by uid 89); 18 Sep 2015 18:29:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Sep 2015 18:29:31 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 5097F461E4 for ; Fri, 18 Sep 2015 18:29:30 +0000 (UTC) Received: from [10.3.225.210] (vpn-225-210.phx2.redhat.com [10.3.225.210]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8IITTZo006568; Fri, 18 Sep 2015 14:29:29 -0400 Message-ID: <1442600969.30732.24.camel@surprise> Subject: Re: [PATCH 03/22] Move diagnostic_show_locus and friends out into a new source file From: David Malcolm To: Jeff Law Cc: gcc-patches@gcc.gnu.org Date: Fri, 18 Sep 2015 18:31:00 -0000 In-Reply-To: <55F72181.1060404@redhat.com> References: <1441916913-11547-1-git-send-email-dmalcolm@redhat.com> <1441916913-11547-4-git-send-email-dmalcolm@redhat.com> <55F72181.1060404@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg01454.txt.bz2 On Mon, 2015-09-14 at 13:35 -0600, Jeff Law wrote: > On 09/10/2015 02:28 PM, David Malcolm wrote: > > The function "diagnostic_show_locus" gains new functionality in the > > next patch, so this preliminary patch breaks it out into a new source > > file, diagnostic-show-locus.c, along with a couple of related functions. > > > > gcc/ChangeLog: > > * Makefile.in (OBJS-libcommon): Add diagnostic-show-locus.o. > > * diagnostic.c (adjust_line): Move to diagnostic-show-locus.c. > > (diagnostic_show_locus): Likewise. > > (diagnostic_print_caret_line): Likewise. > > * diagnostic-show-locus.c: New file. > This is fine for the trunk. Thanks; bootstrapped®rtested; committed to trunk as r227915. > So much for the easy stuff :-) FWIW, I'm working on a much simpler version of the patch kit, addressing some of the issues already raised. > jeff >