From: Steve Ellcey <sellcey@imgtec.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Bernd Schmidt <bschmidt@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: RFC: Patch to allow spill slot alignment greater than the stack alignment
Date: Tue, 06 Oct 2015 18:32:00 -0000 [thread overview]
Message-ID: <1444156358.8687.257.camel@ubuntu-sellcey> (raw)
In-Reply-To: <CAMe9rOqMPaAJm_DQ3VOsSnFUe3qek6FaTYReTpV2nwgDdLOCUA@mail.gmail.com>
On Tue, 2015-10-06 at 11:10 -0700, H.J. Lu wrote:
> Does it pass all tests under g++.dg/torture/stackalign? You need
> to implement -mstackrealign and -mpreferred-stack-boundary=
> as well as update check_effective_target_automatic_stack_alignment
> to run all stack alignment tests.
No, those tests were not run. I have not implemented the -mstackrealign
or -mpreferred-stack-boundary options. I do not think those are the
options I want for stack realignment on MIPS. The only reason
for implementing stack realignment on MIPS is to align MSA (vector)
register spills. Yes, stack realignment can also be used with aligned
local variables but those could also be handled with the existing alloca
method without implementing stack realignment.
So I want an option (turned on by default when using -mmsa) that only
aligns a function if that function contains MSA register usage. I don't
want an option to align every function because that would slow things
down for no reason. I should and will try these test cases with my
option. Right now my testing forces all functions to be aligned even if
they don't use MSA because that gives me maximum testing, but the final
code will only align functions that use MSA.
Steve Ellcey
sellcey@imgtec.com
next prev parent reply other threads:[~2015-10-06 18:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 20:58 Steve Ellcey
2015-10-05 8:41 ` Bernd Schmidt
2015-10-05 16:10 ` Steve Ellcey
2015-10-05 16:21 ` H.J. Lu
2015-10-05 16:46 ` Steve Ellcey
2015-10-05 16:57 ` H.J. Lu
2015-10-06 15:30 ` Steve Ellcey
2015-10-06 15:35 ` H.J. Lu
2015-10-06 15:39 ` Bernd Schmidt
2015-10-06 18:02 ` Steve Ellcey
2015-10-06 18:10 ` H.J. Lu
2015-10-06 18:32 ` Steve Ellcey [this message]
2015-10-06 18:38 ` H.J. Lu
2015-10-09 22:22 ` Steve Ellcey
2015-10-09 22:36 ` H.J. Lu
2015-10-09 22:42 ` Steve Ellcey
2015-10-09 23:35 ` H.J. Lu
2015-10-06 23:24 ` Bernd Schmidt
2015-10-05 17:02 ` Bernd Schmidt
2015-10-05 17:51 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444156358.8687.257.camel@ubuntu-sellcey \
--to=sellcey@imgtec.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).