From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3010 invoked by alias); 21 Oct 2015 19:40:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2994 invoked by uid 89); 21 Oct 2015 19:40:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Oct 2015 19:40:15 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 08D31B99B4B1A; Wed, 21 Oct 2015 20:24:51 +0100 (IST) Received: from hhmail02.hh.imgtec.org (10.100.10.20) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 21 Oct 2015 20:24:54 +0100 Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.235.1; Wed, 21 Oct 2015 20:24:54 +0100 Received: from [10.20.3.214] (10.20.3.214) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 21 Oct 2015 12:24:51 -0700 Message-ID: <1445455491.2922.23.camel@ubuntu-sellcey> Subject: Re: [Patch, MIPS] Frame header optimization for MIPS (part 2) From: Steve Ellcey Reply-To: To: Bernd Schmidt CC: Mike Stump , , , Date: Wed, 21 Oct 2015 19:42:00 -0000 In-Reply-To: <5627DD3E.40306@redhat.com> References: <5626C664.7030006@redhat.com> <863CD8C6-74F0-4D29-A48C-9B22B8F0E2BE@comcast.net> <5627DD3E.40306@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SW-Source: 2015-10/txt/msg02149.txt.bz2 On Wed, 2015-10-21 at 20:45 +0200, Bernd Schmidt wrote: > On 10/21/2015 07:38 PM, Mike Stump wrote: > > On Oct 20, 2015, at 3:55 PM, Bernd Schmidt wrote: > >> There are many unnecessary parentheses in this patch which should be removed. > > > > I can smell a -Wall patch. :-) > > Not really, because -Wall isn't in the business of enforcing a coding style. > > > Bernd Hm, how about a separate warning that wasn't part of -Wall but could still be used by GCC or other products that wanted to enforce a 'no unnecessary parenthesis' coding style. Not that I'm volunteering. Steve Ellcey sellcey@imgtec.com