[PATCH] remove unused config/arm/coff.h

[PATCH] remove unused config/arm/coff.h

[tbsaunde+gcc]

From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>

Hi,

$subject, nothing refers to this header so we might as well remove it.

tested I can still build on x86_64-linux-gnu, not that I would expect anything
else or that it is particularly relevent, ok?

Trev

gcc/ChangeLog:

2015-11-03  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>

	* config/arm/coff.h: Remove.
---
 gcc/config/arm/coff.h | 82 ---------------------------------------------------
 1 file changed, 82 deletions(-)
 delete mode 100644 gcc/config/arm/coff.h

diff --git a/gcc/config/arm/coff.h b/gcc/config/arm/coff.h
deleted file mode 100644
index 526f9b9..0000000
--- a/gcc/config/arm/coff.h
+++ /dev/null
@@ -1,82 +0,0 @@
-/* Definitions of target machine for GNU compiler.
-   For ARM with COFF object format.
-   Copyright (C) 1995-2015 Free Software Foundation, Inc.
-   Contributed by Doug Evans (devans@cygnus.com).
-   
-   This file is part of GCC.
-
-   GCC is free software; you can redistribute it and/or modify it
-   under the terms of the GNU General Public License as published
-   by the Free Software Foundation; either version 3, or (at your
-   option) any later version.
-
-   GCC is distributed in the hope that it will be useful, but WITHOUT
-   ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
-   or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
-   License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with GCC; see the file COPYING3.  If not see
-   <http://www.gnu.org/licenses/>.  */
-
-/* Note - it is important that this definition matches the one in tcoff.h.  */
-#undef  USER_LABEL_PREFIX
-#define USER_LABEL_PREFIX "_"
-
-\f
-/* Run-time Target Specification.  */
-#undef  TARGET_DEFAULT_FLOAT_ABI
-#define TARGET_DEFAULT_FLOAT_ABI ARM_FLOAT_ABI_SOFT
-
-#undef  TARGET_DEFAULT
-#define TARGET_DEFAULT (MASK_APCS_FRAME)
-
-#ifndef MULTILIB_DEFAULTS
-#define MULTILIB_DEFAULTS \
-  { "marm", "mlittle-endian", "mfloat-abi=soft", "mno-thumb-interwork" }
-#endif
-\f
-/* This is COFF, but prefer stabs.  */
-#define SDB_DEBUGGING_INFO 1
-
-#define PREFERRED_DEBUGGING_TYPE DBX_DEBUG
-
-\f
-#define TARGET_ASM_FILE_START_APP_OFF true
-
-/* Switch into a generic section.  */
-#define TARGET_ASM_NAMED_SECTION  default_coff_asm_named_section
-\f
-/* Support the ctors/dtors and other sections.  */
-
-#undef INIT_SECTION_ASM_OP
-
-/* Define this macro if jump tables (for `tablejump' insns) should be
-   output in the text section, along with the assembler instructions.
-   Otherwise, the readonly data section is used.  */
-/* We put ARM and Thumb-2 jump tables in the text section, because it makes
-   the code more efficient, but for Thumb-1 it's better to put them out of
-   band unless we are generating compressed tables.  */
-#define JUMP_TABLES_IN_TEXT_SECTION					\
-   (TARGET_32BIT || (TARGET_THUMB && (optimize_size || flag_pic)))
-
-#undef  READONLY_DATA_SECTION_ASM_OP
-#define READONLY_DATA_SECTION_ASM_OP	"\t.section .rdata"
-#undef  CTORS_SECTION_ASM_OP
-#define CTORS_SECTION_ASM_OP	"\t.section .ctors,\"x\""
-#undef  DTORS_SECTION_ASM_OP
-#define DTORS_SECTION_ASM_OP	"\t.section .dtors,\"x\""
-\f
-/* Support the ctors/dtors sections for g++.  */
-
-/* __CTOR_LIST__ and __DTOR_LIST__ must be defined by the linker script.  */
-#define CTOR_LISTS_DEFINED_EXTERNALLY
-
-#undef DO_GLOBAL_CTORS_BODY
-#undef DO_GLOBAL_DTORS_BODY
-
-/* The ARM development system defines __main.  */
-#define NAME__MAIN  "__gccmain"
-#define SYMBOL__MAIN __gccmain
-
-#define SUPPORTS_INIT_PRIORITY 0
-- 
2.6.2

Re: [PATCH] remove unused config/arm/coff.h

[Richard Earnshaw]

On 03/11/15 11:31, tbsaunde+gcc@tbsaunde.org wrote:
> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> 
> Hi,
> 
> $subject, nothing refers to this header so we might as well remove it.
> 
> tested I can still build on x86_64-linux-gnu, not that I would expect anything
> else or that it is particularly relevent, ok?
> 

OK.

I think it was used by the pe-coff/wince port, but that was obsoleted
some time back.

R.

> Trev
> 
> gcc/ChangeLog:
> 
> 2015-11-03  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>
> 
> 	* config/arm/coff.h: Remove.
> ---
>  gcc/config/arm/coff.h | 82 ---------------------------------------------------
>  1 file changed, 82 deletions(-)
>  delete mode 100644 gcc/config/arm/coff.h
> 
> diff --git a/gcc/config/arm/coff.h b/gcc/config/arm/coff.h
> deleted file mode 100644
> index 526f9b9..0000000
> --- a/gcc/config/arm/coff.h
> +++ /dev/null
> @@ -1,82 +0,0 @@
> -/* Definitions of target machine for GNU compiler.
> -   For ARM with COFF object format.
> -   Copyright (C) 1995-2015 Free Software Foundation, Inc.
> -   Contributed by Doug Evans (devans@cygnus.com).
> -   
> -   This file is part of GCC.
> -
> -   GCC is free software; you can redistribute it and/or modify it
> -   under the terms of the GNU General Public License as published
> -   by the Free Software Foundation; either version 3, or (at your
> -   option) any later version.
> -
> -   GCC is distributed in the hope that it will be useful, but WITHOUT
> -   ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
> -   or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
> -   License for more details.
> -
> -   You should have received a copy of the GNU General Public License
> -   along with GCC; see the file COPYING3.  If not see
> -   <http://www.gnu.org/licenses/>.  */
> -
> -/* Note - it is important that this definition matches the one in tcoff.h.  */
> -#undef  USER_LABEL_PREFIX
> -#define USER_LABEL_PREFIX "_"
> -
> -\f
> -/* Run-time Target Specification.  */
> -#undef  TARGET_DEFAULT_FLOAT_ABI
> -#define TARGET_DEFAULT_FLOAT_ABI ARM_FLOAT_ABI_SOFT
> -
> -#undef  TARGET_DEFAULT
> -#define TARGET_DEFAULT (MASK_APCS_FRAME)
> -
> -#ifndef MULTILIB_DEFAULTS
> -#define MULTILIB_DEFAULTS \
> -  { "marm", "mlittle-endian", "mfloat-abi=soft", "mno-thumb-interwork" }
> -#endif
> -\f
> -/* This is COFF, but prefer stabs.  */
> -#define SDB_DEBUGGING_INFO 1
> -
> -#define PREFERRED_DEBUGGING_TYPE DBX_DEBUG
> -
> -\f
> -#define TARGET_ASM_FILE_START_APP_OFF true
> -
> -/* Switch into a generic section.  */
> -#define TARGET_ASM_NAMED_SECTION  default_coff_asm_named_section
> -\f
> -/* Support the ctors/dtors and other sections.  */
> -
> -#undef INIT_SECTION_ASM_OP
> -
> -/* Define this macro if jump tables (for `tablejump' insns) should be
> -   output in the text section, along with the assembler instructions.
> -   Otherwise, the readonly data section is used.  */
> -/* We put ARM and Thumb-2 jump tables in the text section, because it makes
> -   the code more efficient, but for Thumb-1 it's better to put them out of
> -   band unless we are generating compressed tables.  */
> -#define JUMP_TABLES_IN_TEXT_SECTION					\
> -   (TARGET_32BIT || (TARGET_THUMB && (optimize_size || flag_pic)))
> -
> -#undef  READONLY_DATA_SECTION_ASM_OP
> -#define READONLY_DATA_SECTION_ASM_OP	"\t.section .rdata"
> -#undef  CTORS_SECTION_ASM_OP
> -#define CTORS_SECTION_ASM_OP	"\t.section .ctors,\"x\""
> -#undef  DTORS_SECTION_ASM_OP
> -#define DTORS_SECTION_ASM_OP	"\t.section .dtors,\"x\""
> -\f
> -/* Support the ctors/dtors sections for g++.  */
> -
> -/* __CTOR_LIST__ and __DTOR_LIST__ must be defined by the linker script.  */
> -#define CTOR_LISTS_DEFINED_EXTERNALLY
> -
> -#undef DO_GLOBAL_CTORS_BODY
> -#undef DO_GLOBAL_DTORS_BODY
> -
> -/* The ARM development system defines __main.  */
> -#define NAME__MAIN  "__gccmain"
> -#define SYMBOL__MAIN __gccmain
> -
> -#define SUPPORTS_INIT_PRIORITY 0
> 

Re: [PATCH] remove unused config/arm/coff.h

[Jeff Law]

On 11/03/2015 04:31 AM, tbsaunde+gcc@tbsaunde.org wrote:
> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>
> Hi,
>
> $subject, nothing refers to this header so we might as well remove it.
>
> tested I can still build on x86_64-linux-gnu, not that I would expect anything
> else or that it is particularly relevent, ok?
>
> Trev
>
> gcc/ChangeLog:
>
> 2015-11-03  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>
>
> 	* config/arm/coff.h: Remove.
More generally, if we have a header file that's not used, I'd consider 
removing it to be obvious-enough to commit without approval.

We could/should probably do the same with unused functions, with the 
only wrinkle being things that are useful for debugging but which are 
otherwise unused should be kept around.

jeff

Re: [PATCH] remove unused config/arm/coff.h

[Richard Earnshaw]

On 03/11/15 13:49, Jeff Law wrote:
> On 11/03/2015 04:31 AM, tbsaunde+gcc@tbsaunde.org wrote:
>> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>>
>> Hi,
>>
>> $subject, nothing refers to this header so we might as well remove it.
>>
>> tested I can still build on x86_64-linux-gnu, not that I would expect
>> anything
>> else or that it is particularly relevent, ok?
>>
>> Trev
>>
>> gcc/ChangeLog:
>>
>> 2015-11-03  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>
>>
>>     * config/arm/coff.h: Remove.
> More generally, if we have a header file that's not used, I'd consider
> removing it to be obvious-enough to commit without approval.
> 
> We could/should probably do the same with unused functions, with the
> only wrinkle being things that are useful for debugging but which are
> otherwise unused should be kept around.
> 

I'd go as far as to say that such functions should be commented to that
effect.

R.

> jeff
> 

Re: [PATCH] remove unused config/arm/coff.h

[Trevor Saunders]

On Tue, Nov 03, 2015 at 06:49:20AM -0700, Jeff Law wrote:
> On 11/03/2015 04:31 AM, tbsaunde+gcc@tbsaunde.org wrote:
> >From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> >
> >Hi,
> >
> >$subject, nothing refers to this header so we might as well remove it.
> >
> >tested I can still build on x86_64-linux-gnu, not that I would expect anything
> >else or that it is particularly relevent, ok?
> >
> >Trev
> >
> >gcc/ChangeLog:
> >
> >2015-11-03  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>
> >
> >	* config/arm/coff.h: Remove.
> More generally, if we have a header file that's not used, I'd consider
> removing it to be obvious-enough to commit without approval.
> 
> We could/should probably do the same with unused functions, with the only
> wrinkle being things that are useful for debugging but which are otherwise
> unused should be kept around.

I'd agree removing things that are dead is obvious, but sometimes things
are so convoluted its hard to be sure they are in fact dead, and then
its nice to have some confirmation you didn't miss something :)

Trev

> 
> jeff
> 

Re: [PATCH] remove unused config/arm/coff.h

[Richard Earnshaw]

On 03/11/15 15:37, Trevor Saunders wrote:
> On Tue, Nov 03, 2015 at 06:49:20AM -0700, Jeff Law wrote:
>> On 11/03/2015 04:31 AM, tbsaunde+gcc@tbsaunde.org wrote:
>>> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>>>
>>> Hi,
>>>
>>> $subject, nothing refers to this header so we might as well remove it.
>>>
>>> tested I can still build on x86_64-linux-gnu, not that I would expect anything
>>> else or that it is particularly relevent, ok?
>>>
>>> Trev
>>>
>>> gcc/ChangeLog:
>>>
>>> 2015-11-03  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>
>>>
>>> 	* config/arm/coff.h: Remove.
>> More generally, if we have a header file that's not used, I'd consider
>> removing it to be obvious-enough to commit without approval.
>>
>> We could/should probably do the same with unused functions, with the only
>> wrinkle being things that are useful for debugging but which are otherwise
>> unused should be kept around.
> 
> I'd agree removing things that are dead is obvious, but sometimes things
> are so convoluted its hard to be sure they are in fact dead, and then
> its nice to have some confirmation you didn't miss something :)
> 

Caution is to be commended.  In this sort of case, however, you can
probably claim obviousness but then self-impose a pre-commit timeout: I
think this is obvious but I'll wait 24 hours before committing.

R.

> Trev
> 
>>
>> jeff
>>