From: David Malcolm <dmalcolm@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: [committed 1/5] Fix -Wmisleading-indentation warning in function.c
Date: Thu, 10 Dec 2015 15:25:00 -0000 [thread overview]
Message-ID: <1449762259-37055-1-git-send-email-dmalcolm@redhat.com> (raw)
In-Reply-To: <5632597B.2020205@redhat.com>
Fix this warning:
../../../src/gcc/function.c: In function âvoid locate_and_pad_parm(machine_mode, tree, int, int, int, tree, args_size*, locate_and_pad_arg_data*)â:
../../../src/gcc/function.c:4123:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
{
^
../../../src/gcc/function.c:4119:7: note: ...this âifâ clause, but it is not
if (initial_offset_ptr->var)
^
[This warning would have been suppressed by the blank-lines heuristic
from:
https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01011.html ]
Preapproved by Jeff in:
https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03246.html
Bootstrapped®rtested on x86_64-pc-linux-gnu.
Committed to trunk as r231518.
gcc/ChangeLog:
* function.c (locate_and_pad_parm): Fix indentation.
---
gcc/function.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/gcc/function.c b/gcc/function.c
index b513ead..035a49e 100644
--- a/gcc/function.c
+++ b/gcc/function.c
@@ -4181,14 +4181,14 @@ locate_and_pad_parm (machine_mode passed_mode, tree type, int in_regs,
locate->slot_offset.var = size_binop (MINUS_EXPR, ssize_int (0),
initial_offset_ptr->var);
- {
- tree s2 = sizetree;
- if (where_pad != none
- && (!tree_fits_uhwi_p (sizetree)
- || (tree_to_uhwi (sizetree) * BITS_PER_UNIT) % round_boundary))
- s2 = round_up (s2, round_boundary / BITS_PER_UNIT);
- SUB_PARM_SIZE (locate->slot_offset, s2);
- }
+ {
+ tree s2 = sizetree;
+ if (where_pad != none
+ && (!tree_fits_uhwi_p (sizetree)
+ || (tree_to_uhwi (sizetree) * BITS_PER_UNIT) % round_boundary))
+ s2 = round_up (s2, round_boundary / BITS_PER_UNIT);
+ SUB_PARM_SIZE (locate->slot_offset, s2);
+ }
locate->slot_offset.constant += part_size_in_regs;
--
1.8.5.3
next prev parent reply other threads:[~2015-12-10 15:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 16:32 [PATCH 0/4] -Wmisleading-indentation David Malcolm
2015-10-29 16:32 ` [PATCH 1/4] -Wmisleading-indentation: don't warn in presence of entirely blank lines David Malcolm
2015-10-29 17:33 ` Jeff Law
2015-10-29 17:38 ` Patrick Palka
2015-10-29 17:44 ` Patrick Palka
2015-10-29 17:50 ` Jeff Law
2015-10-29 17:56 ` Mike Stump
2015-10-29 17:56 ` Patrick Palka
2015-10-29 18:00 ` Mike Stump
2015-10-29 18:13 ` David Malcolm
2015-10-29 17:59 ` AW: " bernds_cb1
2015-10-29 16:32 ` [PATCH 4/4] Add -Wmisleading-indentation to -Wall David Malcolm
2015-10-29 17:42 ` Jeff Law
2015-10-30 9:16 ` Richard Biener
2015-11-01 22:06 ` Patrick Palka
2015-11-02 16:21 ` David Malcolm
2015-11-02 17:11 ` David Malcolm
2015-11-02 18:39 ` Patrick Palka
2015-11-02 19:35 ` David Malcolm
2015-11-02 20:35 ` Marc Glisse
2015-11-02 23:41 ` Jeff Law
2015-12-09 15:19 ` [PATCH] Add levels to -Wmisleading-indentation; add level 1 " David Malcolm
2015-12-09 15:40 ` Bernd Schmidt
2015-12-09 16:49 ` David Malcolm
2015-12-09 17:19 ` Pedro Alves
2015-12-09 17:34 ` Bernd Schmidt
2015-12-10 15:25 ` David Malcolm [this message]
2015-12-10 15:25 ` [committed 5/5] Fix -Wmisleading-indentation warning in graphite-optimize-isl.c David Malcolm
2015-12-11 16:44 ` Sebastian Pop
2015-12-10 15:25 ` [committed 3/5] Fix -Wmisleading-indentation warning in gcc/regrename.c David Malcolm
2015-12-10 15:25 ` [committed 2/5] Fix misleading indentation in gcc/fortran/io.c David Malcolm
2015-12-10 15:25 ` [committed 4/5] Fix -Wmisleading-indentation warning in ifcvt.c David Malcolm
2015-12-10 15:33 ` [committed 1/5] Fix -Wmisleading-indentation warning in function.c David Malcolm
2015-12-10 18:25 ` [PATCH 4/4] Add -Wmisleading-indentation to -Wall David Malcolm
2015-10-29 16:32 ` [PATCH 2/4] Fix misleading indentation in tree-ssa-loop-unswitch.c David Malcolm
2015-10-29 17:34 ` Jeff Law
2015-10-29 16:32 ` [PATCH 3/4] Fix misleading indentation in tree-nested.c David Malcolm
2015-10-29 17:36 ` Jeff Law
2015-10-30 5:42 ` [PATCH 0/4] -Wmisleading-indentation Andi Kleen
2015-10-30 5:59 ` Jeff Law
2015-10-30 15:42 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449762259-37055-1-git-send-email-dmalcolm@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).