public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: James Greenhalgh <james.greenhalgh@arm.com>
To: <gcc-patches@gcc.gnu.org>
Cc: <nd@arm.com>, <marcus.shawcroft@arm.com>,
	<richard.earnshaw@arm.com>,	<Venkataramanan.Kumar@amd.com>,
	<philipp.tomsich@theobroma-systems.com>,	<pinskia@gmail.com>,
	<Kyrylo.Tkachov@arm.com>, <e.menezes@samsung.com>
Subject: [AArch64] Remove AARCH64_EXTRA_TUNE_RECIP_SQRT from Cortex-A57 tuning
Date: Mon, 11 Jan 2016 12:05:00 -0000	[thread overview]
Message-ID: <1452513883-25826-1-git-send-email-james.greenhalgh@arm.com> (raw)
In-Reply-To: <1452513219-25168-1-git-send-email-james.greenhalgh@arm.com>

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]


Hi,

I've seen a couple of large performance issues caused by expanding
the high-precision reciprocal square root for Cortex-A57, so I'd like
to turn it off by default.

This is good for art (~2%) from Spec2000, bad (~3.5%) for fma3d from
Spec2000, good (~5.5%) for gromcas from Spec2006, and very good (>10%) for
some private microbenchmark kernels which stress the divide/sqrt/multiply
units. It therefore seems to me to be the correct choice to make across
a number of workloads.

Bootstrapped and tested on aarch64-none-linux-gnu with no issues.

OK?

Thanks,
James

---
2015-12-11  James Greenhalgh  <james.greenhalgh@arm.com>

	* config/aarch64/aarch64.c (cortexa57_tunings): Remove
	AARCH64_EXTRA_TUNE_RECIP_SQRT.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-AArch64-Remove-AARCH64_EXTRA_TUNE_RECIP_SQRT-from-Co.patch --]
[-- Type: text/x-patch;  name=0001-AArch64-Remove-AARCH64_EXTRA_TUNE_RECIP_SQRT-from-Co.patch, Size: 598 bytes --]

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 1d5d898..999c9fc 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -484,8 +484,7 @@ static const struct tune_params cortexa57_tunings =
   0,	/* max_case_values.  */
   0,	/* cache_line_size.  */
   tune_params::AUTOPREFETCHER_WEAK,	/* autoprefetcher_model.  */
-  (AARCH64_EXTRA_TUNE_RENAME_FMA_REGS
-   | AARCH64_EXTRA_TUNE_RECIP_SQRT)	/* tune_flags.  */
+  (AARCH64_EXTRA_TUNE_RENAME_FMA_REGS)	/* tune_flags.  */
 };
 
 static const struct tune_params cortexa72_tunings =

  reply	other threads:[~2016-01-11 12:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 11:53 [Patch AArch64] Use software sqrt expansion always for -mlow-precision-recip-sqrt James Greenhalgh
2016-01-11 12:05 ` James Greenhalgh [this message]
2016-01-11 13:31   ` [AArch64] Remove AARCH64_EXTRA_TUNE_RECIP_SQRT from Cortex-A57 tuning Dr. Philipp Tomsich
2016-01-25 11:20   ` James Greenhalgh
2016-02-01 14:00     ` James Greenhalgh
2016-02-08 10:57       ` James Greenhalgh
2016-02-15 10:50         ` James Greenhalgh
2016-02-15 17:25           ` Evandro Menezes
2016-02-16 10:28             ` James Greenhalgh
2016-02-16 20:46               ` Evandro Menezes
2016-02-16  8:49   ` Marcus Shawcroft
2016-01-11 22:58 ` [Patch AArch64] Use software sqrt expansion always for -mlow-precision-recip-sqrt Evandro Menezes
2016-01-12 11:32   ` James Greenhalgh
2016-01-12 11:44     ` Kyrill Tkachov
2016-01-12  5:53 ` Kumar, Venkataramanan
2016-01-12 11:48   ` James Greenhalgh
2016-01-25 11:21 ` James Greenhalgh
2016-02-01 13:59   ` James Greenhalgh
2016-02-08 10:57     ` James Greenhalgh
2016-02-15 10:48       ` James Greenhalgh
2016-02-16  8:40 ` Marcus Shawcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452513883-25826-1-git-send-email-james.greenhalgh@arm.com \
    --to=james.greenhalgh@arm.com \
    --cc=Kyrylo.Tkachov@arm.com \
    --cc=Venkataramanan.Kumar@amd.com \
    --cc=e.menezes@samsung.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=marcus.shawcroft@arm.com \
    --cc=nd@arm.com \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=pinskia@gmail.com \
    --cc=richard.earnshaw@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).