From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55088 invoked by alias); 21 Jan 2016 18:27:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54285 invoked by uid 89); 21 Jan 2016 18:27:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=transaction, HContent-Transfer-Encoding:8bit X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Jan 2016 18:27:10 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 8BA088F22D; Thu, 21 Jan 2016 18:27:09 +0000 (UTC) Received: from [10.36.5.253] (vpn1-5-253.ams2.redhat.com [10.36.5.253]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0LIR6hv022350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO); Thu, 21 Jan 2016 13:27:07 -0500 Message-ID: <1453400825.4592.16.camel@localhost.localdomain> Subject: Re: [PATCH] libitm: Disable testing transaction-safe exceptions on Darwin and AIX. From: Torvald Riegel To: Jonathan Wakely Cc: Mike Stump , Dominique =?ISO-8859-1?Q?d=27Humi=E8res?= , libstdc++@gcc.gnu.org, gcc-patches , Jack Howarth Date: Thu, 21 Jan 2016 18:27:00 -0000 In-Reply-To: <20160121182621.GD15084@redhat.com> References: <1EF9008F-5418-4A35-AA1F-9931E464B0AA@lps.ens.fr> <1453230646.23593.13.camel@localhost.localdomain> <20160119192001.GK15084@redhat.com> <572007D4-C174-4181-8CE9-88D930581163@lps.ens.fr> <1453389937.4592.3.camel@localhost.localdomain> <6EEDF783-378A-4F21-89A5-6FD0914837F5@comcast.net> <1453400116.4592.11.camel@localhost.localdomain> <38FE8E65-D744-4985-8B69-106AEE3B7FDE@comcast.net> <20160121182621.GD15084@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg01666.txt.bz2 On Thu, 2016-01-21 at 18:26 +0000, Jonathan Wakely wrote: > On 21/01/16 10:19 -0800, Mike Stump wrote: > >On Jan 21, 2016, at 10:15 AM, Torvald Riegel wrote: > >> On Thu, 2016-01-21 at 10:06 -0800, Mike Stump wrote: > >>> On Jan 21, 2016, at 9:29 AM, Dominique d'Humières wrote: > >>>> // { dg-do run { target { ! { *-*-darwin* powerpc-ibm-aix* } } } } > >>> > >>> A comment to hint that this has something to do with weak undefined would be nice. > >> > >> Here's the patch I prepared (which indeed includes a comment). > >> > >> OK for trunk? I'm not quite sure whether this qualifies as a > >> regression, but having an additional test that now fails is one I guess. > >> > > > >A simple testsuite fixup like this is still ok. From a darwin, AIX perspective it is fine. If either the transaction or the libstdc++ people like it, I think we’re set. > > OK from the libstdc++ side. > Committed.