From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88219 invoked by alias); 27 Jan 2016 14:24:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 88206 invoked by uid 89); 27 Jan 2016 14:24:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ambiguous, num_matches, ob_fndecl, stricter X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Jan 2016 14:24:06 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 2B7E049DBB; Wed, 27 Jan 2016 14:24:05 +0000 (UTC) Received: from vpn-226-215.phx2.redhat.com (vpn-226-215.phx2.redhat.com [10.3.226.215]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0REO4s4019426; Wed, 27 Jan 2016 09:24:04 -0500 Message-ID: <1453904539.7283.12.camel@redhat.com> Subject: Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics. From: David Malcolm To: vogt@linux.vnet.ibm.com, gcc-patches@gcc.gnu.org Cc: Andreas Krebbel Date: Wed, 27 Jan 2016 14:24:00 -0000 In-Reply-To: <20160127110126.GA7243@linux.vnet.ibm.com> References: <20160127110126.GA7243@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg02113.txt.bz2 On Wed, 2016-01-27 at 12:01 +0100, Dominik Vogt wrote: > The attached patch removes a blank line after an error message. > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69006 Presumably this was exposed by the stricter testing I added to lib/gcc -dg.exp in r232837? > else if (num_matches > 1) > { > - error_at (loc, "ambiguous overload for intrinsic: %s\n", > + error_at (loc, "ambiguous overload for intrinsic: %s", > IDENTIFIER_POINTER (DECL_NAME (ob_fndecl))); > return error_mark_node; > } I'm not a reviewer, but FWIW the removal of the trailing "\n" looks sane to me. Should this code be using %qs rather than %s? (or somesuch, or is that a gcc 7 thing) Dave