public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, rs6000] Partial fix for PR65546 (GCC 6)
@ 2016-01-28 17:45 Bill Schmidt
  2016-01-28 17:56 ` Bill Schmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Bill Schmidt @ 2016-01-28 17:45 UTC (permalink / raw)
  To: gcc-patches; +Cc: dje.gcc

Hi,

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65546 discusses the failure
of gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c.  The test fails
differently on GCC 4.9 and 5 than it does on GCC 6.  For GCC 6, the test
case is faulty, as we only expect to see the "vectorization not
profitable" statement when misaligned loads/stores are not efficient on
the target hardware.  This patch fixes the test for GCC 6.

Something else is going on in the earlier releases, which I plan to look
at separately.

Verified on powerpc64le-unknown-linux-gnu.  Is this okay for trunk?

Thanks,
Bill


2016-01-28  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	PR target/65546
	* gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Disable check
	for "vectorization not profitable" when the target supports
	misaligned loads and stores.


Index: gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c	(revision 232890)
+++ gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c	(working copy)
@@ -46,5 +46,5 @@ int main (void)
   return main1 ();
 } 
 
-/* { dg-final { scan-tree-dump-times "vectorization not profitable" 1 "vect" } } */
+/* { dg-final { scan-tree-dump-times "vectorization not profitable" 1 "vect" { target { ! vect_hw_misalign } } } } */
 /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 0 "vect" { target { ! vect_hw_misalign } } } } */


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, rs6000] Partial fix for PR65546 (GCC 6)
  2016-01-28 17:45 [PATCH, rs6000] Partial fix for PR65546 (GCC 6) Bill Schmidt
@ 2016-01-28 17:56 ` Bill Schmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Bill Schmidt @ 2016-01-28 17:56 UTC (permalink / raw)
  To: gcc-patches; +Cc: dje.gcc

Actually, please hold off on this.  The test in general is just faulty.
I'll get something more complete later on.

Sorry for the noise,
Bill

On Thu, 2016-01-28 at 11:45 -0600, Bill Schmidt wrote:
> Hi,
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65546 discusses the failure
> of gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c.  The test fails
> differently on GCC 4.9 and 5 than it does on GCC 6.  For GCC 6, the test
> case is faulty, as we only expect to see the "vectorization not
> profitable" statement when misaligned loads/stores are not efficient on
> the target hardware.  This patch fixes the test for GCC 6.
> 
> Something else is going on in the earlier releases, which I plan to look
> at separately.
> 
> Verified on powerpc64le-unknown-linux-gnu.  Is this okay for trunk?
> 
> Thanks,
> Bill
> 
> 
> 2016-01-28  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
> 
> 	PR target/65546
> 	* gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Disable check
> 	for "vectorization not profitable" when the target supports
> 	misaligned loads and stores.
> 
> 
> Index: gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c	(revision 232890)
> +++ gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c	(working copy)
> @@ -46,5 +46,5 @@ int main (void)
>    return main1 ();
>  } 
> 
> -/* { dg-final { scan-tree-dump-times "vectorization not profitable" 1 "vect" } } */
> +/* { dg-final { scan-tree-dump-times "vectorization not profitable" 1 "vect" { target { ! vect_hw_misalign } } } } */
>  /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 0 "vect" { target { ! vect_hw_misalign } } } } */
> 
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-28 17:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-28 17:45 [PATCH, rs6000] Partial fix for PR65546 (GCC 6) Bill Schmidt
2016-01-28 17:56 ` Bill Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).