From: Patrick Palka <patrick@parcs.ath.cx>
To: gcc-patches@gcc.gnu.org
Cc: Patrick Palka <patrick@parcs.ath.cx>
Subject: [PATCH] Turn some compile-time tests into run-time tests
Date: Thu, 10 Mar 2016 23:39:00 -0000 [thread overview]
Message-ID: <1457653131-32296-1-git-send-email-patrick@parcs.ath.cx> (raw)
I ran the command
git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep -lw main
to find tests marked as compile-time tests that likely ought to instead
be marked as run-time tests, by the rationale that they use
__builtin_abort and they also define main(). (I also then confirmed that they
compile, link and run cleanly on my machine.)
After this patch, the remaining test files reported by the above command
are:
These do not define all the functions they use:
gcc/testsuite/g++.dg/ipa/devirt-41.C
gcc/testsuite/g++.dg/ipa/devirt-44.C
gcc/testsuite/g++.dg/ipa/devirt-45.C
gcc/testsuite/gcc.target/i386/pr55672.c
These are non-x86 tests so I can't confirm that they run cleanly:
gcc/testsuite/gcc.target/arm/pr58041.c
gcc/testsuite/gcc.target/powerpc/pr35907.c
gcc/testsuite/gcc.target/s390/dwarfregtable-1.c
gcc/testsuite/gcc.target/s390/dwarfregtable-2.c
gcc/testsuite/gcc.target/s390/dwarfregtable-3.c
These use dg-error:
libstdc++-v3/testsuite/20_util/forward/c_neg.cc
libstdc++-v3/testsuite/20_util/forward/f_neg.cc
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK to
commit? Does anyone have another heuristic one can use to help find
these kinds of typos?
gcc/testsuite/ChangeLog:
* g++.dg/cpp0x/constexpr-aggr2.C: Make it a run-time test.
* g++.dg/cpp0x/nullptr32.C: Likewise.
* g++.dg/cpp1y/digit-sep-cxx11-neg.C: Likewise.
* g++.dg/cpp1y/digit-sep.C: Likewise.
* g++.dg/ext/flexary13.C: Likewise.
* gcc.dg/alias-14.c: Likewise.
* gcc.dg/ipa/PR65282.c: Likewise.
* gcc.dg/pr69644.c: Likewise.
* gcc.dg/tree-ssa/pr38533.c: Likewise.
* gcc.dg/tree-ssa/pr61385.c: Likewise.
---
gcc/testsuite/g++.dg/cpp0x/constexpr-aggr2.C | 2 +-
gcc/testsuite/g++.dg/cpp0x/nullptr32.C | 2 +-
gcc/testsuite/g++.dg/cpp1y/digit-sep-cxx11-neg.C | 2 +-
gcc/testsuite/g++.dg/cpp1y/digit-sep.C | 2 +-
gcc/testsuite/g++.dg/ext/flexary13.C | 2 +-
gcc/testsuite/gcc.dg/alias-14.c | 2 +-
gcc/testsuite/gcc.dg/ipa/PR65282.c | 2 +-
gcc/testsuite/gcc.dg/pr69644.c | 2 +-
gcc/testsuite/gcc.dg/tree-ssa/pr38533.c | 2 +-
gcc/testsuite/gcc.dg/tree-ssa/pr61385.c | 2 +-
10 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-aggr2.C b/gcc/testsuite/g++.dg/cpp0x/constexpr-aggr2.C
index 805d026..ed01aad 100644
--- a/gcc/testsuite/g++.dg/cpp0x/constexpr-aggr2.C
+++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-aggr2.C
@@ -1,5 +1,5 @@
// PR c++/68782
-// { dg-do compile { target c++11 } }
+// { dg-do run { target c++11 } }
#define assert(X) do { if (!(X)) __builtin_abort(); } while (0)
diff --git a/gcc/testsuite/g++.dg/cpp0x/nullptr32.C b/gcc/testsuite/g++.dg/cpp0x/nullptr32.C
index a1e6710..4de4140 100644
--- a/gcc/testsuite/g++.dg/cpp0x/nullptr32.C
+++ b/gcc/testsuite/g++.dg/cpp0x/nullptr32.C
@@ -1,6 +1,6 @@
// PR c++/63942
// A mangling alias for the first constructor was conflicting with the second.
-// { dg-do compile { target c++11 } }
+// { dg-do run { target c++11 } }
// { dg-options "-fno-inline" }
int i;
diff --git a/gcc/testsuite/g++.dg/cpp1y/digit-sep-cxx11-neg.C b/gcc/testsuite/g++.dg/cpp1y/digit-sep-cxx11-neg.C
index 411ba52..c1cbc6c 100644
--- a/gcc/testsuite/g++.dg/cpp1y/digit-sep-cxx11-neg.C
+++ b/gcc/testsuite/g++.dg/cpp1y/digit-sep-cxx11-neg.C
@@ -1,4 +1,4 @@
-// { dg-do compile { target { ! c++14 } } }
+// { dg-do run { target { ! c++14 } } }
#define assert(E) if(!(E))__builtin_abort();
diff --git a/gcc/testsuite/g++.dg/cpp1y/digit-sep.C b/gcc/testsuite/g++.dg/cpp1y/digit-sep.C
index 111e7a5..75a12f6 100644
--- a/gcc/testsuite/g++.dg/cpp1y/digit-sep.C
+++ b/gcc/testsuite/g++.dg/cpp1y/digit-sep.C
@@ -1,4 +1,4 @@
-// { dg-do compile { target c++14 } }
+// { dg-do run { target c++14 } }
#define assert(E) if(!(E))__builtin_abort();
diff --git a/gcc/testsuite/g++.dg/ext/flexary13.C b/gcc/testsuite/g++.dg/ext/flexary13.C
index 462ed65..1347542 100644
--- a/gcc/testsuite/g++.dg/ext/flexary13.C
+++ b/gcc/testsuite/g++.dg/ext/flexary13.C
@@ -1,4 +1,4 @@
-// { dg-do compile }
+// { dg-do run }
// { dg-options -Wno-pedantic }
#define STR(s) #s
diff --git a/gcc/testsuite/gcc.dg/alias-14.c b/gcc/testsuite/gcc.dg/alias-14.c
index 1ca1c09..24f0d1c 100644
--- a/gcc/testsuite/gcc.dg/alias-14.c
+++ b/gcc/testsuite/gcc.dg/alias-14.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do run } */
/* { dg-options "-O2" } */
#include <stddef.h>
void *a;
diff --git a/gcc/testsuite/gcc.dg/ipa/PR65282.c b/gcc/testsuite/gcc.dg/ipa/PR65282.c
index a52bec6..a7a881a 100644
--- a/gcc/testsuite/gcc.dg/ipa/PR65282.c
+++ b/gcc/testsuite/gcc.dg/ipa/PR65282.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do run } */
/* { dg-options "-Os -fdump-ipa-icf" } */
int a[2];
diff --git a/gcc/testsuite/gcc.dg/pr69644.c b/gcc/testsuite/gcc.dg/pr69644.c
index c60b191..bb775cd 100644
--- a/gcc/testsuite/gcc.dg/pr69644.c
+++ b/gcc/testsuite/gcc.dg/pr69644.c
@@ -1,5 +1,5 @@
/* PR target/69644 */
-/* { dg-do compile } */
+/* { dg-do run } */
int
main ()
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr38533.c b/gcc/testsuite/gcc.dg/tree-ssa/pr38533.c
index ac8dfb9..05cb973 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/pr38533.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/pr38533.c
@@ -1,5 +1,5 @@
/* PR middle-end/38533 */
-/* { dg-do compile } */
+/* { dg-do run } */
/* { dg-options "-O2 --param tree-reassoc-width=1 -fdump-tree-reassoc1" } */
#define A asm volatile ("" : "=r" (f) : "0" (0)); e |= f;
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr61385.c b/gcc/testsuite/gcc.dg/tree-ssa/pr61385.c
index f2e5a3c..1762f02 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/pr61385.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/pr61385.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do run } */
/* { dg-options "-O2" } */
#define assert(x) if (!(x)) __builtin_abort ()
--
2.8.0.rc1.12.gfce6d53
next reply other threads:[~2016-03-10 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 23:39 Patrick Palka [this message]
2016-03-10 23:54 ` Patrick Palka
2016-03-11 16:39 ` Patrick Palka
2016-04-27 21:26 ` Jeff Law
2016-04-27 21:37 ` Jeff Law
2016-04-28 14:03 ` Patrick Palka
2016-04-28 14:59 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457653131-32296-1-git-send-email-patrick@parcs.ath.cx \
--to=patrick@parcs.ath.cx \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).