From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] Factor out common internal-fn idiom
Date: Sun, 12 Jun 2022 12:05:17 -0600 [thread overview]
Message-ID: <145cbbdd-278c-520a-d3a9-2892a3f3c402@gmail.com> (raw)
In-Reply-To: <mptwndoeva0.fsf@arm.com>
On 6/10/2022 3:13 AM, Richard Sandiford via Gcc-patches wrote:
> internal-fn.c has quite a few functions that simply map the result
> of the call to an instruction's output operand (if any) and map
> each argument to an instruction's input operand, in order.
> This patch adds a single function for doing that. It's really
> just a generalisation of expand_direct_optab_fn, but with the
> output operand being optional.
>
> Unfortunately, it isn't possible to do this for vcond_mask
> because the internal function has a different argument order
> from the optab.
>
> Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install?
>
> Richard
>
>
> gcc/
> * internal-fn.cc (expand_fn_using_insn): New function,
> split out and adapted from...
> (expand_direct_optab_fn): ...here.
> (expand_GOMP_SIMT_ENTER_ALLOC): Use it.
> (expand_GOMP_SIMT_EXIT): Likewise.
> (expand_GOMP_SIMT_LANE): Likewise.
> (expand_GOMP_SIMT_LAST_LANE): Likewise.
> (expand_GOMP_SIMT_ORDERED_PRED): Likewise.
> (expand_GOMP_SIMT_VOTE_ANY): Likewise.
> (expand_GOMP_SIMT_XCHG_BFLY): Likewise.
> (expand_GOMP_SIMT_XCHG_IDX): Likewise.
OK
Jeff
prev parent reply other threads:[~2022-06-12 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 9:13 Richard Sandiford
2022-06-12 18:05 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145cbbdd-278c-520a-d3a9-2892a3f3c402@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).