public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Svante Signell <svante.signell@gmail.com>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Eric Botcazou <ebotcazou@adacore.com>,
	gcc-patches@gcc.gnu.org, Arnaud	Charlet <charlet@adacore.com>,
	Matthias Klose <doko@debian.org>
Subject: Re: Please include ada-hurd.diff upstream (try2)
Date: Wed, 04 May 2016 17:43:00 -0000	[thread overview]
Message-ID: <1462383807.2897.51.camel@gmail.com> (raw)
In-Reply-To: <1462380222.2897.39.camel@gmail.com>

On Wed, 2016-05-04 at 18:43 +0200, Svante Signell wrote:
> OnSamuel Thibault, on Wed 04 May 2016 17:29:48 +0200, wrote:
> > 
> > > -   --  From: /usr/include/unistd.h __getpagesize or
> > > getpagesize??
> > > -   function Get_Page_Size return int;
> > > +   --  From: /usr/include/i386-gnu/bits/shm.h __getpagesize or
> > > getpagesize??
> > > +   function Get_Page_Size return size_t;
> > > +   function Get_Page_Size return Address;
> > > 
> > > Why using size_t and Address?  Other OSes use int, and the
> > > prototype for
> > > getpagesize is returning int.
> > > 
> > > Also, don't use the __ versions of the glibc functions, they are
> > > internal aliases, the API is without __.
> > > 
> > 
> I thought I did change that, but apparently not. I did such a change,
> but it was probably somewhere else. Please submit your patch upstream
> and to Debian.

No it was not somewhere else. I did change that, see Debian bug
#811063. I even built gcc-6 to make sure everything was OK. And still
it did not get into the updated patch, strange.

May I comment on Debian way of apt-get source gcc-*: Doing that does
not unpack the sources, neither does it apply the patches, you have to
unpack and patch before you can change sources and update patches. Iv'e
patched the sources several times and still find that the updated
patches are not included in the next build. Really confusing.

Thanks!

  reply	other threads:[~2016-05-04 17:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 23:42 Svante Signell
2016-03-07  5:22 ` Matthias Klose
2016-03-16 10:08 ` Eric Botcazou
2016-03-16 10:41   ` Svante Signell
2016-03-16 10:54     ` Eric Botcazou
2016-03-16 11:15       ` Svante Signell
2016-03-16 11:19         ` Arnaud Charlet
2016-03-16 21:55       ` Svante Signell
2016-03-17  7:51         ` Arnaud Charlet
2016-03-31  9:52           ` Svante Signell
2016-04-19  6:49             ` Svante Signell
2016-04-19  8:30               ` Arnaud Charlet
2016-04-25  9:22                 ` Svante Signell
2016-04-25  9:50                   ` Arnaud Charlet
2016-04-25 10:28                     ` Svante Signell
2016-04-25 10:31                       ` Arnaud Charlet
2016-04-27  7:41                       ` Eric Botcazou
2016-04-27  8:06                         ` Svante Signell
2016-05-04 15:29                           ` Samuel Thibault
2016-05-04 15:34                             ` Samuel Thibault
2016-05-04 16:02                               ` Arnaud Charlet
2016-05-04 16:43                               ` Svante Signell
2016-05-04 17:43                                 ` Svante Signell [this message]
2016-05-04 21:06                                   ` Samuel Thibault
2016-05-04 21:25                                     ` Svante Signell
2016-05-04 21:28                                       ` Samuel Thibault
2016-05-04 19:17                               ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462383807.2897.51.camel@gmail.com \
    --to=svante.signell@gmail.com \
    --cc=charlet@adacore.com \
    --cc=doko@debian.org \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=samuel.thibault@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).