From: David Malcolm <dmalcolm@redhat.com>
To: Bernd Schmidt <bschmidt@redhat.com>, gcc-patches@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: [PATCH] Add selftest for pretty-print.c (v2)
Date: Wed, 08 Jun 2016 00:30:00 -0000 [thread overview]
Message-ID: <1465347379-43873-1-git-send-email-dmalcolm@redhat.com> (raw)
In-Reply-To: <bf863a95-251f-2545-cc0a-6441e24c1f43@redhat.com>
On Tue, 2016-06-07 at 12:02 +0200, Bernd Schmidt wrote:
> On 06/06/2016 11:28 PM, David Malcolm wrote:
> > + assert_pp_format ("0xcafebabe", "%wx",
> > (HOST_WIDE_INT)0xcafebabe);
>
> More interesting tests would be to have multiple arguments to test
> that
> we really used the right size for the varargs. Maybe append a single
> %d
> arg with a unique bit pattern to all of them?
>
> Otherwise ok.
Good idea. In the following I did it by adding 0x12345678 as a
successor argument to each test. I chose that bit pattern on the
grounds that each nybble is unique and non-zero.
I printed them with %x to make it easier (I hope) to track down
problems.
Successfully bootstrapped®rtested on x86_64-pc-linux-gnu.
OK for trunk?
gcc/ChangeLog:
* pretty-print.c: Include "selftest.h".
(pp_format): Fix comment.
(identifier_to_locale): Likewise.
(selftest::test_basic_printing): New function.
(selftest::assert_pp_format): New function.
(selftest::test_pp_format): New function.
(selftest::pretty_print_c_tests): New function.
* selftest-run-tests.c (selftest::run_tests): Call
selftest::pretty_print_c_tests.
* selftest.h (pretty_print_c_tests): New declaration.
---
gcc/pretty-print.c | 164 ++++++++++++++++++++++++++++++++++++++++++++++-
gcc/selftest-run-tests.c | 1 +
gcc/selftest.h | 1 +
3 files changed, 165 insertions(+), 1 deletion(-)
diff --git a/gcc/pretty-print.c b/gcc/pretty-print.c
index cc2b8cc..d805da4 100644
--- a/gcc/pretty-print.c
+++ b/gcc/pretty-print.c
@@ -24,6 +24,7 @@ along with GCC; see the file COPYING3. If not see
#include "intl.h"
#include "pretty-print.h"
#include "diagnostic-color.h"
+#include "selftest.h"
#if HAVE_ICONV
#include <iconv.h>
@@ -304,7 +305,7 @@ pp_indent (pretty_printer *pp)
/* Formatting phases 1 and 2: render TEXT->format_spec plus
TEXT->args_ptr into a series of chunks in pp_buffer (PP)->args[].
- Phase 3 is in pp_format_text. */
+ Phase 3 is in pp_output_formatted_text. */
void
pp_format (pretty_printer *pp, text_info *text)
@@ -1203,3 +1204,164 @@ identifier_to_locale (const char *ident)
return ret;
}
}
+
+#if CHECKING_P
+
+namespace selftest {
+
+/* Smoketest for pretty_printer. */
+
+static void
+test_basic_printing ()
+{
+ pretty_printer pp;
+ pp_string (&pp, "hello");
+ pp_space (&pp);
+ pp_string (&pp, "world");
+
+ ASSERT_STREQ ("hello world", pp_formatted_text (&pp));
+}
+
+/* Helper function for testing pp_format.
+ Verify that pp_format (FMT, ...) followed by pp_output_formatted_text
+ prints EXPECTED, assuming that pp_show_color is SHOW_COLOR. */
+
+static void
+assert_pp_format_va (const char *expected, bool show_color, const char *fmt,
+ va_list *ap)
+{
+ pretty_printer pp;
+ text_info ti;
+ rich_location rich_loc (line_table, UNKNOWN_LOCATION);
+
+ ti.format_spec = fmt;
+ ti.args_ptr = ap;
+ ti.err_no = 0;
+ ti.x_data = NULL;
+ ti.m_richloc = &rich_loc;
+
+ pp_show_color (&pp) = show_color;
+ pp_format (&pp, &ti);
+ pp_output_formatted_text (&pp);
+ ASSERT_STREQ (expected, pp_formatted_text (&pp));
+}
+
+/* Verify that pp_format (FMT, ...) followed by pp_output_formatted_text
+ prints EXPECTED, with show_color disabled. */
+
+static void
+assert_pp_format (const char *expected, const char *fmt, ...)
+{
+ va_list ap;
+
+ va_start (ap, fmt);
+ assert_pp_format_va (expected, false, fmt, &ap);
+ va_end (ap);
+}
+
+/* As above, but with colorization enabled. */
+
+static void
+assert_pp_format_colored (const char *expected, const char *fmt, ...)
+{
+ va_list ap;
+
+ va_start (ap, fmt);
+ assert_pp_format_va (expected, true, fmt, &ap);
+ va_end (ap);
+}
+
+/* Verify that pp_format works, for various format codes. */
+
+static void
+test_pp_format ()
+{
+ /* Avoid introducing locale-specific differences in the results
+ by hardcoding open_quote and close_quote. */
+ const char *old_open_quote = open_quote;
+ const char *old_close_quote = close_quote;
+ open_quote = "`";
+ close_quote = "'";
+
+ /* Verify that plain text is passed through unchanged. */
+ assert_pp_format ("unformatted", "unformatted");
+
+ /* Verify various individual format codes, in the order listed in the
+ comment for pp_format above. For each code, we append a second
+ argument with a known bit pattern (0x12345678), to ensure that we
+ are consuming arguments correctly. */
+ assert_pp_format ("-27 12345678", "%d %x", -27, 0x12345678);
+ assert_pp_format ("-5 12345678", "%i %x", -5, 0x12345678);
+ assert_pp_format ("10 12345678", "%u %x", 10, 0x12345678);
+ assert_pp_format ("17 12345678", "%o %x", 15, 0x12345678);
+ assert_pp_format ("cafebabe 12345678", "%x %x", 0xcafebabe, 0x12345678);
+ assert_pp_format ("-27 12345678", "%ld %x", (long)-27, 0x12345678);
+ assert_pp_format ("-5 12345678", "%li %x", (long)-5, 0x12345678);
+ assert_pp_format ("10 12345678", "%lu %x", (long)10, 0x12345678);
+ assert_pp_format ("17 12345678", "%lo %x", (long)15, 0x12345678);
+ assert_pp_format ("cafebabe 12345678", "%lx %x", (long)0xcafebabe,
+ 0x12345678);
+ assert_pp_format ("-27 12345678", "%lld %x", (long long)-27, 0x12345678);
+ assert_pp_format ("-5 12345678", "%lli %x", (long long)-5, 0x12345678);
+ assert_pp_format ("10 12345678", "%llu %x", (long long)10, 0x12345678);
+ assert_pp_format ("17 12345678", "%llo %x", (long long)15, 0x12345678);
+ assert_pp_format ("cafebabe 12345678", "%llx %x", (long long)0xcafebabe,
+ 0x12345678);
+ assert_pp_format ("-27 12345678", "%wd %x", (HOST_WIDE_INT)-27, 0x12345678);
+ assert_pp_format ("-5 12345678", "%wi %x", (HOST_WIDE_INT)-5, 0x12345678);
+ assert_pp_format ("10 12345678", "%wu %x", (unsigned HOST_WIDE_INT)10,
+ 0x12345678);
+ assert_pp_format ("17 12345678", "%wo %x", (HOST_WIDE_INT)15, 0x12345678);
+ assert_pp_format ("0xcafebabe 12345678", "%wx %x", (HOST_WIDE_INT)0xcafebabe,
+ 0x12345678);
+ assert_pp_format ("A 12345678", "%c %x", 'A', 0x12345678);
+ assert_pp_format ("hello world 12345678", "%s %x", "hello world",
+ 0x12345678);
+ assert_pp_format ("0xcafebabe 12345678", "%p %x", (void *)0xcafebabe,
+ 0x12345678);
+ assert_pp_format ("normal colored normal 12345678",
+ "normal %rcolored%R normal %x",
+ "error", 0x12345678);
+ /* The following assumes an empty value for GCC_COLORS. */
+ assert_pp_format_colored
+ ("normal \33[01;31m\33[Kcolored\33[m\33[K normal 12345678",
+ "normal %rcolored%R normal %x", "error", 0x12345678);
+ /* TODO:
+ %m: strerror(text->err_no) - does not consume a value from args_ptr. */
+ assert_pp_format ("% 12345678", "%% %x", 0x12345678);
+ assert_pp_format ("` 12345678", "%< %x", 0x12345678);
+ assert_pp_format ("' 12345678", "%> %x", 0x12345678);
+ assert_pp_format ("' 12345678", "%' %x", 0x12345678);
+ assert_pp_format ("abc 12345678", "%.*s %x", 3, "abcdef", 0x12345678);
+ assert_pp_format ("abc 12345678", "%.3s %x", "abcdef", 0x12345678);
+
+ /* Verify flag 'q'. */
+ assert_pp_format ("`foo' 12345678", "%qs %x", "foo", 0x12345678);
+ assert_pp_format_colored ("`\33[01m\33[Kfoo\33[m\33[K' 12345678", "%qs %x",
+ "foo", 0x12345678);
+
+ /* Verify that combinations work, along with unformatted text. */
+ assert_pp_format ("the quick brown fox jumps over the lazy dog",
+ "the %s %s %s jumps over the %s %s",
+ "quick", "brown", "fox", "lazy", "dog");
+ assert_pp_format ("item 3 of 7", "item %i of %i", 3, 7);
+ assert_pp_format ("problem with `bar' at line 10",
+ "problem with %qs at line %i", "bar", 10);
+
+ /* Restore old values of open_quote and close_quote. */
+ open_quote = old_open_quote;
+ close_quote = old_close_quote;
+}
+
+/* Run all of the selftests within this file. */
+
+void
+pretty_print_c_tests ()
+{
+ test_basic_printing ();
+ test_pp_format ();
+}
+
+} // namespace selftest
+
+#endif /* CHECKING_P */
diff --git a/gcc/selftest-run-tests.c b/gcc/selftest-run-tests.c
index 502eb4b..934e700 100644
--- a/gcc/selftest-run-tests.c
+++ b/gcc/selftest-run-tests.c
@@ -46,6 +46,7 @@ selftest::run_tests ()
hash_map_tests_c_tests ();
hash_set_tests_c_tests ();
vec_c_tests ();
+ pretty_print_c_tests ();
wide_int_cc_tests ();
ggc_tests_c_tests ();
diff --git a/gcc/selftest.h b/gcc/selftest.h
index 1c89842..d1f8acc 100644
--- a/gcc/selftest.h
+++ b/gcc/selftest.h
@@ -51,6 +51,7 @@ extern void ggc_tests_c_tests ();
extern void hash_map_tests_c_tests ();
extern void hash_set_tests_c_tests ();
extern void input_c_tests ();
+extern void pretty_print_c_tests ();
extern void rtl_tests_c_tests ();
extern void spellcheck_c_tests ();
extern void tree_c_tests ();
--
1.8.5.3
next prev parent reply other threads:[~2016-06-08 0:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:02 [PATCH] Add selftest for pretty-print.c David Malcolm
2016-06-07 10:03 ` Bernd Schmidt
2016-06-08 0:30 ` David Malcolm [this message]
2016-06-08 9:22 ` [PATCH] Add selftest for pretty-print.c (v2) Bernd Schmidt
2016-06-09 12:21 David Edelsohn
2016-06-09 12:48 ` Bernd Schmidt
2016-06-09 13:02 ` David Edelsohn
2016-06-09 13:10 ` Jakub Jelinek
2016-06-09 13:30 ` David Edelsohn
2016-06-09 17:22 ` Jeff Law
2016-06-09 17:54 ` David Malcolm
2016-06-09 18:06 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465347379-43873-1-git-send-email-dmalcolm@redhat.com \
--to=dmalcolm@redhat.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).