From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89314 invoked by alias); 23 Jun 2016 14:32:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 89305 invoked by uid 89); 23 Jun 2016 14:32:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tabs, U*dmalcolm, sk:dmalcol, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jun 2016 14:32:03 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E609080F6B; Thu, 23 Jun 2016 14:32:01 +0000 (UTC) Received: from unused (unused [10.10.52.140] (may be forged)) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5NEW0MT014441; Thu, 23 Jun 2016 10:32:01 -0400 Message-ID: <1466692320.10682.27.camel@redhat.com> Subject: Re: [PATCH] Print column numbers in inclusion trace consistently. From: David Malcolm To: Jeff Law , Marcin =?UTF-8?Q?Baczy=C5=84ski?= , gcc-patches@gcc.gnu.org Date: Thu, 23 Jun 2016 14:32:00 -0000 In-Reply-To: <660a2078-5959-2518-a7fe-bb437b813791@redhat.com> References: <20160603112425.189703-1-marbacz@gmail.com> <660a2078-5959-2518-a7fe-bb437b813791@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg01686.txt.bz2 On Tue, 2016-06-21 at 21:09 -0600, Jeff Law wrote: > On 06/03/2016 05:24 AM, Marcin Baczyński wrote: > > Hi, > > the patch below fixes PR/42014. Although the fix itself seems easy > > enough, > > I have a problem with the test. Is there a way to match the output > > before > > the "warning:" line? dg-{begin,end}-multiline-output doesn't do the > > job, or > > at least I don't know how to convince it. > > > > Bootstrapped on x86_64 linux. > > > > Thanks, > > Marcin > > > > > > gcc/ChangeLog: > > > > PR/42014 > > > > * diagnostic.c (diagnostic_report_current_module): Print column > > numbers > > for all mentioned files if context->show_column. > > > > gcc/testsuite/ChangeLog: > > > > PR/42014 > > > > * gcc.dg/inclusion-trace-column.i: New test. > The change itself seems reasonable. You might contact David Malcolm > (dmalcolm@redhat.com) directly to see if he's got any ideas on how to > convince the multi-line test to do what you want. Let's hold off > installing the fix until we've got the testsuite issue sorted out. You could turn up the verbosity level to debug things, by running something like: make check-gcc RUNTESTFLAGS="-v -v -v -v dg.exp=inclusion-trace-column.i" (multiline.exp prints various things at verbosity level 3 and 4, iirc; in particular, it can show you the regexp it's looking for). Maybe a tabs vs spaces issue? Dave