[PATCH] Fix assembler arguments for -m16

[PATCH] Fix assembler arguments for -m16

[Roger Pau Monne]

At the moment the -m16 option only passes the "--32" parameter to the
assembler on glibc OSes, while on other OSes the assembler is called without
any specific flag. This is wrong and causes the assembler to fail. Fix it
by adding support for the -m16 option to x86-64.h.

2016-07-06  Roger Pau Monné  <roger.pau@citrix.com>

	* x86-64.h: append --32 to the assembler options when -m16 is used
	even on non-glibc OSes.

---
Cc: hjl@gcc.gnu.org
Cc: gerald@FreeBSD.org
---
This should be backported to all stable branches up to 4.9 (when -m16 was
introduced).

Please keep me on Cc since I'm not subscribed to the list, thanks.
---
 gcc/config/i386/x86-64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/i386/x86-64.h b/gcc/config/i386/x86-64.h
index b0bf835..9e6c6eb 100644
--- a/gcc/config/i386/x86-64.h
+++ b/gcc/config/i386/x86-64.h
@@ -49,7 +49,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
 #define WCHAR_TYPE_SIZE 32
 
 #undef ASM_SPEC
-#define ASM_SPEC "%{m32:--32} %{m64:--64} %{mx32:--x32}"
+#define ASM_SPEC "%{m16|m32:--32} %{m64:--64} %{mx32:--x32}"
 
 #undef ASM_OUTPUT_ALIGNED_BSS
 #define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \
-- 
2.7.4 (Apple Git-66)

Re: [PATCH] Fix assembler arguments for -m16

[Roger Pau Monne]

On Wed, Jul 06, 2016 at 04:18:49PM +0200, Roger Pau Monne wrote:
> At the moment the -m16 option only passes the "--32" parameter to the
> assembler on glibc OSes, while on other OSes the assembler is called without
> any specific flag. This is wrong and causes the assembler to fail. Fix it
> by adding support for the -m16 option to x86-64.h.
> 
> 2016-07-06  Roger Pau Monné  <roger.pau@citrix.com>
> 
> 	* x86-64.h: append --32 to the assembler options when -m16 is used
> 	even on non-glibc OSes.
> 
> ---
> Cc: hjl@gcc.gnu.org
> Cc: gerald@FreeBSD.org
> ---
> This should be backported to all stable branches up to 4.9 (when -m16 was
> introduced).
> 
> Please keep me on Cc since I'm not subscribed to the list, thanks.

Ping?

Roger.

Re: [PATCH] Fix assembler arguments for -m16

[Roger Pau Monne]

On Wed, Jul 20, 2016 at 06:31:57PM +0200, Roger Pau Monne wrote:
> On Wed, Jul 06, 2016 at 04:18:49PM +0200, Roger Pau Monne wrote:
> > At the moment the -m16 option only passes the "--32" parameter to the
> > assembler on glibc OSes, while on other OSes the assembler is called without
> > any specific flag. This is wrong and causes the assembler to fail. Fix it
> > by adding support for the -m16 option to x86-64.h.
> > 
> > 2016-07-06  Roger Pau Monné  <roger.pau@citrix.com>
> > 
> > 	* x86-64.h: append --32 to the assembler options when -m16 is used
> > 	even on non-glibc OSes.
> > 
> > ---
> > Cc: hjl@gcc.gnu.org
> > Cc: gerald@FreeBSD.org
> > ---
> > This should be backported to all stable branches up to 4.9 (when -m16 was
> > introduced).
> > 
> > Please keep me on Cc since I'm not subscribed to the list, thanks.
> 
> Ping?

Ping x2. Is there anything I'm missing in order to get this reviewed?

Roger.

Re: [PATCH] Fix assembler arguments for -m16

[Roger Pau Monne]

On Mon, Aug 08, 2016 at 05:28:29PM +0200, Roger Pau Monne wrote:
> On Wed, Jul 20, 2016 at 06:31:57PM +0200, Roger Pau Monne wrote:
> > On Wed, Jul 06, 2016 at 04:18:49PM +0200, Roger Pau Monne wrote:
> > > At the moment the -m16 option only passes the "--32" parameter to the
> > > assembler on glibc OSes, while on other OSes the assembler is called without
> > > any specific flag. This is wrong and causes the assembler to fail. Fix it
> > > by adding support for the -m16 option to x86-64.h.
> > > 
> > > 2016-07-06  Roger Pau Monné  <roger.pau@citrix.com>
> > > 
> > > 	* x86-64.h: append --32 to the assembler options when -m16 is used
> > > 	even on non-glibc OSes.
> > > 
> > > ---
> > > Cc: hjl@gcc.gnu.org
> > > Cc: gerald@FreeBSD.org
> > > ---
> > > This should be backported to all stable branches up to 4.9 (when -m16 was
> > > introduced).
> > > 
> > > Please keep me on Cc since I'm not subscribed to the list, thanks.
> > 
> > Ping?
> 
> Ping x2. Is there anything I'm missing in order to get this reviewed?
> 

And yet another ping (x3).

Thanks, Roger.

Re: [PATCH] Fix assembler arguments for -m16

[Gerald Pfeifer]

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]

It appears this got stuck.

Uros, is this okay?  I can handle the commit if you approve.

Gerald

On Wed, 6 Jul 2016, Roger Pau Monne wrote:
> At the moment the -m16 option only passes the "--32" parameter to the
> assembler on glibc OSes, while on other OSes the assembler is called without
> any specific flag. This is wrong and causes the assembler to fail. Fix it
> by adding support for the -m16 option to x86-64.h.
> 
> 2016-07-06  Roger Pau Monné  <roger.pau@citrix.com>
> 
> 	* x86-64.h: append --32 to the assembler options when -m16 is used
> 	even on non-glibc OSes.
> 
> ---
> Cc: hjl@gcc.gnu.org
> Cc: gerald@FreeBSD.org
> ---
> This should be backported to all stable branches up to 4.9 (when -m16 was
> introduced).
> 
> Please keep me on Cc since I'm not subscribed to the list, thanks.
> ---
>  gcc/config/i386/x86-64.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/config/i386/x86-64.h b/gcc/config/i386/x86-64.h
> index b0bf835..9e6c6eb 100644
> --- a/gcc/config/i386/x86-64.h
> +++ b/gcc/config/i386/x86-64.h
> @@ -49,7 +49,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
>  #define WCHAR_TYPE_SIZE 32
>  
>  #undef ASM_SPEC
> -#define ASM_SPEC "%{m32:--32} %{m64:--64} %{mx32:--x32}"
> +#define ASM_SPEC "%{m16|m32:--32} %{m64:--64} %{mx32:--x32}"
>  
>  #undef ASM_OUTPUT_ALIGNED_BSS
>  #define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \

Re: [PATCH] Fix assembler arguments for -m16

[Uros Bizjak]

On Sun, Nov 6, 2016 at 5:48 PM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> It appears this got stuck.
>
> Uros, is this okay?  I can handle the commit if you approve.

Looks good to me, so OK if tested on non-glibc system.

Thanks,
Uros.

> Gerald
>
> On Wed, 6 Jul 2016, Roger Pau Monne wrote:
>> At the moment the -m16 option only passes the "--32" parameter to the
>> assembler on glibc OSes, while on other OSes the assembler is called without
>> any specific flag. This is wrong and causes the assembler to fail. Fix it
>> by adding support for the -m16 option to x86-64.h.
>>
>> 2016-07-06  Roger Pau Monné  <roger.pau@citrix.com>
>>
>>       * x86-64.h: append --32 to the assembler options when -m16 is used
>>       even on non-glibc OSes.
>>
>> ---
>> Cc: hjl@gcc.gnu.org
>> Cc: gerald@FreeBSD.org
>> ---
>> This should be backported to all stable branches up to 4.9 (when -m16 was
>> introduced).
>>
>> Please keep me on Cc since I'm not subscribed to the list, thanks.
>> ---
>>  gcc/config/i386/x86-64.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/config/i386/x86-64.h b/gcc/config/i386/x86-64.h
>> index b0bf835..9e6c6eb 100644
>> --- a/gcc/config/i386/x86-64.h
>> +++ b/gcc/config/i386/x86-64.h
>> @@ -49,7 +49,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
>>  #define WCHAR_TYPE_SIZE 32
>>
>>  #undef ASM_SPEC
>> -#define ASM_SPEC "%{m32:--32} %{m64:--64} %{mx32:--x32}"
>> +#define ASM_SPEC "%{m16|m32:--32} %{m64:--64} %{mx32:--x32}"
>>
>>  #undef ASM_OUTPUT_ALIGNED_BSS
>>  #define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \

Re: [PATCH] Fix assembler arguments for -m16

[Andreas Tobler]

On 06.11.16 21:38, Uros Bizjak wrote:
> On Sun, Nov 6, 2016 at 5:48 PM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
>> It appears this got stuck.
>>
>> Uros, is this okay?  I can handle the commit if you approve.
>
> Looks good to me, so OK if tested on non-glibc system.


Results w/o patch:
https://gcc.gnu.org/ml/gcc-testresults/2016-11/msg00627.html

Results with patch:
https://gcc.gnu.org/ml/gcc-testresults/2016-11/msg00672.html

Andreas
>
> Thanks,
> Uros.
>
>> Gerald
>>
>> On Wed, 6 Jul 2016, Roger Pau Monne wrote:
>>> At the moment the -m16 option only passes the "--32" parameter to the
>>> assembler on glibc OSes, while on other OSes the assembler is called without
>>> any specific flag. This is wrong and causes the assembler to fail. Fix it
>>> by adding support for the -m16 option to x86-64.h.
>>>
>>> 2016-07-06  Roger Pau Monné  <roger.pau@citrix.com>
>>>
>>>       * x86-64.h: append --32 to the assembler options when -m16 is used
>>>       even on non-glibc OSes.
>>>
>>> ---
>>> Cc: hjl@gcc.gnu.org
>>> Cc: gerald@FreeBSD.org
>>> ---
>>> This should be backported to all stable branches up to 4.9 (when -m16 was
>>> introduced).
>>>
>>> Please keep me on Cc since I'm not subscribed to the list, thanks.
>>> ---
>>>  gcc/config/i386/x86-64.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/gcc/config/i386/x86-64.h b/gcc/config/i386/x86-64.h
>>> index b0bf835..9e6c6eb 100644
>>> --- a/gcc/config/i386/x86-64.h
>>> +++ b/gcc/config/i386/x86-64.h
>>> @@ -49,7 +49,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
>>>  #define WCHAR_TYPE_SIZE 32
>>>
>>>  #undef ASM_SPEC
>>> -#define ASM_SPEC "%{m32:--32} %{m64:--64} %{mx32:--x32}"
>>> +#define ASM_SPEC "%{m16|m32:--32} %{m64:--64} %{mx32:--x32}"
>>>
>>>  #undef ASM_OUTPUT_ALIGNED_BSS
>>>  #define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \
>

Re: [PATCH] Fix assembler arguments for -m16

[Gerald Pfeifer]

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

On Sun, 6 Nov 2016, Uros Bizjak wrote:
> Looks good to me, so OK if tested on non-glibc system.

Thanks, Uros!

Turns out at least in my testing our testsuite is a little non- 
deterministic :-(, but after tests without the patch, with the 
patch, again with the patch, and without the patch again on 
x86_64-unknown-freebsd11.0

   https://gcc.gnu.org/ml/gcc-testresults/2016-12/msg01191.html
   https://gcc.gnu.org/ml/gcc-testresults/2016-12/msg01197.html
   https://gcc.gnu.org/ml/gcc-testresults/2016-12/msg01218.html
   https://gcc.gnu.org/ml/gcc-testresults/2016-12/msg01224.html

I am sufficiently confident none of that noise is related to this patch
and committed it for Roger.  (Thanks again, Roger!)


Uros, okay to also push to the GCC 6 branch for the coming release
and later the GCC 5 branch as well?  For reference, the committed
patch below.

Gerald


2016-12-11  Roger Pau Monné  <roger.pau@citrix.com>

	* config/i386/x86-64.h: Append --32 to the assembler options when
	-m16 is used on non-glibc systems as well.

Index: config/i386/x86-64.h
===================================================================
--- config/i386/x86-64.h	(revision 243527)
+++ config/i386/x86-64.h	(working copy)
@@ -49,7 +49,7 @@
 #define WCHAR_TYPE_SIZE 32
 
 #undef ASM_SPEC
-#define ASM_SPEC "%{m32:--32} %{m64:--64} %{mx32:--x32}"
+#define ASM_SPEC "%{m16|m32:--32} %{m64:--64} %{mx32:--x32}"
 
 #undef ASM_OUTPUT_ALIGNED_BSS
 #define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \

Re: [PATCH] Fix assembler arguments for -m16

[Gerald Pfeifer]

On Mon, 7 Nov 2016, Andreas Tobler wrote:
> Results w/o patch:
> https://gcc.gnu.org/ml/gcc-testresults/2016-11/msg00627.html
> 
> Results with patch:
> https://gcc.gnu.org/ml/gcc-testresults/2016-11/msg00672.html

Thanks, Andreas, quite useful.

For reference, the reason I did not go ahead with the patch right
away, but did some more testing are those non-deterministic (at
least on FreeBSD) tests we've got:

In your testing, the patch "changed" the following:

  -FAIL: c-c++-common/cilk-plus/CK/nested_cilk_for.c  -O2 -std=c99  execution test
  +FAIL: c-c++-common/cilk-plus/CK/fib.c  -g  execution test
  -FAIL: 22_locale/locale/cons/12658_thread-1.cc execution test

The first two I've never seen, 22_locale/locale/cons/12658_thread-1.cc 
actually went the other direction (from PASS to FAIL) in my original 
tests.

So, at least on FreeBSD 22_locale/locale/cons/12658_thread-1.cc pretty
much is useful and pretty much random.

Gerald

[PING] Re: [PATCH] Fix assembler arguments for -m16

[Gerald Pfeifer]

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

I'd like to ping this patch for GCC 6 (and GCC 5).

Gerald

On Sun, 11 Dec 2016, Gerald Pfeifer wrote:
> Uros, okay to also push to the GCC 6 branch for the coming release
> and later the GCC 5 branch as well?  For reference, the committed
> patch below.
> 
> Gerald
> 
> 
> 2016-12-11  Roger Pau Monné  <roger.pau@citrix.com>
> 
> 	* config/i386/x86-64.h: Append --32 to the assembler options when
> 	-m16 is used on non-glibc systems as well.
> 
> Index: config/i386/x86-64.h
> ===================================================================
> --- config/i386/x86-64.h	(revision 243527)
> +++ config/i386/x86-64.h	(working copy)
> @@ -49,7 +49,7 @@
>  #define WCHAR_TYPE_SIZE 32
>  
>  #undef ASM_SPEC
> -#define ASM_SPEC "%{m32:--32} %{m64:--64} %{mx32:--x32}"
> +#define ASM_SPEC "%{m16|m32:--32} %{m64:--64} %{mx32:--x32}"
>  
>  #undef ASM_OUTPUT_ALIGNED_BSS
>  #define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \

Re: [PING] Re: [PATCH] Fix assembler arguments for -m16

[Uros Bizjak]

On Sun, Feb 12, 2017 at 4:27 PM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> I'd like to ping this patch for GCC 6 (and GCC 5).
>
> Gerald
>
> On Sun, 11 Dec 2016, Gerald Pfeifer wrote:
>> Uros, okay to also push to the GCC 6 branch for the coming release
>> and later the GCC 5 branch as well?  For reference, the committed
>> patch below.

OK.

Thanks,
Uros.

>> Gerald
>>
>>
>> 2016-12-11  Roger Pau Monné  <roger.pau@citrix.com>
>>
>>       * config/i386/x86-64.h: Append --32 to the assembler options when
>>       -m16 is used on non-glibc systems as well.
>>
>> Index: config/i386/x86-64.h
>> ===================================================================
>> --- config/i386/x86-64.h      (revision 243527)
>> +++ config/i386/x86-64.h      (working copy)
>> @@ -49,7 +49,7 @@
>>  #define WCHAR_TYPE_SIZE 32
>>
>>  #undef ASM_SPEC
>> -#define ASM_SPEC "%{m32:--32} %{m64:--64} %{mx32:--x32}"
>> +#define ASM_SPEC "%{m16|m32:--32} %{m64:--64} %{mx32:--x32}"
>>
>>  #undef ASM_OUTPUT_ALIGNED_BSS
>>  #define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \