From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B684C385E00E for ; Wed, 24 Jan 2024 17:33:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B684C385E00E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B684C385E00E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706117640; cv=none; b=mQ8S+MxDfKg12dbFLxvliF4C8LgMLBBj/889GfLPY4qBxPbLTipc+wMWARt3Yb0qwGsJQ8+5oUehOlabxRUHPG5KWgDbIJGCw38kH4+ILE27/eTemKOVSxlDWXf9ApI6/obkHCeTLndNz+OKW1h9jMiQYirvxgbkH2RUNOXqV78= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706117640; c=relaxed/simple; bh=Y7CUQzD7adtCZQkShN9kSmsRCksQJDbaRWFENyJoGL8=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=PbK2HpvU7/THBkd/t8u7CqLPOqnONn/sFr+Ci3UVEUy4ExDoaAwkfdZsV3K1Ed53FU4VT0K4iYdUuDwCad2ko7NBI6cQ0E+s45/wb/jma/NaGRqkrqqLcNS6Il5I9dAgzLKpjjntBtWlDl3pMeWJXS7JBCcl5D5QiT5hrkZRZyw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706117637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dNTPXPqmtzlmlEuaFvqz95sbkTQhA4X6kU3BF2LfNcU=; b=bZcREEPMKQD/TMW3minf0v2WNQ9rUpCwfv866diIaljxbO7U/FY/6g8r3JanZzrVDS4b+7 6TSo0Au14fCkXj4/OJlv0HQC5jnzp+3z0W1N4gsQqmHs7fMeD1CqspDyWMK/uJbA9nOQJo p/ADef9gw6mwj4BJuedASfunhc9fzKI= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-YcdqPmgLNbqmHZVjpT_kLw-1; Wed, 24 Jan 2024 12:33:56 -0500 X-MC-Unique: YcdqPmgLNbqmHZVjpT_kLw-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-783b8600f38so56372885a.0 for ; Wed, 24 Jan 2024 09:33:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706117635; x=1706722435; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dNTPXPqmtzlmlEuaFvqz95sbkTQhA4X6kU3BF2LfNcU=; b=ko4jZgHuXB0svO7UccwJ0aQoo9iVgxyMzv4SfN5cO4ciVr3/WZwV+/bv4Vmp9gH8o9 s4b8YBiNW+/Uu3Fn9RX5H9RGi/H0JM945QdgTaak/nj6Sb0j8gJmEQGk5rD2+YFq6thT U5VlXF0zp2bnWitoJ4wYm83H0ewLnS1KF5kaRa86hHlzl055ogmQ0xmt+XXo7sKAYXpP 2daDTSKlSuB+lX4A91jIjEJt/7eZ71XzaC4lu5kTwElfgZNbx6BC/afLV7Xb6Ywfb1Wh 13apsf8G8OWkqjqnK9RE5j7Avj+kuYnj2e2c1dnV/YSwTRkeuLqlrYejnqrBiLglCB1m 4aLQ== X-Gm-Message-State: AOJu0YwUbv9ZoePJB2ayaozuLk7BWE7V26cxME7xmAPz/oW1SS4j8Ptp PpP5+fKg0lQzkuGuaobLAcoKOhOIzftO639Ew4DplHrwEQ0MQamnwXL8mfBRsf/XCYiUDcZQnIJ 30kbSP05xvyKHApAjktP/64g6Y1slQRpLStNYvDB2cz59WAvsAsvkfcn4DDcsavU= X-Received: by 2002:ae9:f506:0:b0:783:2c45:2825 with SMTP id o6-20020ae9f506000000b007832c452825mr7895162qkg.93.1706117635010; Wed, 24 Jan 2024 09:33:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHftN3RpJHxJ49vA2di/rrbyDFSEYSBy8R+pboaFk3nW84QC4sF11qN53mTducbtFqHDfwGBQ== X-Received: by 2002:ae9:f506:0:b0:783:2c45:2825 with SMTP id o6-20020ae9f506000000b007832c452825mr7895158qkg.93.1706117634811; Wed, 24 Jan 2024 09:33:54 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id j26-20020a05620a001a00b00783b6da58a9sm538723qki.39.2024.01.24.09.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 09:33:54 -0800 (PST) Message-ID: <14705a2385028450967d25cb6387892d2946393e.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Add convert vector From: David Malcolm To: Antoni Boucher , "jit@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Date: Wed, 24 Jan 2024 12:33:53 -0500 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-12-21 at 16:01 -0500, Antoni Boucher wrote: > Hi. > This patch adds the support for the convert vector internal function. Thanks for the patch. > I'll need to double-check that making the decl a register is > necessary. I confess I don't know anything about this aspect of the patch, but presumably you have this working within the rustc backend as well as in the testcase. Am I right in thinking that this is an elementwise conversion? Might be good to specify this in the docs and header file. Otherwise looks good to me (with usual comment about updating the ABI numbering as necessary) Thanks Dave