public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/5] Makefile.in: Ensure build CPP/CPPFLAGS is used for build targets
Date: Thu, 28 Oct 2021 08:43:53 -0600	[thread overview]
Message-ID: <14729289-0fec-303d-50aa-986430178b5e@gmail.com> (raw)
In-Reply-To: <CAFiYyc2CyMS-pvBJyFinTovU1Se6_5_yiAcHo3b_C=5nU8g=Gw@mail.gmail.com>



On 10/28/2021 1:04 AM, Richard Biener via Gcc-patches wrote:
> On Wed, Oct 27, 2021 at 10:10 PM Richard Purdie via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>> During cross compiling, CPP is being set to the target compiler even for
>> build targets. As an example, when building a cross compiler targetting
>> mingw, the config.log for libiberty in
>> build.x86_64-pokysdk-mingw32.i586-poky-linux/build-x86_64-linux/libiberty/config.log
>> shows:
>>
>> configure:3786: checking how to run the C preprocessor
>> configure:3856: result: x86_64-pokysdk-mingw32-gcc -E --sysroot=[sysroot]/x86_64-nativesdk-mingw32-pokysdk-mingw32
>> configure:3876: x86_64-pokysdk-mingw32-gcc -E --sysroot=[sysroot]/x86_64-nativesdk-mingw32-pokysdk-mingw32 conftest.c
>> configure:3876: $? = 0
>>
>> This is libiberty being built for the build environment, not the target one
>> (i.e. in build-x86_64-linux). As such it should be using the build environment's
>> gcc and not the target one. In the mingw case the system headers are quite
>> different leading to build failures related to not being able to include a
>> process.h file for pem-unix.c.
>>
>> Further analysis shows the same issue occuring for CPPFLAGS too.
>>
>> Fix this by adding support for CPP_FOR_BUILD and CPPFLAGS_FOR_BUILD which
>> for example, avoids mixing the mingw headers for host binaries on linux
>> systems.
> OK.
I don't think Richard P. has write access, so I went ahead and pushed 
this to the trunk.

jeff


  reply	other threads:[~2021-10-28 14:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 20:05 [PATCH 0/5] OpenEmbedded/Yocto Project gcc patches Richard Purdie
2021-10-27 20:05 ` [PATCH 1/5] Makefile.in: Ensure build CPP/CPPFLAGS is used for build targets Richard Purdie
2021-10-28  7:04   ` Richard Biener
2021-10-28 14:43     ` Jeff Law [this message]
2021-10-27 20:05 ` [PATCH 2/5] gcc: Fix "argument list too long" from install-plugins Richard Purdie
2021-10-27 20:54   ` Bernhard Reutner-Fischer
2021-12-03  3:01   ` Jeff Law
2021-10-27 20:05 ` [PATCH 3/5] gcc: Add --nostdlib++ option Richard Purdie
2021-10-27 20:56   ` Bernhard Reutner-Fischer
2021-10-28 16:41     ` Richard Purdie
2021-12-03  3:05       ` Jeff Law
2021-10-28 14:51   ` Jeff Law
2021-10-28 16:39     ` Richard Purdie
2021-12-03  3:04       ` Jeff Law
2021-12-05 11:43         ` Richard Purdie
2021-12-06  6:10           ` Fāng-ruì Sòng
2021-10-27 20:05 ` [PATCH 4/5] gcc/nios2: Define the musl linker Richard Purdie
2021-10-28 14:46   ` Jeff Law
2021-10-27 20:05 ` [PATCH 5/5] gcc: Pass sysroot options to cpp for preprocessed source Richard Purdie
2021-12-14 23:47   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14729289-0fec-303d-50aa-986430178b5e@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).