public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Torvald Riegel <triegel@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: nd <nd@arm.com>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 3/4][PR 71931] Fix libitm tests
Date: Tue, 06 Sep 2016 09:12:00 -0000	[thread overview]
Message-ID: <1473153065.20286.30.camel@localhost.localdomain> (raw)
In-Reply-To: <57BDF0BA.5070303@arm.com>

On Wed, 2016-08-24 at 20:08 +0100, Szabolcs Nagy wrote:
> Pass build time CC make var down to dejagnu so the sysroot
> is set correctly when gcc is built with --with-build-sysroot.
> 
> libitm/
> 2016-08-24  Szabolcs Nagy  <szabolcs.nagy@arm.com>
> 
> 	PR testsuite/71931
> 	* configure.ac: Add AC_CONFIG_FILES.
> 	* configure: Regenerated.
> 	* testuite/Makefile.am: Add rule for libitm-test-support.exp.
> 	* testuite/Makefile.in: Regenerated.
> 	* testuite/libitm-test-support.exp.in: New.
> 	* testuite/lib/libitm.exp (libitm_init): Use BUILD_CC.
> 

I don't know enough about the build system to really review this.  If a
similar patch has been ACKed and applied for libatomic (71931 states
that both are affected), then I guess this is OK?

  reply	other threads:[~2016-09-06  9:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 19:04 [PATCH 0/4][PR 71931] Fix target lib tests --with-build-sysroot Szabolcs Nagy
2016-08-24 19:06 ` [PATCH 1/4][PR 71931] Fix libatomic tests Szabolcs Nagy
2016-08-24 22:08   ` Joseph Myers
2016-08-25  8:45     ` Szabolcs Nagy
2016-08-25 23:04       ` Joseph Myers
2016-08-24 19:07 ` [PATCH 2/4][PR 71931] Fix libgomp tests Szabolcs Nagy
2016-08-24 19:09 ` [PATCH 3/4][PR 71931] Fix libitm tests Szabolcs Nagy
2016-09-06  9:12   ` Torvald Riegel [this message]
2016-09-06 18:06     ` Mike Stump
2016-09-06 18:49       ` Szabolcs Nagy
2016-09-06 20:26         ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473153065.20286.30.camel@localhost.localdomain \
    --to=triegel@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).