public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [committed] Fix gcc.dg/tree-ssa/builtin-sprintf-warn-4.c
Date: Fri, 23 Sep 2016 17:14:00 -0000	[thread overview]
Message-ID: <1474650110.23088.58.camel@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

My fix to the locations for NUL-terminators in substring_loc changed
the output for gcc.dg/tree-ssa/builtin-sprintf-warn-4.c, leading to a
couple of FAILs from that test.  Sorry; my testing of the earlier patch
was incomplete (I needed to rebase).

I've committed the attached patch to trunk (r240442), which fixes the
test failures.

[-- Attachment #2: r240442.patch --]
[-- Type: text/x-patch, Size: 1195 bytes --]

Index: gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-4.c
===================================================================
--- gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-4.c	(revision 240441)
+++ gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-4.c	(revision 240442)
@@ -12,7 +12,7 @@
      { dg-message "format output 2 bytes into a destination of size 1" "" { target *-*-*-* } 10 }
      { dg-begin-multiline-output "" }
    sprintf (dst + 7, "%-s", "1");
-                     ^~~~~
+                      ~~^~
      { dg-end-multiline-output "" }
      { dg-begin-multiline-output "" }
    sprintf (dst + 7, "%-s", "1");
Index: gcc/testsuite/ChangeLog
===================================================================
--- gcc/testsuite/ChangeLog	(revision 240441)
+++ gcc/testsuite/ChangeLog	(revision 240442)
@@ -1,3 +1,10 @@
+2016-09-23  David Malcolm  <dmalcolm@redhat.com>
+
+	PR preprocessor/77672
+	* gcc.dg/tree-ssa/builtin-sprintf-warn-4.c (test): Update
+	expected multiline output from first warning to reflect change
+	in r240434.
+
 2016-09-23  Thomas Preud'homme  <thomas.preudhomme@arm.com>
 
 	* gcc.dg/tree-ssa/builtin-sprintf-warn-2.c: Fix xfail pattern.

                 reply	other threads:[~2016-09-23 17:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474650110.23088.58.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).