From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59780 invoked by alias); 30 Sep 2016 13:54:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59760 invoked by uid 89); 30 Sep 2016 13:54:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=UD:!global_options_set.x_TARGET_COMPACT_CASESI, compactcasesi, UD:x_TARGET_COMPACT_CASESI, compact-casesi X-HELO: smtprelay.synopsys.com Received: from smtprelay2.synopsys.com (HELO smtprelay.synopsys.com) (198.182.60.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Sep 2016 13:54:04 +0000 Received: from us02secmta2.synopsys.com (us02secmta2.synopsys.com [10.12.235.98]) by smtprelay.synopsys.com (Postfix) with ESMTP id 8D87510C174A; Fri, 30 Sep 2016 06:54:00 -0700 (PDT) Received: from us02secmta2.internal.synopsys.com (us02secmta2.internal.synopsys.com [127.0.0.1]) by us02secmta2.internal.synopsys.com (Service) with ESMTP id 5C40C55F13; Fri, 30 Sep 2016 06:54:00 -0700 (PDT) Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by us02secmta2.internal.synopsys.com (Service) with ESMTP id 3792055F02; Fri, 30 Sep 2016 06:54:00 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 1ADA84A0; Fri, 30 Sep 2016 06:54:00 -0700 (PDT) Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) by mailhost.synopsys.com (Postfix) with ESMTP id E4654488; Fri, 30 Sep 2016 06:53:59 -0700 (PDT) Received: from IN01WEHTCA.internal.synopsys.com (10.144.199.104) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.266.1; Fri, 30 Sep 2016 06:53:28 -0700 Received: from IN01WEHTCB.internal.synopsys.com (10.144.199.105) by IN01WEHTCA.internal.synopsys.com (10.144.199.103) with Microsoft SMTP Server (TLS) id 14.3.266.1; Fri, 30 Sep 2016 19:23:25 +0530 Received: from nl20droid1.internal.synopsys.com (10.100.24.228) by IN01WEHTCB.internal.synopsys.com (10.144.199.243) with Microsoft SMTP Server (TLS) id 14.3.266.1; Fri, 30 Sep 2016 19:23:25 +0530 From: Claudiu Zissulescu To: , CC: Subject: Re:[PATCH] [ARC] Disable compact casesi patterns for arcv2 Date: Fri, 30 Sep 2016 14:36:00 -0000 Message-ID: <1475243523-12183-1-git-send-email-claziss@synopsys.com> In-Reply-To: <20160929192616.GF18222@embecosm.com> References: <20160929192616.GF18222@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-09/txt/msg02367.txt.bz2 Please find the updated patch, Claudiu gcc/ 2016-05-09 Claudiu Zissulescu * common/config/arc/arc-common.c (arc_option_optimization_table): Remove compact casesi option. * config/arc/arc.c (arc_override_options): Use compact casesi option only for pre-ARCv2 cores. * doc/invoke.texi (mcompact-casesi): Update text. --- gcc/common/config/arc/arc-common.c | 1 - gcc/config/arc/arc.c | 11 +++++++++++ gcc/doc/invoke.texi | 4 ++-- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/gcc/common/config/arc/arc-common.c b/gcc/common/config/arc/arc-common.c index f5b9c6d..5b687fb 100644 --- a/gcc/common/config/arc/arc-common.c +++ b/gcc/common/config/arc/arc-common.c @@ -56,7 +56,6 @@ static const struct default_options arc_option_optimization_table[] = { OPT_LEVELS_ALL, OPT_mbbit_peephole, NULL, 1 }, { OPT_LEVELS_SIZE, OPT_mq_class, NULL, 1 }, { OPT_LEVELS_SIZE, OPT_mcase_vector_pcrel, NULL, 1 }, - { OPT_LEVELS_SIZE, OPT_mcompact_casesi, NULL, 1 }, { OPT_LEVELS_NONE, 0, NULL, 0 } }; diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c index 2b25b0b..5e8d6b4 100644 --- a/gcc/config/arc/arc.c +++ b/gcc/config/arc/arc.c @@ -858,6 +858,17 @@ arc_override_options (void) if (arc_size_opt_level == 3) optimize_size = 1; + /* Compact casesi is not a valid option for ARCv2 family. */ + if (TARGET_V2 + && TARGET_COMPACT_CASESI) + { + warning (0, "compact-casesi is not applicable to ARCv2"); + TARGET_COMPACT_CASESI = 0; + } + else if (optimize_size == 1 + && !global_options_set.x_TARGET_COMPACT_CASESI) + TARGET_COMPACT_CASESI = 1; + if (flag_pic) target_flags |= MASK_NO_SDATA_SET; diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 6767462..05f565d 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -14255,8 +14255,8 @@ This is the default for @option{-Os}. @item -mcompact-casesi @opindex mcompact-casesi -Enable compact casesi pattern. -This is the default for @option{-Os}. +Enable compact casesi pattern. This is the default for @option{-Os}, +and only available for ARCv1 cores. @item -mno-cond-exec @opindex mno-cond-exec -- 1.9.1