From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46710 invoked by alias); 3 Feb 2017 14:03:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46691 invoked by uid 89); 3 Feb 2017 14:02:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=website, couch X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Feb 2017 14:02:58 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3D7438123E; Fri, 3 Feb 2017 14:02:58 +0000 (UTC) Received: from vpn-233-73.phx2.redhat.com (vpn-233-73.phx2.redhat.com [10.3.233.73]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v13E2vme007305; Fri, 3 Feb 2017 09:02:57 -0500 Message-ID: <1486130576.9007.5.camel@redhat.com> Subject: Re: [wwwdocs] Mention GIMPLE and RTL frontends in changes.html From: David Malcolm To: Gerald Pfeifer Cc: gcc-patches@gcc.gnu.org Date: Fri, 03 Feb 2017 14:03:00 -0000 In-Reply-To: References: <1486072397.9007.3.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00267.txt.bz2 On Fri, 2017-02-03 at 08:09 +0100, Gerald Pfeifer wrote: > On Thu, 2 Feb 2017, David Malcolm wrote: > > This patch to the website moves the section about the selftest > > suite to > > the bottom of "Other significant improvements" section, and > > rewrites it > > to also cover the GIMPLE and RTL "frontends", and tries to couch > > these > > changes in terms of the benefit to the end-user (i.e. a more > > reliable > > compiler). > > Index: htdocs/gcc-7/changes.html > =================================================================== > +

GCC's already extensive self-test suite has gained some new > + capabilities, to further improve the reliability of the > compiler:

> > Would "testsuite" be sufficient here? > > (Per codingconventions.html we use "testsuite" as opposed to "test > suite", as I just checked.) Changed. > +
  • GCC now has has an internal unit testing API and a suite > of tests > + for programmatic self-testing of implementation > subsystems.
    • > > Omit "implementation"? > > Those are genuine questions (where I feel a little stronger about > the former than the latter), i.e., while I personally would make > those changes, I am not making this a requirement of my review. > > The patch is okay, just consider the above, please. I tried a few variants here, but in the end I considered your suggestion as the cleanest; thanks! Committed Dave