public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH][PR target/80083][7 regression] fix power9 vsx-small-integer issue caused by wrong constraints
@ 2017-03-20 16:11 Aaron Sawdey
  2017-03-20 18:05 ` Aaron Sawdey
  0 siblings, 1 reply; 4+ messages in thread
From: Aaron Sawdey @ 2017-03-20 16:11 UTC (permalink / raw)
  To: gcc-patches; +Cc: Segher Boessenkool, Bill Schmidt, meissner, dje.gcc

Test libgomp doacross2.f90 failed only at -O1 because an incorrect
constraint on movsi_internal1 (for vspltisw) led to confusion between
vsx and float registers (fix credit to Meissner). In subsequent
discussion David Edelsohn pointed out that there was an additional
error on the constraint for xxspltib -1 that is also fixed now.

Bootstrap/regtest reveals no errors on either power8 or power9. Ok for
trunk?

2017-03-20  Aaron Sawdey  <acsawdey@linux.vnet.ibm.com>

	PR target/80083
	* config/rs6000/rs6000.md (*movsi_internal1): incorrect constraints
	for alternatives 14/15.
 
-- 
Aaron Sawdey, Ph.D.  acsawdey@linux.vnet.ibm.com
050-2/C113  (507) 253-7520 home: 507/263-0782
IBM Linux Technology Center - PPC Toolchain

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH][PR target/80083][7 regression] fix power9 vsx-small-integer issue caused by wrong constraints
  2017-03-20 16:11 [PATCH][PR target/80083][7 regression] fix power9 vsx-small-integer issue caused by wrong constraints Aaron Sawdey
@ 2017-03-20 18:05 ` Aaron Sawdey
  2017-03-20 18:43   ` Segher Boessenkool
  0 siblings, 1 reply; 4+ messages in thread
From: Aaron Sawdey @ 2017-03-20 18:05 UTC (permalink / raw)
  To: gcc-patches; +Cc: Segher Boessenkool, Bill Schmidt, meissner, dje.gcc

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

On Mon, 2017-03-20 at 11:11 -0500, Aaron Sawdey wrote:
> Test libgomp doacross2.f90 failed only at -O1 because an incorrect
> constraint on movsi_internal1 (for vspltisw) led to confusion between
> vsx and float registers (fix credit to Meissner). In subsequent
> discussion David Edelsohn pointed out that there was an additional
> error on the constraint for xxspltib -1 that is also fixed now.
> 
> Bootstrap/regtest reveals no errors on either power8 or power9. Ok
> for
> trunk?
> 
> 2017-03-20  Aaron Sawdey  <acsawdey@linux.vnet.ibm.com>
> 
> 	PR target/80083
> 	* config/rs6000/rs6000.md (*movsi_internal1): incorrect
> constraints
> 	for alternatives 14/15.
>  

Forgot the patch! 

-- 
Aaron Sawdey, Ph.D.  acsawdey@linux.vnet.ibm.com
050-2/C113  (507) 253-7520 home: 507/263-0782
IBM Linux Technology Center - PPC Toolchain

[-- Attachment #2: pr80083.patch --]
[-- Type: text/x-patch, Size: 632 bytes --]

Index: gcc/config/rs6000/rs6000.md
===================================================================
--- gcc/config/rs6000/rs6000.md	(revision 246224)
+++ gcc/config/rs6000/rs6000.md	(working copy)
@@ -6727,7 +6727,7 @@
   [(set (match_operand:SI 0 "rs6000_nonimmediate_operand"
 		"=r,         r,           r,           ?*wI,        ?*wH,
 		 m,          ?Z,          ?Z,          r,           r,
-		 r,          ?*wIwH,      ?*wJwK,      ?*wK,        ?*wJwK,
+		 r,          ?*wIwH,      ?*wJwK,      ?*wJwK,      ?*wu,
 		 ?*wJwK,     ?*wH,        ?*wK,        ?*wIwH,      ?r,
 		 r,          *c*l,        *h,          *h")
 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH][PR target/80083][7 regression] fix power9 vsx-small-integer issue caused by wrong constraints
  2017-03-20 18:05 ` Aaron Sawdey
@ 2017-03-20 18:43   ` Segher Boessenkool
  2017-03-20 20:37     ` Segher Boessenkool
  0 siblings, 1 reply; 4+ messages in thread
From: Segher Boessenkool @ 2017-03-20 18:43 UTC (permalink / raw)
  To: Aaron Sawdey; +Cc: gcc-patches, Bill Schmidt, meissner, dje.gcc

On Mon, Mar 20, 2017 at 01:05:15PM -0500, Aaron Sawdey wrote:
> > 2017-03-20  Aaron Sawdey  <acsawdey@linux.vnet.ibm.com>
> > 
> > 	PR target/80083
> > 	* config/rs6000/rs6000.md (*movsi_internal1): incorrect
> > constraints
> > 	for alternatives 14/15.

A changelog line should describe what is changed, not what was wrong;
it should start with a capital; and you changed alternatives 13 and 14
(they start counting at 0).

> --- gcc/config/rs6000/rs6000.md	(revision 246224)
> +++ gcc/config/rs6000/rs6000.md	(working copy)
> @@ -6727,7 +6727,7 @@
>    [(set (match_operand:SI 0 "rs6000_nonimmediate_operand"
>  		"=r,         r,           r,           ?*wI,        ?*wH,
>  		 m,          ?Z,          ?Z,          r,           r,
> -		 r,          ?*wIwH,      ?*wJwK,      ?*wK,        ?*wJwK,
> +		 r,          ?*wIwH,      ?*wJwK,      ?*wJwK,      ?*wu,
>  		 ?*wJwK,     ?*wH,        ?*wK,        ?*wIwH,      ?r,
>  		 r,          *c*l,        *h,          *h")

The change to alt 13 is obvious enough.  Could you explain alt 14 a
bit more though?  It used to allow more than it does after this patch;
are those handled by other alternatives?


Segher

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH][PR target/80083][7 regression] fix power9 vsx-small-integer issue caused by wrong constraints
  2017-03-20 18:43   ` Segher Boessenkool
@ 2017-03-20 20:37     ` Segher Boessenkool
  0 siblings, 0 replies; 4+ messages in thread
From: Segher Boessenkool @ 2017-03-20 20:37 UTC (permalink / raw)
  To: Aaron Sawdey; +Cc: gcc-patches, Bill Schmidt, meissner, dje.gcc

On Mon, Mar 20, 2017 at 01:43:37PM -0500, Segher Boessenkool wrote:
> > --- gcc/config/rs6000/rs6000.md	(revision 246224)
> > +++ gcc/config/rs6000/rs6000.md	(working copy)
> > @@ -6727,7 +6727,7 @@
> >    [(set (match_operand:SI 0 "rs6000_nonimmediate_operand"
> >  		"=r,         r,           r,           ?*wI,        ?*wH,
> >  		 m,          ?Z,          ?Z,          r,           r,
> > -		 r,          ?*wIwH,      ?*wJwK,      ?*wK,        ?*wJwK,
> > +		 r,          ?*wIwH,      ?*wJwK,      ?*wJwK,      ?*wu,
> >  		 ?*wJwK,     ?*wH,        ?*wK,        ?*wIwH,      ?r,
> >  		 r,          *c*l,        *h,          *h")
> 
> The change to alt 13 is obvious enough.  Could you explain alt 14 a
> bit more though?  It used to allow more than it does after this patch;
> are those handled by other alternatives?

Okay, so it is handled by alt 18 (and a reload of the second operand)
in that case; thanks for looking!

The patch is okay (with the changelog fixed).  Thanks,


Segher

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-20 20:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-20 16:11 [PATCH][PR target/80083][7 regression] fix power9 vsx-small-integer issue caused by wrong constraints Aaron Sawdey
2017-03-20 18:05 ` Aaron Sawdey
2017-03-20 18:43   ` Segher Boessenkool
2017-03-20 20:37     ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).