From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130251 invoked by alias); 17 Jun 2017 04:09:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 130236 invoked by uid 89); 17 Jun 2017 04:09:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 17 Jun 2017 04:09:02 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5H494Tv007967 for ; Sat, 17 Jun 2017 00:09:04 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0a-001b2d01.pphosted.com with ESMTP id 2b4qba1fwj-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sat, 17 Jun 2017 00:09:04 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Jun 2017 22:08:54 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 16 Jun 2017 22:08:51 -0600 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v5H48oLi61538544; Fri, 16 Jun 2017 21:08:50 -0700 Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C10F4136044; Fri, 16 Jun 2017 22:08:50 -0600 (MDT) Received: from oc3304648336.ibm.com (unknown [9.70.82.187]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP id 71DA013603A; Fri, 16 Jun 2017 22:08:50 -0600 (MDT) Subject: [PATCH rs6000] Fix for commit 249311 From: Carl Love To: gcc-patches@gcc.gnu.org, Bill Schmidt , segher@kernel.crashing.org, David Edelsohn Cc: cel@us.ibm.com Date: Sat, 17 Jun 2017 04:09:00 -0000 Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17061704-0004-0000-0000-00001263C1B4 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007246; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00875912; UDB=6.00436156; IPR=6.00656003; BA=6.00005425; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015860; XFM=3.00000015; UTC=2017-06-17 04:08:52 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061704-0005-0000-0000-00007FCAF27B Message-Id: <1497672530.3876.11.camel@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-17_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706170071 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01252.txt.bz2 GCC maintainers: Commit r249311 had an error. During the patch review the define expand for VFC_inst was changed to VF_sxddp. I compiled and tested the source after making the change and it seemed fine. However, I missed a couple of changes. It seems that since I didn't remove all the binaries before recompiling the build tree still had the old definition in it. I also found I had to move the VF_sxddp definition back to the file where it is used. Need to make sure I do a clean build just to be sure before committing things. I found the issue after pulling down a fresh tree and compiling when the build failed. I have already applied the following change to the tree as I didn't want to leave a broken tree all weekend. Please let me know if there are any changes to this fix-up patch that you would like to see made and I will take care of it. Sorry about breaking things. Carl Love ---------------------------------------- gcc/ChangeLog: 2017-06-16 Carl Love * config/rs6000/altivec.md (define_mode_attr VF_sxddp): Move to vsx.md. * config/rs6000/vsx.md (define_mode_attr VF_sxddp define_expand "floate", define_expand "floato"): Add VF_sxddp definition, replace undefined VFC_inst with VF_sxddp definition Index: gcc/config/rs6000/vsx.md =================================================================== --- gcc/config/rs6000/vsx.md (revision 249336) +++ gcc/config/rs6000/vsx.md (revision 249337) @@ -21,6 +21,9 @@ ;; Iterator for comparison types (define_code_iterator CMP_TEST [eq lt gt unordered]) +;; Mode attribute for vector floate and floato conversions +(define_mode_attr VF_sxddp [(V2DI "sxd") (V2DF "dp")]) + ;; Iterator for both scalar and vector floating point types supported by VSX (define_mode_iterator VSX_B [DF V4SF V2DF]) @@ -2056,7 +2059,7 @@ rtx_tmp, rtx_tmp, rtx_val)); } else - emit_insn (gen_vsx_xvcvsp (operands[0], operands[1])); + emit_insn (gen_vsx_xvcvsp (operands[0], operands[1])); DONE; }) @@ -2095,7 +2098,7 @@ "VECTOR_UNIT_VSX_P (V4SFmode)" { if (VECTOR_ELT_ORDER_BIG) - emit_insn (gen_vsx_xvcvsp (operands[0], operands[1])); + emit_insn (gen_vsx_xvcvsp (operands[0], operands[1])); else { /* Shift left one word to put odd word correct location */ @@ -2103,7 +2106,7 @@ rtx rtx_val = GEN_INT (4); rtx_tmp = gen_reg_rtx (V4SFmode); - emit_insn (gen_vsx_xvcvsp (rtx_tmp, operands[1])); + emit_insn (gen_vsx_xvcvsp (rtx_tmp, operands[1])); emit_insn (gen_altivec_vsldoi_v4sf (operands[0], rtx_tmp, rtx_tmp, rtx_val)); } Index: gcc/config/rs6000/altivec.md =================================================================== --- gcc/config/rs6000/altivec.md (revision 249336) +++ gcc/config/rs6000/altivec.md (revision 249337) @@ -207,9 +207,6 @@ ;; versus floating point (define_mode_attr VS_sxwsp [(V4SI "sxw") (V4SF "sp")]) -;; Mode attribute for vector floate and floato conversions -(define_mode_attr VF_sxddp [(V2DI "sxd") (V2DF "dp")]) - ;; Specific iterator for parity which does not have a byte/half-word form, but ;; does have a quad word form (define_mode_iterator VParity [V4SI