From: David Malcolm <dmalcolm@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
Joseph Myers <joseph@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Martin Sebor <msebor@redhat.com>,
Jason Merrill <jason@redhat.com>
Subject: Re: C/C++ PATCH to implement -Wmultistatement-macros (PR c/80116)
Date: Mon, 26 Jun 2017 13:13:00 -0000 [thread overview]
Message-ID: <1498482770.7551.208.camel@redhat.com> (raw)
In-Reply-To: <20170626094029.GE4341@redhat.com>
On Mon, 2017-06-26 at 11:40 +0200, Marek Polacek wrote:
> On Mon, Jun 19, 2017 at 12:01:06PM +0200, Marek Polacek wrote:
> > On Tue, Jun 13, 2017 at 03:29:32PM +0000, Joseph Myers wrote:
> > > On Tue, 13 Jun 2017, Marek Polacek wrote:
> > >
> > > > * c-parser.c (c_parser_if_body): Set the location of
> > > > the
> > > > body of the conditional after parsing all the labels.
> > > > Call
> > > > warn_for_multistatement_macros.
> > > > (c_parser_else_body): Likewise.
> > > > (c_parser_switch_statement): Likewise.
> > > > (c_parser_while_statement): Likewise.
> > > > (c_parser_for_statement): Likewise.
> > > > (c_parser_statement): Add a default argument. Save the
> > > > location
> > > > after labels have been parsed.
> > > > (c_parser_c99_block_statement): Likewise.
> > >
> > > The gcc/c/ changes are OK.
> >
> > Thanks.
> >
> > David, do you have any more comments on the patch?
>
> Seems not, so I'll commit the patch today.
>
Oops; sorry.
I think all I had were those relatively minor comments about the
wording in the description/invoke.texi, but I have no objection to this
going into trunk as-is.
next prev parent reply other threads:[~2017-06-26 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 16:49 Marek Polacek
2017-06-08 17:24 ` David Malcolm
2017-06-08 18:10 ` Martin Sebor
2017-06-09 22:03 ` Gerald Pfeifer
2017-06-13 13:46 ` Marek Polacek
2017-07-17 8:15 ` Gerald Pfeifer
2017-07-17 9:26 ` Marek Polacek
2017-06-13 10:05 ` Marek Polacek
2017-06-13 15:29 ` Joseph Myers
2017-06-19 10:01 ` Marek Polacek
2017-06-26 9:40 ` Marek Polacek
2017-06-26 13:13 ` David Malcolm [this message]
2017-06-10 0:47 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498482770.7551.208.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=msebor@redhat.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).