* [PATCH] Add quotes to error messages related to Sanitizers.
@ 2017-07-10 9:36 Martin Liška
2017-07-10 19:35 ` Martin Sebor
2017-07-11 17:45 ` David Malcolm
0 siblings, 2 replies; 7+ messages in thread
From: Martin Liška @ 2017-07-10 9:36 UTC (permalink / raw)
To: gcc-patches; +Cc: Jakub Jelinek
[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]
Hi.
This adds missing quotes to various error messages related to AddressSanitizer.
Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
Ready to be installed?
Martin
gcc/ChangeLog:
2017-07-04 Martin Liska <mliska@suse.cz>
* opts.c (finish_options): Add quotes to error messages.
(parse_sanitizer_options): Likewise.
gcc/testsuite/ChangeLog:
2017-07-04 Martin Liska <mliska@suse.cz>
* c-c++-common/ubsan/sanitize-all-1.c: Update scanned pattern.
* c-c++-common/ubsan/sanitize-recover-1.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-2.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-5.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-7.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-8.c:Likewise.
* c-c++-common/ubsan/sanitize-recover-9.c:Likewise.
---
gcc/opts.c | 18 +++++++++---------
gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c | 2 +-
gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c | 2 +-
gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c | 2 +-
gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c | 2 +-
gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c | 2 +-
gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c | 2 +-
gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c | 2 +-
8 files changed, 16 insertions(+), 16 deletions(-)
[-- Attachment #2: 0001-Add-quotes-to-error-messages-related-to-Sanitizers.patch --]
[-- Type: text/x-patch, Size: 5918 bytes --]
diff --git a/gcc/opts.c b/gcc/opts.c
index c8affa4d704..bdcda799f8c 100644
--- a/gcc/opts.c
+++ b/gcc/opts.c
@@ -954,26 +954,26 @@ finish_options (struct gcc_options *opts, struct gcc_options *opts_set,
if ((opts->x_flag_sanitize & SANITIZE_USER_ADDRESS)
&& (opts->x_flag_sanitize & SANITIZE_KERNEL_ADDRESS))
error_at (loc,
- "-fsanitize=address is incompatible with "
- "-fsanitize=kernel-address");
+ "%<-fsanitize=address%> is incompatible with "
+ "%<-fsanitize=kernel-address%>");
/* And with TSan. */
if ((opts->x_flag_sanitize & SANITIZE_ADDRESS)
&& (opts->x_flag_sanitize & SANITIZE_THREAD))
error_at (loc,
- "-fsanitize=address and -fsanitize=kernel-address "
- "are incompatible with -fsanitize=thread");
+ "%<-fsanitize=address%> and %<-fsanitize=kernel-address%> "
+ "are incompatible with %<-fsanitize=thread%>");
if ((opts->x_flag_sanitize & SANITIZE_LEAK)
&& (opts->x_flag_sanitize & SANITIZE_THREAD))
error_at (loc,
- "-fsanitize=leak is incompatible with -fsanitize=thread");
+ "%<-fsanitize=leak%> is incompatible with %<-fsanitize=thread%>");
/* Check error recovery for -fsanitize-recover option. */
for (int i = 0; sanitizer_opts[i].name != NULL; ++i)
if ((opts->x_flag_sanitize_recover & sanitizer_opts[i].flag)
&& !sanitizer_opts[i].can_recover)
- error_at (loc, "-fsanitize-recover=%s is not supported",
+ error_at (loc, "%<-fsanitize-recover=%s%> is not supported",
sanitizer_opts[i].name);
/* When instrumenting the pointers, we don't want to remove
@@ -999,8 +999,8 @@ finish_options (struct gcc_options *opts, struct gcc_options *opts_set,
if (opts->x_flag_stack_reuse != SR_NONE
&& opts_set->x_flag_stack_reuse != SR_NONE)
error_at (loc,
- "-fsanitize-address-use-after-scope requires "
- "-fstack-reuse=none option");
+ "%<-fsanitize-address-use-after-scope%> requires "
+ "%<-fstack-reuse=none%> option");
opts->x_flag_stack_reuse = SR_NONE;
}
@@ -1621,7 +1621,7 @@ parse_sanitizer_options (const char *p, location_t loc, int scode,
if (code == OPT_fsanitize_)
{
if (complain)
- error_at (loc, "-fsanitize=all option is not valid");
+ error_at (loc, "%<-fsanitize=all%> option is not valid");
}
else
flags |= ~(SANITIZE_THREAD | SANITIZE_LEAK
diff --git a/gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c b/gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c
index 9ffba50443a..96a8cc576b6 100644
--- a/gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c
+++ b/gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c
@@ -5,4 +5,4 @@
int i;
-/* { dg-error "-fsanitize=all option is not valid" "" { target *-*-* } 0 } */
+/* { dg-error ".-fsanitize=all. option is not valid" "" { target *-*-* } 0 } */
diff --git a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c
index 4d8c27e945a..efa5ad7291f 100644
--- a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c
+++ b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c
@@ -3,4 +3,4 @@
int i;
-/* { dg-error "-fsanitize-recover=unreachable is not supported" "" { target *-*-* } 0 } */
+/* { dg-error ".-fsanitize-recover=unreachable. is not supported" "" { target *-*-* } 0 } */
diff --git a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c
index e9849bd50ab..2b7cbcb6a7f 100644
--- a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c
+++ b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c
@@ -3,4 +3,4 @@
int i;
-/* { dg-error "-fsanitize-recover=return is not supported" "" { target *-*-* } 0 } */
+/* { dg-error ".-fsanitize-recover=return. is not supported" "" { target *-*-* } 0 } */
diff --git a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c
index 9c1ed322d5e..3d2e51ebb91 100644
--- a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c
+++ b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c
@@ -3,4 +3,4 @@
int i;
-/* { dg-error "-fsanitize-recover=unreachable is not supported" "" { target *-*-* } 0 } */
+/* { dg-error ".-fsanitize-recover=unreachable. is not supported" "" { target *-*-* } 0 } */
diff --git a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c
index 26403ce2488..a571f2bcdc1 100644
--- a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c
+++ b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c
@@ -3,4 +3,4 @@
int i;
-/* { dg-error "-fsanitize=address and -fsanitize=kernel-address are incompatible with -fsanitize=thread" "" { target *-*-* } 0 } */
+/* { dg-error ".-fsanitize=address. and .-fsanitize=kernel-address. are incompatible with .-fsanitize=thread." "" { target *-*-* } 0 } */
diff --git a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c
index ecaf0e648af..97f4bf4c465 100644
--- a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c
+++ b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c
@@ -3,4 +3,4 @@
int i;
-/* { dg-error "-fsanitize=leak is incompatible with -fsanitize=thread" "" { target *-*-* } 0 } */
+/* { dg-error ".-fsanitize=leak. is incompatible with .-fsanitize=thread." "" { target *-*-* } 0 } */
diff --git a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c
index ef80ef1e27d..0800ecbe155 100644
--- a/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c
+++ b/gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c
@@ -3,4 +3,4 @@
int i;
-/* { dg-error "-fsanitize-recover=unreachable is not supported" "" { target *-*-* } 0 } */
+/* { dg-error ".-fsanitize-recover=unreachable. is not supported" "" { target *-*-* } 0 } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Add quotes to error messages related to Sanitizers.
2017-07-10 9:36 [PATCH] Add quotes to error messages related to Sanitizers Martin Liška
@ 2017-07-10 19:35 ` Martin Sebor
2017-07-11 13:33 ` Martin Liška
2017-07-11 17:45 ` David Malcolm
1 sibling, 1 reply; 7+ messages in thread
From: Martin Sebor @ 2017-07-10 19:35 UTC (permalink / raw)
To: Martin Liška, gcc-patches; +Cc: Jakub Jelinek
On 07/10/2017 03:36 AM, Martin Liška wrote:
> Hi.
>
> This adds missing quotes to various error messages related to AddressSanitizer.
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
>
> Martin
>
> gcc/ChangeLog:
>
> 2017-07-04 Martin Liska <mliska@suse.cz>
>
> * opts.c (finish_options): Add quotes to error messages.
> (parse_sanitizer_options): Likewise.
It would make a nice enhancement to -Wformat to have it detect
the missing quotes around the command line options. It seems
that it should be doable without excessive overhead simply by
scanning the format string for the " -[fmW][a-z]" pattern (or
something like it). An only slightly more involved/expensive
solution would also compare the rest of the option name against
known options and detect spelling errors in the option names.
This is not an objection to your patch which is a valuable
improvement independent of the enhancement above.
Martin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Add quotes to error messages related to Sanitizers.
2017-07-10 19:35 ` Martin Sebor
@ 2017-07-11 13:33 ` Martin Liška
0 siblings, 0 replies; 7+ messages in thread
From: Martin Liška @ 2017-07-11 13:33 UTC (permalink / raw)
To: Martin Sebor, gcc-patches; +Cc: Jakub Jelinek
On 07/10/2017 09:35 PM, Martin Sebor wrote:
> On 07/10/2017 03:36 AM, Martin Liška wrote:
>> Hi.
>>
>> This adds missing quotes to various error messages related to AddressSanitizer.
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Ready to be installed?
>>
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 2017-07-04 Martin Liska <mliska@suse.cz>
>>
>> * opts.c (finish_options): Add quotes to error messages.
>> (parse_sanitizer_options): Likewise.
>
> It would make a nice enhancement to -Wformat to have it detect
> the missing quotes around the command line options. It seems
> that it should be doable without excessive overhead simply by
> scanning the format string for the " -[fmW][a-z]" pattern (or
> something like it). An only slightly more involved/expensive
> solution would also compare the rest of the option name against
> known options and detect spelling errors in the option names.
Yep, would be nice, however I'm not sure it worth doing that. We do not
add new error messages so often.
Martin
>
> This is not an objection to your patch which is a valuable
> improvement independent of the enhancement above.
>
> Martin
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Add quotes to error messages related to Sanitizers.
2017-07-10 9:36 [PATCH] Add quotes to error messages related to Sanitizers Martin Liška
2017-07-10 19:35 ` Martin Sebor
@ 2017-07-11 17:45 ` David Malcolm
2017-07-13 12:27 ` Martin Liška
1 sibling, 1 reply; 7+ messages in thread
From: David Malcolm @ 2017-07-11 17:45 UTC (permalink / raw)
To: Martin Liška, gcc-patches; +Cc: Jakub Jelinek
On Mon, 2017-07-10 at 11:36 +0200, Martin Liška wrote:
> Hi.
>
> This adds missing quotes to various error messages related to
> AddressSanitizer.
> Patch can bootstrap on ppc64le-redhat-linux and survives regression
> tests.
>
> Ready to be installed?
LGTM, with my "diagnostic messages" maintainer hat on.
Grepping for "-f" within opts.c shows a few other diagnostics there
that could use quotes, but that's not a reason not to go ahead with
this patch.
Thanks
Dave
> Martin
>
> gcc/ChangeLog:
>
> 2017-07-04 Martin Liska <mliska@suse.cz>
>
> * opts.c (finish_options): Add quotes to error messages.
> (parse_sanitizer_options): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> 2017-07-04 Martin Liska <mliska@suse.cz>
>
> * c-c++-common/ubsan/sanitize-all-1.c: Update scanned pattern.
> * c-c++-common/ubsan/sanitize-recover-1.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-2.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-5.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-7.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-8.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-9.c:Likewise.
> ---
> gcc/opts.c | 18 +++++++++
> ---------
> gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c | 2 +-
> 8 files changed, 16 insertions(+), 16 deletions(-)
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Add quotes to error messages related to Sanitizers.
2017-07-11 17:45 ` David Malcolm
@ 2017-07-13 12:27 ` Martin Liška
2017-07-14 7:01 ` [PATCH] Add additional quotes to opts.c Martin Liška
0 siblings, 1 reply; 7+ messages in thread
From: Martin Liška @ 2017-07-13 12:27 UTC (permalink / raw)
To: David Malcolm, gcc-patches; +Cc: Jakub Jelinek
On 07/11/2017 07:45 PM, David Malcolm wrote:
> On Mon, 2017-07-10 at 11:36 +0200, Martin Liška wrote:
>> Hi.
>>
>> This adds missing quotes to various error messages related to
>> AddressSanitizer.
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression
>> tests.
>>
>> Ready to be installed?
>
> LGTM, with my "diagnostic messages" maintainer hat on.
Patch has been just installed.
>
> Grepping for "-f" within opts.c shows a few other diagnostics there
> that could use quotes, but that's not a reason not to go ahead with
> this patch.
Yep, I'm testing another patch.
Martin
>
> Thanks
> Dave
>
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 2017-07-04 Martin Liska <mliska@suse.cz>
>>
>> * opts.c (finish_options): Add quotes to error messages.
>> (parse_sanitizer_options): Likewise.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 2017-07-04 Martin Liska <mliska@suse.cz>
>>
>> * c-c++-common/ubsan/sanitize-all-1.c: Update scanned pattern.
>> * c-c++-common/ubsan/sanitize-recover-1.c:Likewise.
>> * c-c++-common/ubsan/sanitize-recover-2.c:Likewise.
>> * c-c++-common/ubsan/sanitize-recover-5.c:Likewise.
>> * c-c++-common/ubsan/sanitize-recover-7.c:Likewise.
>> * c-c++-common/ubsan/sanitize-recover-8.c:Likewise.
>> * c-c++-common/ubsan/sanitize-recover-9.c:Likewise.
>> ---
>> gcc/opts.c | 18 +++++++++
>> ---------
>> gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c | 2 +-
>> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c | 2 +-
>> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c | 2 +-
>> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c | 2 +-
>> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c | 2 +-
>> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c | 2 +-
>> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c | 2 +-
>> 8 files changed, 16 insertions(+), 16 deletions(-)
>>
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Add additional quotes to opts.c.
2017-07-13 12:27 ` Martin Liška
@ 2017-07-14 7:01 ` Martin Liška
2017-07-14 7:18 ` Jeff Law
0 siblings, 1 reply; 7+ messages in thread
From: Martin Liška @ 2017-07-14 7:01 UTC (permalink / raw)
To: David Malcolm, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
Hi.
There's a small follow up that I've just tested.
Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
Ready to be installed?
Martin
[-- Attachment #2: 0001-Add-additional-quotes-to-opts.c.patch --]
[-- Type: text/x-patch, Size: 2747 bytes --]
From 712746caf299546f2e643e9e371c077643c46ad6 Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Thu, 13 Jul 2017 14:22:50 +0200
Subject: [PATCH] Add additional quotes to opts.c.
gcc/ChangeLog:
2017-07-13 Martin Liska <mliska@suse.cz>
* opts.c (finish_options): Add quotes.
(common_handle_option): Likewise.
---
gcc/opts.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/gcc/opts.c b/gcc/opts.c
index e2e684fa009..987a7aff3fc 100644
--- a/gcc/opts.c
+++ b/gcc/opts.c
@@ -823,8 +823,8 @@ finish_options (struct gcc_options *opts, struct gcc_options *opts_set,
{
if (opts_set->x_flag_reorder_blocks_and_partition)
inform (loc,
- "-freorder-blocks-and-partition does not work "
- "with exceptions on this architecture");
+ "%<-freorder-blocks-and-partition%> does not work "
+ "with exceptions on this architecture");
opts->x_flag_reorder_blocks_and_partition = 0;
opts->x_flag_reorder_blocks = 1;
}
@@ -839,8 +839,8 @@ finish_options (struct gcc_options *opts, struct gcc_options *opts_set,
{
if (opts_set->x_flag_reorder_blocks_and_partition)
inform (loc,
- "-freorder-blocks-and-partition does not support "
- "unwind info on this architecture");
+ "%<-freorder-blocks-and-partition%> does not support "
+ "unwind info on this architecture");
opts->x_flag_reorder_blocks_and_partition = 0;
opts->x_flag_reorder_blocks = 1;
}
@@ -857,8 +857,8 @@ finish_options (struct gcc_options *opts, struct gcc_options *opts_set,
{
if (opts_set->x_flag_reorder_blocks_and_partition)
inform (loc,
- "-freorder-blocks-and-partition does not work "
- "on this architecture");
+ "%<-freorder-blocks-and-partition%> does not work "
+ "on this architecture");
opts->x_flag_reorder_blocks_and_partition = 0;
opts->x_flag_reorder_blocks = 1;
}
@@ -895,7 +895,8 @@ finish_options (struct gcc_options *opts, struct gcc_options *opts_set,
&& !opts->x_flag_use_linker_plugin)))
{
if (opts_set->x_flag_fat_lto_objects)
- error_at (loc, "-fno-fat-lto-objects are supported only with linker plugin");
+ error_at (loc, "%<-fno-fat-lto-objects%> are supported only with "
+ "linker plugin");
opts->x_flag_fat_lto_objects = 1;
}
}
@@ -2127,7 +2128,7 @@ common_handle_option (struct gcc_options *opts,
#ifndef ACCEL_COMPILER
case OPT_foffload_abi_:
- error_at (loc, "-foffload-abi option can be specified only for "
+ error_at (loc, "%<-foffload-abi%> option can be specified only for "
"offload compiler");
break;
#endif
--
2.13.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Add additional quotes to opts.c.
2017-07-14 7:01 ` [PATCH] Add additional quotes to opts.c Martin Liška
@ 2017-07-14 7:18 ` Jeff Law
0 siblings, 0 replies; 7+ messages in thread
From: Jeff Law @ 2017-07-14 7:18 UTC (permalink / raw)
To: Martin Liška, David Malcolm, gcc-patches
On 07/14/2017 01:00 AM, Martin Liška wrote:
> Hi.
>
> There's a small follow up that I've just tested.
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
> Martin
>
>
> 0001-Add-additional-quotes-to-opts.c.patch
>
>
> From 712746caf299546f2e643e9e371c077643c46ad6 Mon Sep 17 00:00:00 2001
> From: marxin <mliska@suse.cz>
> Date: Thu, 13 Jul 2017 14:22:50 +0200
> Subject: [PATCH] Add additional quotes to opts.c.
>
> gcc/ChangeLog:
>
> 2017-07-13 Martin Liska <mliska@suse.cz>
>
> * opts.c (finish_options): Add quotes.
> (common_handle_option): Likewise.
OK.
jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-14 7:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 9:36 [PATCH] Add quotes to error messages related to Sanitizers Martin Liška
2017-07-10 19:35 ` Martin Sebor
2017-07-11 13:33 ` Martin Liška
2017-07-11 17:45 ` David Malcolm
2017-07-13 12:27 ` Martin Liška
2017-07-14 7:01 ` [PATCH] Add additional quotes to opts.c Martin Liška
2017-07-14 7:18 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).