From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id E1038385C413 for ; Tue, 4 Oct 2022 09:08:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1038385C413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-ed1-x52a.google.com with SMTP id z97so17932493ede.8 for ; Tue, 04 Oct 2022 02:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date; bh=P6akqM+I2IfH/VyTcFlLFAb+Mu/wortWBu3O0UxQpBU=; b=d0PPDXUQOfdwRa+wOhBTeMgPUjCN1njmsEdkP9ecinxkRVl6VHpmwgWJ4utCEritL/ plVdzLh0oLX/TCdSrXc9dcuGLWanDFbajhXXFuVrsxBK8oZ3cT8SelFllKvYF+nUL1P1 qmmwZ0i/CLT8rnQfAjcuisSQeYmwHPQ0NH21MumYPmHxiHL89orCNRPljaYuyaHsZKQe gIvVfTp489DEt43yapVbW65gCjq770Ubi4lerPLnei8SNnBjyXSM53MmkViffK+7Wh8t eoWrIV1BOcynk+Hc8X9uq+oxDxGNXxdoD6hcxREd+1U4nmetlN+xqnoereXZksjqTqrV 4aTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=P6akqM+I2IfH/VyTcFlLFAb+Mu/wortWBu3O0UxQpBU=; b=1zn1LWu23i6VxZC1Ar+I8pxl/Y9bm22/MHgULLvVVLlVpkQEFyMQc/tXmFeHt9xG13 6T0hfW2/5ZMMWeNs5jtCFlrIPCLy/p2iMkqkRDG6NgIrGOWbfvELnWhD+PjIjn1jx9+Q k+zMw0CNb6Zjhu0SRcBeQ1Z/k0CofPGCF1nPTpv188wS2/SEU9U1dsjRtZq8G66UWTFn 1HuO3AXkjT9qDaWrNHJfCosvVIAEeIVlP2jMscTOM8iiA+XtJl9qJ6jhz75ECtJq1ziW KpqbKBbJgajxiJSl/Ol/oJZYN9rEEGOPqAPD9EfnZY2JNI7nTLFFq9nQPVIw9cJpNIbj KMQQ== X-Gm-Message-State: ACrzQf1VODIfulPUXqR5Vl67z9RVVTpxnmnhYD3fOYuUaLIYARuaQ+GZ 77KbmUJuhA5cPafRmwB8faBHuQ== X-Google-Smtp-Source: AMsMyM6UeQMce4EdexSzCoTGAKX1SEJnVf5aGV4hZoOiqQxarZnMzn9uTFQUsPS5Z1xq+yVT6TQ1oQ== X-Received: by 2002:a05:6402:90c:b0:457:b5ce:5f18 with SMTP id g12-20020a056402090c00b00457b5ce5f18mr23210438edz.309.1664874519551; Tue, 04 Oct 2022 02:08:39 -0700 (PDT) Received: from smtpclient.apple ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id 11-20020a170906300b00b007081282cbd8sm2943183ejz.76.2022.10.04.02.08.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2022 02:08:39 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: =?utf-8?Q?Re=3A_=5Bpatch=5D=C2=A0Fix_thinko_in_powerpc_default_sp?= =?utf-8?Q?ecs_for_-mabi?= From: Olivier Hainque In-Reply-To: <20221003161344.GP25951@gate.crashing.org> Date: Tue, 4 Oct 2022 11:08:38 +0200 Cc: Olivier Hainque , gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <14B88C82-AC0F-4053-B62F-48D3BBB58735@adacore.com> References: <20220923154924.GA66899@adacore.com> <20221003161344.GP25951@gate.crashing.org> To: Segher Boessenkool X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Segher, > On 3 Oct 2022, at 18:13, Segher Boessenkool = wrote: >=20 > -mabi=3D does two separate things, unfortunately. >=20 > First, you can use it to set the base ABI: elfv1, elfv2. But you can > also use it to set ABI variants, ABI options: -mabi=3D{no-,}altivec, > -mabi=3D{ieee,ibm}longdouble, -mabi=3Dvec-{extabi,default}. Things in = that > latter category are completely orthogonal to anything else (except = that > some only make sense together with some base ABIs). Ooh, I see. I understood there were abi related options internally (this is quite visible throughout the code of course) but didn't click on all the implications on the command -mabi line interface. > Base ABI is not selectable for most, it is implied by your target > triple. -mabi=3Delfv[12] only makes sense for targets that have = either of > the two by default. Yes, I can see that now. >> We have been using this for about a year now in gcc-11 based = toolchains. >> This helps our dejagnu testsuite runs for VxWorks on powerpc and=20 >> hasn't produced any ill side effect to date. >=20 > So what exactly is this meant to do? Biased by other ports, the presence of multiple -mabi switches just seemed wrong on its own, so the first level motivation was simply to address that. There might have been interactions with another change in what we observed at the time. I understand now that multiple -mabi on the command line is not a problem per se, so: > But it does not seem correct. -mabi=3DoptionA should not override the > -mabi=3DoptionB set in --with-abi=3D, where A and B are independent, = nor > should it override the base ABI. Agreed! Thanks a lot for your constructive feedback, much appreciated. With Kind Regards, Olivier