From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5649 invoked by alias); 5 Mar 2008 03:43:53 -0000 Received: (qmail 5635 invoked by uid 22791); 5 Mar 2008 03:43:53 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Mar 2008 03:43:34 +0000 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id m253hTKN008760 for ; Wed, 5 Mar 2008 03:43:30 GMT Received: from nf-out-0910.google.com (nfde27.prod.google.com [10.48.131.27]) by zps37.corp.google.com with ESMTP id m253hSXi006725 for ; Tue, 4 Mar 2008 19:43:28 -0800 Received: by nf-out-0910.google.com with SMTP id e27so812592nfd.42 for ; Tue, 04 Mar 2008 19:43:27 -0800 (PST) Received: by 10.82.171.16 with SMTP id t16mr853750bue.25.1204688607520; Tue, 04 Mar 2008 19:43:27 -0800 (PST) Received: by 10.82.158.2 with HTTP; Tue, 4 Mar 2008 19:43:27 -0800 (PST) Message-ID: <14be89990803041943i3111118cha02660c41257b4e@mail.gmail.com> Date: Wed, 05 Mar 2008 03:43:00 -0000 From: "Oleg Ryjkov" To: "Diego Novillo" Subject: Re: [tuples][patch] Converting several easy passes Cc: gcc-patches@gcc.gnu.org, "Bill Maddox" In-Reply-To: <14be89990803041647m49d9f16epbefec3c2398fd87c@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_23859_10552636.1204688607501" References: <20080304221827.GA23591@google.com> <47CDD8F9.10406@google.com> <14be89990803041647m49d9f16epbefec3c2398fd87c@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg00277.txt.bz2 ------=_Part_23859_10552636.1204688607501 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 671 It turns out that the comparison Diego pointed out "gimple_code (stmt) != GIMPLE_CALL" was a typo that caused the pass to basically not run. However with Diego's fix, it did run and broke many test cases. After some debugging and great help from Bill Maddox, we concluded that the pass_simple_dse should not be run yet, as gimple loaded_syms are not prepared yet. Thus this patch disables the simple_dse from passes.c and #if 0's the code itself. Committing, as partial reversion of my previous patch. 2008-03-04 Oleg Ryjkov * tree-ssa-dse.c (execute_simple_dse): Commented out. * passes.c (init_optimization_passes): Disabling pass_simple_dse. ------=_Part_23859_10552636.1204688607501 Content-Type: text/x-patch; name=fix.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fdfcb9tt0 Content-Disposition: attachment; filename=fix.patch Content-length: 3921 SW5kZXg6IHRyZWUtc3NhLWRzZS5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIHRyZWUtc3NhLWRzZS5jCShyZXZpc2lvbiAxMzI4ODYpCisrKyB0cmVl LXNzYS1kc2UuYwkod29ya2luZyBjb3B5KQpAQCAtNjYzLDYgKzY2Myw3IEBA IHN0cnVjdCB0cmVlX29wdF9wYXNzIHBhc3NfZHNlID0gewogc3RhdGljIHVu c2lnbmVkIGludAogZXhlY3V0ZV9zaW1wbGVfZHNlICh2b2lkKQogeworI2lm IDAKICAgZ2ltcGxlX3N0bXRfaXRlcmF0b3IgZ3NpOwogICBiYXNpY19ibG9j ayBiYjsKICAgYml0bWFwIHZhcmlhYmxlc19sb2FkZWQgPSBCSVRNQVBfQUxM T0MgKE5VTEwpOwpAQCAtNjcyLDYgKzY3Myw3IEBAIGV4ZWN1dGVfc2ltcGxl X2RzZSAodm9pZCkKICAgICAgYm9keS4gICovCiAgIEZPUl9FQUNIX0JCIChi YikKICAgICBmb3IgKGdzaSA9IGdzaV9zdGFydF9iYiAoYmIpOyAhZ3NpX2Vu ZF9wIChnc2kpOyBnc2lfbmV4dCAoJmdzaSkpCisKICAgICAgIGlmIChnaW1w bGVfbG9hZGVkX3N5bXMgKGdzaV9zdG10IChnc2kpKSkKIAliaXRtYXBfaW9y X2ludG8gKHZhcmlhYmxlc19sb2FkZWQsCiAJCQkgZ2ltcGxlX2xvYWRlZF9z eW1zIChnc2lfc3RtdCAoZ3NpKSkpOwpAQCAtNjg3LDggKzY4OSwxMCBAQCBl eGVjdXRlX3NpbXBsZV9kc2UgKHZvaWQpCiAJYm9vbCByZW1vdmVkID0gZmFs c2U7CiAgICAgICAgIHNzYV9vcF9pdGVyIGl0ZXI7CiAKLQlpZiAoZ2ltcGxl X3N0b3JlZF9zeW1zIChzdG10KSAmJiAoZ2ltcGxlX2NvZGUgKHN0bXQpID09 IEdJTVBMRV9BU1NJR04KLQkgICAgfHwgZ2ltcGxlX2NvZGUgKHN0bXQpICE9 IEdJTVBMRV9SRVRVUk4pCisJaWYgKGdpbXBsZV9zdG9yZWRfc3ltcyAoc3Rt dCkKKyAgICAgICAgICAgICYmIChnaW1wbGVfY29kZSAoc3RtdCkgPT0gR0lN UExFX0FTU0lHTgorCSAgICAgICAgfHwgKGdpbXBsZV9jb2RlIChzdG10KSA9 PSBHSU1QTEVfQ0FMTAorICAgICAgICAgICAgICAgICAgICAmJiBnaW1wbGVf Y2FsbF9saHMgKHN0bXQpKSkKIAkgICAgJiYgIWJpdG1hcF9pbnRlcnNlY3Rf cCAoZ2ltcGxlX3N0b3JlZF9zeW1zIChzdG10KSwgdmFyaWFibGVzX2xvYWRl ZCkpCiAJICB7CiAJICAgIHVuc2lnbmVkIGludCBpOwpAQCAtNzMwLDExICs3 MzQsMTIgQEAgZXhlY3V0ZV9zaW1wbGVfZHNlICh2b2lkKQogCSAgICAgICAg JiYgVFJFRV9USElTX1ZPTEFUSUxFIChnaW1wbGVfYXNzaWduX3JoczEgKHN0 bXQpKSkKIAkgICAgICBkZWFkID0gZmFsc2U7CiAKLQkgICAgaWYgKGRlYWQg JiYgZ2ltcGxlX2NvZGUgKHN0bXQpID09IEdJTVBMRV9DQUxMKQorCSAgICBp ZiAoZGVhZCkKIAkgICAgICB7CiAJCS8qIFdoZW4gTEhTIG9mIHZhciA9IGNh bGwgKCk7IGlzIGRlYWQsIHNpbXBsaWZ5IGl0IGludG8KIAkJICAgY2FsbCAo KTsgc2F2aW5nIG9uZSBvcGVyYW5kLiAgKi8KLSAgICAgICAgICAgICAgICBp ZiAoZ2ltcGxlX2hhc19zaWRlX2VmZmVjdHMgKHN0bXQpKQorICAgICAgICAg ICAgICAgIGlmIChnaW1wbGVfY29kZSAoc3RtdCkgPT0gR0lNUExFX0NBTEwK KyAgICAgICAgICAgICAgICAgICAgJiYgZ2ltcGxlX2hhc19zaWRlX2VmZmVj dHMgKHN0bXQpKQogCQkgIHsKIAkJICAgIGlmIChkdW1wX2ZpbGUgJiYgKGR1 bXBfZmxhZ3MgJiBUREZfREVUQUlMUykpCiAJCSAgICAgIHsKQEAgLTc2Niw2 ICs3NzEsNyBAQCBleGVjdXRlX3NpbXBsZV9kc2UgKHZvaWQpCiAgICAgICB9 CiAgIEJJVE1BUF9GUkVFICh2YXJpYWJsZXNfbG9hZGVkKTsKICAgcmV0dXJu IHRvZG87CisjZW5kaWYKIH0KIAogc3RydWN0IHRyZWVfb3B0X3Bhc3MgcGFz c19zaW1wbGVfZHNlID0KSW5kZXg6IENoYW5nZUxvZy50dXBsZXMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nLnR1cGxlcwkocmV2aXNp b24gMTMyODg2KQorKysgQ2hhbmdlTG9nLnR1cGxlcwkod29ya2luZyBjb3B5 KQpAQCAtMSw1ICsxLDEwIEBACiAyMDA4LTAzLTA0ICBPbGVnIFJ5amtvdiAg PG9sZWdyQGdvb2dsZS5jb20+CiAKKwkqIHRyZWUtc3NhLWRzZS5jIChleGVj dXRlX3NpbXBsZV9kc2UpOiBDb21tZW50ZWQgb3V0LgorCSogcGFzc2VzLmMg KGluaXRfb3B0aW1pemF0aW9uX3Bhc3Nlcyk6IERpc2FibGluZyBwYXNzX3Np bXBsZV9kc2UuCisKKzIwMDgtMDMtMDQgIE9sZWcgUnlqa292ICA8b2xlZ3JA Z29vZ2xlLmNvbT4KKwogCSogdHJlZS1zc2EtZHNlLmMgKGV4ZWN1dGVfc2lt cGxlX2RzZSk6IFR1cGxpZmllZC4KIAkqIGdpbXBsaWZ5LmMgKGdpbXBsaWZ5 X3JldHVybl9leHByKTogQ29weSB0aGUgTk9fV0FSTklORyBmbGFnCiAJdG8g dGhlIG5ld2x5IGNyZWF0ZWQgZXhwciBmcm9tIHRoZSB0cmVlLgpJbmRleDog cGFzc2VzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGFzc2VzLmMJ KHJldmlzaW9uIDEzMjg4NikKKysrIHBhc3Nlcy5jCSh3b3JraW5nIGNvcHkp CkBAIC01MzcsOSArNTM3LDkgQEAgaW5pdF9vcHRpbWl6YXRpb25fcGFzc2Vz ICh2b2lkKQogCSAgTkVYVF9QQVNTIChwYXNzX2Zvcndwcm9wKTsKICNlbmRp ZgogCSAgTkVYVF9QQVNTIChwYXNzX3VwZGF0ZV9hZGRyZXNzX3Rha2VuKTsK LQkgIE5FWFRfUEFTUyAocGFzc19zaW1wbGVfZHNlKTsKIC8qIEZJWE1FIHR1 cGxlcy4gICovCiAjaWYgMAorCSAgTkVYVF9QQVNTIChwYXNzX3NpbXBsZV9k c2UpOwogCSAgTkVYVF9QQVNTIChwYXNzX3NyYV9lYXJseSk7CiAJICBORVhU X1BBU1MgKHBhc3NfY29weV9wcm9wKTsKIAkgIE5FWFRfUEFTUyAocGFzc19t ZXJnZV9waGkpOwo= ------=_Part_23859_10552636.1204688607501--