From: "Oleg Ryjkov" <olegr@google.com>
To: "Richard Guenther" <richard.guenther@gmail.com>
Cc: "Diego Novillo" <dnovillo@google.com>, gcc-patches@gcc.gnu.org
Subject: Re: [tuples][patch] Removing gimplify_val
Date: Fri, 14 Mar 2008 17:36:00 -0000 [thread overview]
Message-ID: <14be89990803141020g5d8e8b8fscb2a5613f3b46728@mail.gmail.com> (raw)
In-Reply-To: <84fc9c000803140724l40c8d86cx2fc31384f9a9b769@mail.gmail.com>
Oh, thanks for the suggestion - I'll work on moving this into the
mainline as well.
Oleg
On Fri, Mar 14, 2008 at 7:24 AM, Richard Guenther
<richard.guenther@gmail.com> wrote:
>
> On Fri, Mar 14, 2008 at 3:20 PM, Diego Novillo <dnovillo@google.com> wrote:
> > On 3/14/08 2:37 AM, Richard Guenther wrote:
> >
> > > Can you do so on the trunk as well? The only difference I see with
> > > the two functions is that gimplify_val sets location information on
> > > the new stmt - you may want to do some digging in the archives
> > > for what reason this went in and eventually update force_gimple_operand_bsi
> > > to do so as well.
> >
> > Good idea. Oleg, please submit this patch for mainline. Make
> > force_gimple_operand_gsi set the location of all the statements in STMTS
> > in the loop that scans for symbols to rename.
>
> There's also the related cleanup (that was posted for 4.3 but taken out again -
> I don't remember by whom) of moving the symbol renaming stuff from
> force_gimple_operand_bsi to force_gimple_operand to have their
> behavior consistent in thsi regard.
>
> Richard.
>
prev parent reply other threads:[~2008-03-14 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 0:04 Oleg Ryjkov
2008-03-14 0:16 ` Diego Novillo
2008-03-14 9:48 ` Richard Guenther
2008-03-14 10:07 ` Paolo Bonzini
2008-03-14 14:21 ` Diego Novillo
2008-03-14 14:31 ` Richard Guenther
2008-03-14 17:36 ` Oleg Ryjkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14be89990803141020g5d8e8b8fscb2a5613f3b46728@mail.gmail.com \
--to=olegr@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).