From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19926 invoked by alias); 14 Mar 2008 17:20:25 -0000 Received: (qmail 19917 invoked by uid 22791); 14 Mar 2008 17:20:25 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 17:20:08 +0000 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id m2EHK6JT012207 for ; Fri, 14 Mar 2008 10:20:06 -0700 Received: from el-out-1112.google.com (eles27.prod.google.com [10.126.170.27]) by zps37.corp.google.com with ESMTP id m2EHJmYS012915 for ; Fri, 14 Mar 2008 10:20:04 -0700 Received: by el-out-1112.google.com with SMTP id s27so2407061ele.1 for ; Fri, 14 Mar 2008 10:20:04 -0700 (PDT) Received: by 10.142.217.17 with SMTP id p17mr5161858wfg.139.1205515204262; Fri, 14 Mar 2008 10:20:04 -0700 (PDT) Received: by 10.142.108.10 with HTTP; Fri, 14 Mar 2008 10:20:04 -0700 (PDT) Message-ID: <14be89990803141020g5d8e8b8fscb2a5613f3b46728@mail.gmail.com> Date: Fri, 14 Mar 2008 17:36:00 -0000 From: "Oleg Ryjkov" To: "Richard Guenther" Subject: Re: [tuples][patch] Removing gimplify_val Cc: "Diego Novillo" , gcc-patches@gcc.gnu.org In-Reply-To: <84fc9c000803140724l40c8d86cx2fc31384f9a9b769@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <14be89990803131659i6f5e18c6hcdb62d81f2f7190d@mail.gmail.com> <84fc9c000803140237k278dacbai407677c4c0cae575@mail.gmail.com> <47DA89BD.2050004@google.com> <84fc9c000803140724l40c8d86cx2fc31384f9a9b769@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg00910.txt.bz2 Oh, thanks for the suggestion - I'll work on moving this into the mainline as well. Oleg On Fri, Mar 14, 2008 at 7:24 AM, Richard Guenther wrote: > > On Fri, Mar 14, 2008 at 3:20 PM, Diego Novillo wrote: > > On 3/14/08 2:37 AM, Richard Guenther wrote: > > > > > Can you do so on the trunk as well? The only difference I see with > > > the two functions is that gimplify_val sets location information on > > > the new stmt - you may want to do some digging in the archives > > > for what reason this went in and eventually update force_gimple_operand_bsi > > > to do so as well. > > > > Good idea. Oleg, please submit this patch for mainline. Make > > force_gimple_operand_gsi set the location of all the statements in STMTS > > in the loop that scans for symbols to rename. > > There's also the related cleanup (that was posted for 4.3 but taken out again - > I don't remember by whom) of moving the symbol renaming stuff from > force_gimple_operand_bsi to force_gimple_operand to have their > behavior consistent in thsi regard. > > Richard. >